chore: install helm with mise (#1439)

* chore: install helm with mise

* chore: remove duplicated KIC CRDs from gateway-operator KIC subchart

* chore: set helm version to 3.19.2

* chore: regenerate golden test files

* chore: don't install kic CRD for KGO chart

Author: pmalek

.github/workflows/release-pr.yaml

@@ -21,6 +21,8 @@ env:
   # Specify this here because these tests rely on ktf to run kind for cluster creation.
   # renovate: datasource=github-releases depName=kubernetes-sigs/kind
   KIND_VERSION: "0.30.0"
+  MISE_VERBOSE: 1
+  MISE_DEBUG: 1
 
 jobs:
   ensure-actions-sha-pin:
@@ -49,9 +51,6 @@ jobs:
           install: false
 
       - name: Run linters
-        env:
-          MISE_VERBOSE: 1
-          MISE_DEBUG: 1
         run: make lint
 
   lint-test:
@@ -76,21 +75,20 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Set up Helm
-        uses: azure/setup-helm@1a275c3b69536ee54be43f2070a358922e12c8d4 # v4.3.1
-
-      - name: Add Helm repos
-        run: |
-          helm repo add bitnami https://charts.bitnami.com/bitnami
-          helm repo add kong https://charts.konghq.com
-
       - uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0
         with:
           python-version: "3.11"
 
+      - uses: jdx/mise-action@146a28175021df8ca24f8ee1828cc2a60f980bd5 # v3.5.1
+
       - name: Set up chart-testing
         uses: helm/chart-testing-action@6ec842c01de15ebb84c8627d2744a0c2f2755c9f # v2.8.0
 
+      - name: Add Helm repos
+        run: |
+          helm repo add bitnami https://charts.bitnami.com/bitnami
+          helm repo add kong https://charts.konghq.com
+
       - name: Run chart-testing (lint)
         run: ct lint --target-branch main --check-version-increment=false
 
@@ -102,8 +100,13 @@ jobs:
 
       - name: Run chart-testing (install)
         run: |
+          helm version
           kubectl create ns kong-test
-          ct install --target-branch main --charts charts/${{ matrix.chart-name}} --namespace kong-test
+          ct install --target-branch main \
+            --helm-extra-args "--wait" \
+            --helm-extra-args "--timeout=3m" \
+            --charts charts/${{ matrix.chart-name}} \
+            --namespace kong-test
           # No need to delete the ns the cluster is scrapped after the job anyway.
 
   integration-test:
@@ -143,8 +146,7 @@ jobs:
       - name: Checkout
         uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
 
-      - name: setup helm
-        uses: azure/setup-helm@1a275c3b69536ee54be43f2070a358922e12c8d4 # v4.3.1
+      - uses: jdx/mise-action@146a28175021df8ca24f8ee1828cc2a60f980bd5 # v3.5.1
 
       - name: setup testing environment (kind-cluster)
         env:
@@ -179,15 +181,11 @@ jobs:
       - name: checkout
         uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
 
-      - name: setup helm
-        uses: azure/setup-helm@1a275c3b69536ee54be43f2070a358922e12c8d4 # v4.3.1
-
       - uses: jdx/mise-action@146a28175021df8ca24f8ee1828cc2a60f980bd5 # v3.5.1
-        with:
-          install: false
 
       - name: build helm chart dependency
         run: |
+          helm version
           helm repo add bitnami https://charts.bitnami.com/bitnami
           helm repo add kong https://charts.konghq.com
           helm dependency build charts/kong

.github/workflows/release-push.yaml

@@ -9,6 +9,10 @@ on:
 permissions:
   contents: read
 
+env:
+  MISE_VERBOSE: 1
+  MISE_DEBUG: 1
+
 jobs:
   release:
     timeout-minutes: 10
@@ -34,8 +38,8 @@ jobs:
           git config user.email "[email protected]"
 
       # See https://github.com/helm/chart-releaser-action/issues/6
-      - name: Set up Helm
-        uses: azure/setup-helm@1a275c3b69536ee54be43f2070a358922e12c8d4 # v4.3.1
+
+      - uses: jdx/mise-action@146a28175021df8ca24f8ee1828cc2a60f980bd5 # v3.5.1
 
       - name: Add dependency chart repos
         run: |

.mise.toml

@@ -0,0 +1,8 @@
+[tools."http:helm"]
+# renovate: datasource=github-releases depName=helm/helm
+version = "3.19.2"
+
+[tools."http:helm".platforms]
+linux-x64 = { url = "https://get.helm.sh/helm-v{version}-linux-amd64.tar.gz" }
+linux-arm64 = { url = "https://get.helm.sh/helm-v{version}-linux-arm64.tar.gz" }
+macos-arm64 = { url = "https://get.helm.sh/helm-v{version}-darwin-arm64.tar.gz" }

Makefile

@@ -2,6 +2,7 @@ PROJECT_DIR := $(shell dirname $(abspath $(lastword $(MAKEFILE_LIST))))
 TOOLS_VERSIONS_FILE = .tools_versions.yaml
 
 MISE := $(shell which mise)
+MISE_FILE := .mise.toml
 .PHONY: mise
 mise:
 	@mise -V >/dev/null || (echo "mise - https://github.com/jdx/mise - not found. Please install it." && exit 1)
@@ -20,16 +21,16 @@ mise-install: mise
 	@$(MISE) install -q $(DEP_VER)
 
 KUBE_LINTER_VERSION = $(shell yq -ojson -r '.kube-linter' < $(TOOLS_VERSIONS_FILE))
-KUBE_LINTER = $(PROJECT_DIR)/bin/installs/kube-linter/v$(KUBE_LINTER_VERSION)/bin/kube-linter
+KUBE_LINTER = $(PROJECT_DIR)/bin/installs/kube-linter/$(KUBE_LINTER_VERSION)/bin/kube-linter
 .PHONY: kube-linter
 kube-linter: mise
 	@$(MAKE) mise-plugin-install DEP=kube-linter
-	@$(MAKE) mise-install DEP_VER=kube-linter@v$(KUBE_LINTER_VERSION)
+	@$(MAKE) mise-install DEP_VER=kube-linter@$(KUBE_LINTER_VERSION)
 
 CHARTSNAP_VERSION = $(shell yq -ojson -r '.chartsnap' < $(TOOLS_VERSIONS_FILE))
 .PHONY: chartsnap
-chartsnap:
-	CHARTSNAP_VERSION=${CHARTSNAP_VERSION} ./scripts/install-chartsnap.sh
+chartsnap: download.helm
+	HELM=$(HELM) CHARTSNAP_VERSION=${CHARTSNAP_VERSION} ./scripts/install-chartsnap.sh
 
 SHELLCHECK_VERSION = $(shell yq -ojson -r '.shellcheck' < $(TOOLS_VERSIONS_FILE))
 SHELLCHECK = $(PROJECT_DIR)/bin/installs/shellcheck/$(SHELLCHECK_VERSION)/bin/shellcheck
@@ -45,6 +46,16 @@ download.actionlint: mise ## Download actionlint locally if necessary.
 	@$(MISE) plugin install --yes -q actionlint
 	@$(MISE) install -q actionlint@$(ACTIONLINT_VERSION)
 
+HELM_VERSION = $(shell yq -p toml -o yaml '.tools["http:helm"].version' < $(MISE_FILE))
+HELM = $(PROJECT_DIR)/bin/installs/http-helm/$(HELM_VERSION)/helm
+.PHONY: download.helm
+download.helm: mise ## Download helm locally if necessary.
+	@$(MAKE) mise-install DEP_VER=http:helm
+
+.PHONY: print.helm
+print.helm: download.helm
+	@echo "$(HELM)"
+
 .PHONY: verify.diff
 verify.diff:
 	@$(PROJECT_DIR)/scripts/verify-diff.sh $(PROJECT_DIR)
@@ -79,8 +90,8 @@ test.golden:
 	(echo "$$GOLDEN_TEST_FAILURE_MSG" && exit 1)
 
 .PHONY: test.golden.update
-test.golden.update:
-	helm repo update kong
+test.golden.update: download.helm
+	$(HELM) repo update kong
 	@ $(MAKE) _chartsnap CHART=kong CHARTSNAP_ARGS="-u"
 	@ $(MAKE) _chartsnap CHART=ingress CHARTSNAP_ARGS="-u"
 	@ $(MAKE) _chartsnap CHART=gateway-operator CHARTSNAP_ARGS="-u"
@@ -94,7 +105,7 @@ export GOLDEN_TEST_FAILURE_MSG
 
 .PHONY: _chartsnap
 _chartsnap: _chartsnap.deps
-	helm chartsnap \
+	$(HELM) chartsnap \
 		-c ./charts/$(CHART) \
 		-f ./charts/$(CHART)/ci/ \
 		$(CHARTSNAP_ARGS) \
@@ -107,7 +118,7 @@ _chartsnap: _chartsnap.deps
 		--api-versions admissionregistration.k8s.io/v1/ValidatingAdmissionPolicyBinding
 
 .PHONY: _chartsnap.deps
-_chartsnap.deps: chartsnap
+_chartsnap.deps: download.helm chartsnap
 	@ if [ "$(CHART)" = "kong" ]; then \
-		helm dependencies update charts/ingress; \
+		$(HELM) dependencies update charts/ingress; \
 	fi