Problem Statement
Generated Konnect entities currently still require hand-written condition constants in api/konnect/v1alpha1/konnect_conditions.go.
For example, when adding KonnectEventDataPlaneCertificate support in #3890, we had to manually add Event Gateway-specific condition constants such as:
EventGatewayRefValidConditionType
EventGatewayRefReasonValid
EventGatewayRefReasonInvalid
EventGatewayRefReasonNotProgrammed
This does not scale as more generated entities and generated reference handlers are introduced. It also creates another manual follow-up step during review, similar to the previously tracked manual SDK ops and RBAC wiring issues.
Proposed Solution
Extend the reconciler/code generation flow so condition constants needed by generated Konnect entities are also generated rather than maintained manually in api/konnect/v1alpha1/konnect_conditions.go.
This likely needs to cover at least:
- A source of truth for generated condition definitions
- Generation of condition type / reason constants for generated refs and generated entities
- A clear decision on whether each generated CRD gets its own condition set, or whether some condition groups should be shared across entities
Additional Information
This issue is intentionally scoped to condition constant generation and the shape of generated condition sets.
It does not cover the implementation of a particular generated entity.
Acceptance Criteria
Out of scope
Problem Statement
Generated Konnect entities currently still require hand-written condition constants in
api/konnect/v1alpha1/konnect_conditions.go.For example, when adding
KonnectEventDataPlaneCertificatesupport in #3890, we had to manually add Event Gateway-specific condition constants such as:EventGatewayRefValidConditionTypeEventGatewayRefReasonValidEventGatewayRefReasonInvalidEventGatewayRefReasonNotProgrammedThis does not scale as more generated entities and generated reference handlers are introduced. It also creates another manual follow-up step during review, similar to the previously tracked manual SDK ops and RBAC wiring issues.
Proposed Solution
Extend the reconciler/code generation flow so condition constants needed by generated Konnect entities are also generated rather than maintained manually in
api/konnect/v1alpha1/konnect_conditions.go.This likely needs to cover at least:
Additional Information
This issue is intentionally scoped to condition constant generation and the shape of generated condition sets.
It does not cover the implementation of a particular generated entity.
Acceptance Criteria
Documentation is updated with this new feature / enhancementHelm chart is updated to work with this feature / enhancementapi/konnect/v1alpha1/konnect_conditions.goOut of scope