Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(admin): reject AdminAPI call with empty tags #13723

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(admin): reject AdminAPI call with empty tags #13723

wants to merge 1 commit into from
+60 −5

Conversation

nowNick
Copy link
Contributor

@nowNick nowNick commented Sep 30, 2024 •
edited
Loading

Summary

When querying entities that have tags assigned a user can send a request with tags parameter. Previously sending tags='' (empty string or explicit nil) resulted in 500 error. This commit changes that so that it returns 400 error as empty explicit tags are not allowed

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-5496
Fix #13591

@github-actions github-actions bot added core/admin-api cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Sep 30, 2024
@nowNick
fix(admin): reject AdminAPI call with empty tags
813fd53 
When querying entities that have tags assigned a user can send
a request with `tags` parameter. Previously sending `tags=''`
(empty string or explicit nil) resulted in 500 error.
This commit changes that so that it returns 400 error as empty
explicit tags are not allowed

KAG-5496
Fix #13591
@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 1, 2024
@nowNick nowNick marked this pull request as ready for review October 1, 2024 17:17
@nowNick nowNick changed the title fix(admin): allow to receive empty tags fix(admin): reject AdminAPI call with empty tags Oct 1, 2024
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nowNick nowNick

Labels
author/community PRs from the open-source community (not Kong Inc) cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/admin-api size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error occurs on endpoints when tags parameter is empty
2 participants
@nowNick @team-gateway-bot