-
Notifications
You must be signed in to change notification settings - Fork 14
Expand file tree
/
Copy pathdashboardSchema.v2.spec.ts
More file actions
211 lines (199 loc) · 6.88 KB
/
dashboardSchema.v2.spec.ts
File metadata and controls
211 lines (199 loc) · 6.88 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
import Ajv from 'ajv'
import { describe, expect, it } from 'vitest'
import {
apiUsageQuerySchema,
barChartSchema,
basicQuerySchema,
dashboardConfigSchema,
llmUsageSchema,
mcpUsageSchema,
validDashboardQuery,
platformQuerySchema,
} from './dashboardSchema.v2'
import {
aiExploreAggregations,
basicExploreAggregations,
exploreAggregations,
exploreFilterTypesV2,
filterableAiExploreDimensions,
filterableBasicExploreDimensions,
filterableExploreDimensions,
filterableMcpExploreDimensions,
mcpExploreAggregations,
queryableAiExploreDimensions,
queryableBasicExploreDimensions,
queryableExploreDimensions,
queryableMcpExploreDimensions,
requestFilterTypeEmptyV2,
} from './types'
const ajv = new Ajv({ allowUnionTypes: true })
const validateValidDashboardQuery = ajv.compile(validDashboardQuery)
const validatePlatformQuerySchema = ajv.compile(platformQuerySchema)
const validateDashboardConfigSchema = ajv.compile(dashboardConfigSchema)
const validateApiUsageQuerySchema = ajv.compile(apiUsageQuerySchema)
const validateBasicQuerySchema = ajv.compile(basicQuerySchema)
const validateLlmUsageQuerySchema = ajv.compile(llmUsageSchema)
const validateMcpUsageQuerySchema = ajv.compile(mcpUsageSchema)
describe('dashboardSchema.v2', () => {
const sharedPresetFilterableDimensions = [
...new Set([
...filterableExploreDimensions,
...filterableBasicExploreDimensions,
...filterableAiExploreDimensions,
...filterableMcpExploreDimensions,
]),
]
const platformQuery = {
datasource: 'platform',
metrics: ['custom_metric_name'],
dimensions: ['custom_dimension_name'],
filters: [
{
operator: 'custom_platform_operator',
field: 'custom_filter_field',
value: ['custom_value'],
},
],
}
const dashboardConfig = {
tiles: [
{
type: 'chart',
definition: {
query: {
...platformQuery,
},
chart: {
type: 'horizontal_bar',
},
},
layout: {
position: {
col: 1,
row: 1,
},
size: {
cols: 1,
rows: 1,
},
},
},
],
preset_filters: [
{
operator: 'in',
field: 'gateway_service',
value: ['example-service'],
},
],
}
const mixedDashboardConfig = {
...dashboardConfig,
tiles: [
dashboardConfig.tiles[0],
{
type: 'chart',
definition: {
query: {
datasource: 'api_usage',
metrics: ['request_count'],
dimensions: ['gateway_service'],
filters: [
{
operator: 'in',
field: 'gateway_service',
value: ['example-service'],
},
],
},
chart: {
type: 'horizontal_bar',
},
},
layout: {
position: {
col: 2,
row: 1,
},
size: {
cols: 1,
rows: 1,
},
},
},
],
}
const strictQuery = {
datasource: 'api_usage',
metrics: ['request_count'],
dimensions: ['gateway_service'],
filters: [
{
operator: 'in',
field: 'gateway_service',
value: ['example-service'],
},
],
}
it('accepts platform queries with arbitrary strings at runtime', () => {
expect(validatePlatformQuerySchema(platformQuery)).toBe(true)
expect(validateValidDashboardQuery(platformQuery)).toBe(true)
expect(validateDashboardConfigSchema(dashboardConfig)).toBe(true)
expect(validateDashboardConfigSchema(mixedDashboardConfig)).toBe(true)
})
it.each([
[apiUsageQuerySchema, exploreAggregations, queryableExploreDimensions, filterableExploreDimensions],
[basicQuerySchema, basicExploreAggregations, queryableBasicExploreDimensions, filterableBasicExploreDimensions],
[llmUsageSchema, aiExploreAggregations, queryableAiExploreDimensions, filterableAiExploreDimensions],
[mcpUsageSchema, mcpExploreAggregations, queryableMcpExploreDimensions, filterableMcpExploreDimensions],
])('keeps strict enums for existing datasource schemas', (schema, expectedMetrics, expectedDimensions, expectedFilterableDimensions) => {
expect(schema.properties.datasource.enum).toHaveLength(1)
expect(schema.properties.metrics.items.enum).toEqual(expectedMetrics)
expect(schema.properties.dimensions.items.enum).toEqual(expectedDimensions)
expect(schema.properties.filters.items.oneOf[0].properties.field.enum).toEqual(expectedFilterableDimensions)
expect(schema.properties.filters.items.oneOf[1].properties.field.enum).toEqual(expectedFilterableDimensions)
})
it('loosens only the platform branch', () => {
expect(platformQuerySchema.properties.datasource.enum).toEqual(['platform'])
expect(platformQuerySchema.properties.metrics.items.enum).toBeUndefined()
expect(platformQuerySchema.properties.dimensions.items.enum).toBeUndefined()
expect(platformQuerySchema.properties.filters.items.oneOf[0].properties.field.enum).toBeUndefined()
expect(platformQuerySchema.properties.filters.items.oneOf[1].properties.field.enum).toBeUndefined()
expect(platformQuerySchema.properties.filters.items.oneOf[0].properties.operator.enum).toBeUndefined()
expect(platformQuerySchema.properties.filters.items.oneOf[1].properties.operator.enum).toBeUndefined()
})
it('keeps shared preset filters strict and operator enums intact', () => {
expect(dashboardConfigSchema.properties.preset_filters.items.oneOf[0].properties.field.enum).toEqual(sharedPresetFilterableDimensions)
expect(dashboardConfigSchema.properties.preset_filters.items.oneOf[1].properties.field.enum).toEqual(sharedPresetFilterableDimensions)
expect(dashboardConfigSchema.properties.preset_filters.items.oneOf[0].properties.operator.enum).toEqual(exploreFilterTypesV2)
expect(dashboardConfigSchema.properties.preset_filters.items.oneOf[1].properties.operator.enum).toEqual(requestFilterTypeEmptyV2)
expect(barChartSchema.properties.type.enum).toEqual(['horizontal_bar', 'vertical_bar'])
})
it('rejects arbitrary strings for strict schemas', () => {
const invalidStrictQuery = {
...strictQuery,
metrics: ['custom_metric_name'],
dimensions: ['custom_dimension_name'],
filters: [
{
operator: 'in',
field: 'custom_filter_field',
value: ['custom_value'],
},
],
}
expect(validateApiUsageQuerySchema(invalidStrictQuery)).toBe(false)
expect(validateBasicQuerySchema({
...invalidStrictQuery,
datasource: 'basic',
})).toBe(false)
expect(validateLlmUsageQuerySchema({
...invalidStrictQuery,
datasource: 'llm_usage',
})).toBe(false)
expect(validateMcpUsageQuerySchema({
...invalidStrictQuery,
datasource: 'agentic_usage',
})).toBe(false)
})
})