Data sources are not implemented correctly

[scastria]

The primary purpose of a data source is to lookup the id (or some other hard to find property) of something by a user friendly name. Just like a reference table in a DB. Take konnect_gateway_control_plane data source for example. This is an important data source as the control plane id is required for most other resources. Therefore, given the name of a control plane, I should be able to use the konnect_gateway_control_plane data source to lookup the control plane by name to then use the id it read as input to other resources. The konnect_gateway_control_plane data source is currently implemented with id as a required property and name as a computed property. That is backwards. name should be an required/optional input field and id should be the computed field. If I knew the value of id, then I wouldn't be using the data source to look it up in the first place.

[scastria]

I suspect that because this TF provider was auto-generated, that the control plane data source is probably not the only issue. Therefore, I suggest an audit of all data sources to make sure the id property is not required.

[mheap]

Adding a note - the generator we use doesn't support deepObject definitions in OAS yet which are required to build data sources that let you filter by name

[d19dotca]

Hi @mheap. Just FYI, a customer filed a support case (#00048859) about this issue today. They are requesting the ability to reference control planes by name rather than id.

In order to move into the official Konnect TF provider, we need a lookup by name not just id.

[scastria]

@d19dotca Although I would prefer Kong takeover ownership of my TF provider as it has useable data sources and supports custom plugins, there is a workaround you could provide your customer. One of the strengths of TF over deck are all of the providers available and the ability to mix and match them. So your customer could use BOTH my TF provider AND this official TF provider at the same time. They could use my provider just for the data sources to look up by name, and then use the ID retrieved by those data sources as inputs to the resources in this official TF provider.