Skip to content

Commit 156f6a6

Browse files
authored
feat: Missing tab name (kyma-project#4592)
* feat: Add tab names to modules page * Add tab name to Helm Releases
1 parent f2bce07 commit 156f6a6

File tree

4 files changed

+11
-1
lines changed

4 files changed

+11
-1
lines changed

src/components/Extensibility/ExtensibilityDetails.jsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import pluralize from 'pluralize';
22
import { useContext, useEffect } from 'react';
33
import { useSetAtom } from 'jotai';
4+
import { useTranslation } from 'react-i18next';
45

56
import { usePrepareDetailsProps } from 'resources/helpers';
67
import { ResourceDetails } from 'shared/components/ResourceDetails/ResourceDetails';
@@ -33,6 +34,8 @@ export const ExtensibilityDetailsCore = ({
3334
headerActions,
3435
}) => {
3536
const { t, widgetT, exists } = useGetTranslation();
37+
const { t: tBusola } = useTranslation();
38+
3639
const setResourcesConditions = useSetAtom(resourcesConditionsAtom);
3740
const {
3841
urlPath,
@@ -111,6 +114,7 @@ export const ExtensibilityDetailsCore = ({
111114
disableDelete={disableDelete}
112115
resourceTitle={resourceTitle}
113116
headerActions={headerActions}
117+
windowTitle={isModule ? tBusola('kyma-modules.title') : null}
114118
customColumns={
115119
Array.isArray(header)
116120
? header.map((def, i) => ({

src/components/HelmReleases/HelmReleasesList.jsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,19 @@ import {
1313
} from 'components/HelmReleases';
1414
import { ResourcesList } from 'shared/components/ResourcesList/ResourcesList';
1515
import { HelmReleaseStatus } from './HelmReleaseStatus';
16+
import { useWindowTitle } from 'shared/hooks/useWindowTitle';
1617

1718
function HelmReleasesList() {
1819
const { t } = useTranslation();
20+
useWindowTitle(t('helm-releases.title'));
21+
1922
const namespace = useAtomValue(activeNamespaceIdAtom);
2023
const { namespaceUrl } = useUrl();
2124
const resourceUrl = (entry) => {
2225
return namespaceUrl(`helm-releases/${entry.releaseName}`, {
2326
namespace: entry.namespace,
2427
});
2528
};
26-
2729
const dataUrl =
2830
namespace === '-all-'
2931
? `/api/v1/secrets`

src/components/Modules/ModulesList.jsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,12 @@ import { useFeature } from 'hooks/useFeature';
1919
import { configFeaturesNames } from 'state/types';
2020
import { CommunityModulesDeleteBoxContext } from 'components/Modules/community/components/CommunityModulesDeleteBox';
2121
import { ProtectedResourceWarning } from 'shared/components/ProtectedResourcesButton';
22+
import { useWindowTitle } from 'shared/hooks/useWindowTitle';
2223

2324
export default function ModulesList({ namespaced }) {
2425
const { t } = useTranslation();
26+
useWindowTitle(t('kyma-modules.title'));
27+
2528
const layoutState = useAtomValue(columnLayoutAtom);
2629
const { isEnabled: isCommunityModulesEnabled } = useFeature(
2730
configFeaturesNames.COMMUNITY_MODULES,

src/resources/CustomResourceDefinitions/CustomResources.details.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ export default function CustomResource({ params }) {
108108
disableDelete={isModule}
109109
isEntireListProtected={isEntireListProtected}
110110
headerActions={headerActions}
111+
windowTitle={isModule ? t('kyma-modules.title') : null}
111112
/>
112113
);
113114
}

0 commit comments

Comments
 (0)