fix: Prevent infinite loop after connecting incorrect kubeconfig (kyma-project#4197)

* fix: Prevent infinite loop after connecting incorrect kubeconfig

* fix: infinite loading

* test: adjust hpa test

* fix: adjust test

Author: OliwiaGowor

src/components/App/resourceSchemas/useResourceSchemas.ts

@@ -43,17 +43,18 @@ export const useResourceSchemas = () => {
       notification.notifyError({
         content: t('clusters.messages.connection-failed'),
       });
+
       navigate('/clusters');
     }
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [
     activeClusterName,
     cluster?.contextName,
     authData,
-    openApi,
+    openApi.state,
     isClusterList,
     navigate,
     t,
-    notification,
   ]);
 
   useEffect(() => {

src/state/authDataAtom.ts

@@ -1,12 +1,13 @@
 import { parseOIDCparams } from 'components/Clusters/components/oidc-params';
 import { User, UserManager } from 'oidc-client-ts';
-import { useEffect, useState } from 'react';
+import { useEffect, useRef, useState } from 'react';
 import { useNavigate } from 'react-router';
 import { atom, useAtomValue, useSetAtom } from 'jotai';
 import { KubeconfigNonOIDCAuth, KubeconfigOIDCAuth } from 'types';
 import { clusterAtom } from './clusterAtom';
 import { getPreviousPath } from './useAfterInitHook';
 import { openapiLastFetchedAtom } from 'state/openapi/openapiLastFetchedAtom';
+import { isEqual } from 'lodash';
 
 export const hasNonOidcAuth = (
   user?: KubeconfigNonOIDCAuth | KubeconfigOIDCAuth,
@@ -138,27 +139,24 @@ export function useAuthHandler() {
   const navigate = useNavigate();
   const setLastFetched = useSetAtom(openapiLastFetchedAtom);
   const [isLoading, setIsLoading] = useState(true);
+  const prevClusterRef = useRef<typeof cluster>(null);
 
   useEffect(() => {
-    console.log(
-      'currentCluster reference changed, TODO make sure to deeply compare',
-    );
-
     if (!cluster) {
       setAuth(null);
       setIsLoading(false);
     } else {
-      // don't do the auth flow on cluster list (e.g. after refresh, while the OIDC cluster is still connected)
-      if (window.location.pathname === '/clusters') {
-        setIsLoading(false);
-        return;
-      }
+      if (isEqual(prevClusterRef.current, cluster)) return; // Skip if unchanged
+
       const userCredentials = cluster.currentContext?.user?.user;
+
       if (hasNonOidcAuth(userCredentials)) {
         setAuth(userCredentials as KubeconfigNonOIDCAuth);
         setIsLoading(false);
       } else {
         const onAfterLogin = () => {
+          setIsLoading(false);
+
           if (!getPreviousPath() || getPreviousPath() === '/clusters') {
             if (cluster.currentContext.namespace) {
               navigate(
@@ -170,8 +168,8 @@ export function useAuthHandler() {
               navigate('/cluster/' + encodeURIComponent(cluster.name));
             }
           }
-          setIsLoading(false);
         };
+
         const onError = () => {
           navigate('/clusters');
           setIsLoading(false);

tests/integration/tests/kyma-namespace/test-hpa.spec.js

@@ -90,7 +90,7 @@ context('Test HPA', () => {
 
   it('Check HPA subcomponent', () => {
     cy.clickGenericListLink(HPA_NAME);
-    cy.wait(500);
+    cy.wait(1000);
     cy.contains('ui5-link', DEPLOYEMENT_NAME).click();
     cy.wait(500);
     cy.url().should('match', /deployments/);
@@ -101,7 +101,7 @@ context('Test HPA', () => {
 
     cy.wait(500).inspectTab('Edit');
 
-    cy.wait(2000);
+    cy.wait(3000);
 
     cy.getMidColumn()
       .get('[data-testid="spec.minReplicas"]:visible')