fix: Change "Preferences" to "Settings" (kyma-project#4485)

* fix: Change "Preferences" to "Settings"

* test: Adjust command palette test

* fix: being back ThemePreviewImage

* adjust test

Author: OliwiaGowor

docs/features.md

@@ -184,7 +184,7 @@ KYMA_COMPANION:
 
 The **match** keys and **messageSrc** must use the format described in the [`jsonpath` repository](https://github.com/dchester/jsonpath).
 
-- **RESOURCE_VALIDATION** - determines the selected policies for [resource validation](resource-validation/README.md). They can be overwritten in the user preferences.
+- **RESOURCE_VALIDATION** - determines the selected policies for [resource validation](resource-validation/README.md). They can be overwritten in the user settings.
 
   Default settings:
 

docs/operator/feature-flags.md

@@ -35,7 +35,7 @@ This table lists the frontend configurable feature flags, their descriptions, an
 | **KUBECONFIG_ID**                   | Configures the URL to which Busola sends a request to download a kubeconfig file. If you add `?kubeconfigID={your ID}` to the Busola URL, Busola tries to download the kubeconfig from `{kubeconfigUrl}/{yourID}`. If the operation succeeds, Busola adds the kubeconfing file to the cluster. If you use a full address in the **kubeconfigUrl** field, Busola also reads it. With optional **showClustersOverview** you can instruct Busola to show **Clusters Overview** rather than the current context cluster, after the clusters are loaded. **defaultKubeconfig** defined the optional default **KUBECONFIG_ID** to load this kubeconfig when you visit Busola homepage `/` and there are no memorized clusters in the application. | <ul><li>`isEnabled: true`</li><li>`config.kubeconfigUrl: https://kyma-env-broker.cp.dev.kyma.cloud.sap/kubeconfig`</li><li>`config.showClustersOverview: false`</li><li>`config.defaultKubeconfig: AAAAA-BBBBB`</li></ul>                                                                                                                                                                                                                                                                                                                                                                                                                                                       |
 | **LEGAL_LINKS**                     |                                                                                                                                                                                                                                                                                             Shows or hides legal links. In **config**, you can find the unchangeable keys (you cannot use **legalDisclosure** instead of **legal-disclosure**). The keys include both the default link, which takes you to the default address, and a link that depends on your chosen language. The link under the given key is selected based on your language code (`de`, `en`, `pl`, and more). If the code is not available, the default link is used. | <ul><li>`config.legal-disclosure.default: https://www.sap.com/corporate/en/legal/impressum.html`</li><li>`config.legal-disclosure.de: https://www.sap.com/corporate/de/legal/impressum.html`</li><li>`config.privacy.default: https://help.sap.com/viewer/82bdf2271c6041f79387c122147cf774/Cloud/en-US`</li><li>`config.copyright.default: https://www.sap.com/corporate/en/legal/copyright.html`</li><li>`config.copyright.de: https://www.sap.com/corporate/de/legal/copyright.html`</li><li>`config.trademark.default: https://www.sap.com/corporate/en/legal/trademark.html`</li><li>`config.trademark.de: https://www.sap.com/corporate/de/legal/trademark.html`</li></ul> |
 | **PROTECTED_RESOURCES**             |                Blocks the edit and delete functions based on the determined rules. If the resource meets the rule requirements, the resource becomes protected and cannot be edited/deleted. Each resource requires the **match** field, which includes a list of key-value pairs. The proper rule description is when the definition given in the key matches the value. To switch comparison mode from **standard** to **regex**, set the **regex** parameter to `true`. Optionally, you can provide the **message** parameter, which displays a simple message, or **messageSrc**, which is a YAML path where the message to be displayed is included. If neither **message** nor **messageSrc** is provided, a generic message is used. | <ul><li>`isEnabled: true`</li><li>`config.resources.match: { $.metadata.labels.foo: bar}` </li><li>`config.resources.message: This resource is protected`</li><li>`config.resources.match: { $.metadata.labels.foo: bar, $.metadata.labels.baz: qux }`</li><li>`config.resources.messageSrc: $.metadata.annotations.protected-message`</li><li>`config.resources.match: { $.metadata.labels.foo: ^[a-zA-Z0-9]$ }`</li><li>`config.resources.regex: true`</li></ul>                                                                                                                                                                                                              |
-| **RESOURCE_VALIDATION**             |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           Determines the selected policies for [resource validation](https://github.com/kyma-project/busola/blob/main/docs/resource-validation/README.md). They can be overwritten in the user preferences. | <ul><li>`isEnabled: true`</li><li>`config.policies: Default`</li></ul>                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          |
+| **RESOURCE_VALIDATION**             |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                              Determines the selected policies for [resource validation](https://github.com/kyma-project/busola/blob/main/docs/resource-validation/README.md). They can be overwritten in the user settings. | <ul><li>`isEnabled: true`</li><li>`config.policies: Default`</li></ul>                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          |
 | **SENTRY**                          |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            Enables monitoring of uncaught exceptions, which are then analyzed and repaired. The address to which you send the information is located under the **dsn** key. | <ul><li>`isEnabled: false`</li><li>`config.dsn: ''`</li></ul>                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                   |
 | **SNOW**                            |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      Determines if the snow animation is enabled in Busola. | `isEnabled: false`                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                              |
 

docs/resource-validation/README.md

@@ -6,11 +6,11 @@ With Busola's resource validation feature, you can validate resources, for examp
 
 ## Select policies
 
-You can choose which policies should be validated in the user preferences or set a [feature flag](../features.md).
+You can choose which policies should be validated in the user settings or set a [feature flag](../features.md).
 
-In the user preferences, go to **Clusters > Resource Validation**. Click on **Customize** in the **Enabled Policies** section.
+In the user settings, go to **Clusters > Resource Validation**. Click on **Customize** in the **Enabled Policies** section.
 
-<img src="./assets/customize-policy-preferences.png" alt="Preferences menu when choosing which policies to enable" width="40%" style="border: 1px solid #D2D5D9">
+<img src="./assets/customize-policy-preferences.png" alt="Settings menu when choosing which policies to enable" width="40%" style="border: 1px solid #D2D5D9">
 
 In the [feature flag](../features.md) config, set the following specifications:
 

docs/user/01-20-command-palette.md

@@ -1,7 +1,7 @@
 # Kyma Dashboard Command Palette
 
 With the Kyma dashboard command palette feature, you can easily navigate through all your dashboard resources, such as workloads, deployments, and more.
-You can perform actions such as listing or accessing your namespaces, or preferences, or uploading YAML files.
+You can perform actions such as listing or accessing your namespaces, or settings, or uploading YAML files.
 
 ## Features
 

public/i18n/en.yaml

@@ -179,7 +179,7 @@ command-palette:
     crd-aliases: CRD Aliases
     full: Use <0>↑</0> and <0>↓</0> to navigate between results, <0>⏎</0> to choose, <0>Tab</0> to autocomplete.
     navigation: Navigation
-    open-preferences: Open preferences
+    open-settings: Open settings
     open-upload-yaml: Open upload YAML
     resource-aliases: Built-in resource aliases
     short-help: Type <0>?</0> for help
@@ -286,7 +286,7 @@ common:
     delete-title: Delete {{type}}
     disconnect-message: Are you sure you want to disconnect {{type}} {{name}}?
     disconnect-title: Disconnect {{type}}
-    information: You've switched off removal confirmations for all resources. You can switch them back on in Preferences.
+    information: You've switched off removal confirmations for all resources. You can switch them back on in Settings.
   errors:
     couldnt-fetch-resources: Couldn't fetch resources.
     delete: Deletion of resource failed
@@ -373,7 +373,7 @@ common:
     secret-ref-namespace: Select namespace
   product-title: Kyma
   protected-resource: Protected resource
-  protected-resource-description: Resource protected. Go to Preferences to turn on the modification of protected resources.
+  protected-resource-description: Resource protected. Go to Settings to turn on the modification of protected resources.
   sorting:
     asc: Ascending
     count: Count
@@ -411,7 +411,7 @@ common:
     k8s-name-input: Name must consist of lowercase alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc').
     key-value: Key and value must start and end with an alphanumeric character, can contain '-', '_' or '.'.
     line: Ln
-    protected-resources-info: To allow for modifying protected resources go to Preferences > Clusters.
+    protected-resources-info: To allow for modifying protected resources go to Settings > Clusters.
     read-file: Read file content as a single value, with file name as a key.
     resource-ref-name: Unique name within a Namespace to refer to a {{resource}} resource.
     resource-ref-namespace: Namespace defines the space within which the {{resource}} name must be unique.
@@ -1028,9 +1028,9 @@ navigation:
   menu:
     get-help: Get Help
     legal-information: Legal Information
-  preferences:
-    title: Preferences
   select-namespace: Select Namespace...
+  settings:
+    title: Settings
   snow: Let it snow
   snow-stop: Stop the snow
   upload-yaml:
@@ -1462,7 +1462,7 @@ settings:
     all: All
     default-last-used: Default (last one used)
     default-page-size: Default Page Size
-    info: Changes to the page size only take effect locally. To set the global default page size, go to Preferences.
+    info: Changes to the page size only take effect locally. To set the global default page size, go to Settings.
     of: of {{pagesCount}}
     page: Page
     pagination: Pagination

src/command-pallette/CommandPalletteUI/handlers/nonResourceHandler.ts

@@ -17,8 +17,8 @@ export function createNonResourceOptions({
       type: 'upload',
     },
     {
-      names: ['preferences', 'prefs'],
-      type: 'preferences',
+      names: ['settings', 'set'],
+      type: 'settings',
     },
     {
       names: ['help', '?'],
@@ -90,16 +90,16 @@ function createResults(context: CommandPaletteContext): Result[] | null {
             aliases: ['up'],
           },
         ];
-      case 'preferences':
+      case 'settings':
         return [
           {
-            label: t('navigation.preferences.title'),
-            query: 'preferences',
+            label: t('navigation.settings.title'),
+            query: 'settings',
             onActivate: () => {
-              context.setOpenPreferencesModal(true);
+              context.setOpenSettingsModal(true);
             },
-            customActionText: t('command-palette.help.open-preferences'),
-            aliases: ['prefs'],
+            customActionText: t('command-palette.help.open-settings'),
+            aliases: ['set'],
           },
         ];
       case 'overview':
@@ -149,9 +149,9 @@ export const nonResourceHandler: Handler = {
       description: t('command-palette.help.cluster-overview'),
     },
     {
-      name: 'preferences',
-      alias: 'prefs',
-      description: t('command-palette.help.open-preferences'),
+      name: 'settings',
+      alias: 'set',
+      description: t('command-palette.help.open-settings'),
     },
     {
       name: 'ns -a',

src/command-pallette/CommandPalletteUI/helpers.ts

@@ -7,8 +7,8 @@ export const activateResult = (query: string, activateCallback: () => void) => {
 
 export const isResultGoingToRedirect = (resultQuery: string) => {
   switch (resultQuery) {
-    case 'preferences':
-    case 'prefs':
+    case 'settings':
+    case 'set':
     case 'upload':
     case 'up':
       return false;

src/command-pallette/CommandPalletteUI/types.ts

@@ -20,7 +20,7 @@ export type CommandPaletteContext = {
   resourceCache: Record<string, K8sResource[]>;
   updateResourceCache: (key: string, resources: K8sResource[]) => void;
   t: TFunction<'translation', undefined>;
-  setOpenPreferencesModal: (open: boolean) => void;
+  setOpenSettingsModal: (open: boolean) => void;
   setShowYamlUpload: (show: boolean) => void;
   clustersInfo: useClustersInfoType;
   navigate: (_: string) => void;

src/command-pallette/CommandPalletteUI/useSearchResults.tsx

@@ -1,9 +1,9 @@
 import { useEffect } from 'react';
 import { useTranslation } from 'react-i18next';
 import { useAtomValue, useSetAtom } from 'jotai';
-import { isPreferencesOpenAtom } from 'state/preferences/isPreferencesModalOpenAtom';
+import { isSettingsOpenAtom } from 'state/settings/isSettingsModalOpenAtom';
 import { useFetch } from 'shared/hooks/BackendAPI/useFetch';
-import { showHiddenNamespacesAtom } from 'state/preferences/showHiddenNamespacesAtom';
+import { showHiddenNamespacesAtom } from 'state/settings/showHiddenNamespacesAtom';
 import { columnLayoutAtom } from 'state/columnLayoutAtom';
 
 import * as handlers from './handlers';
@@ -48,7 +48,7 @@ export function useSearchResults({
   const showHiddenNamespaces = useAtomValue(showHiddenNamespacesAtom);
   const fetch = useFetch();
   const { t } = useTranslation();
-  const setOpenPreferencesModal = useSetAtom(isPreferencesOpenAtom);
+  const setOpenSettingsModal = useSetAtom(isSettingsOpenAtom);
   const setShowYamlUpload = useSetAtom(showYamlUploadDialogAtom);
   const clustersInfo = useClustersInfo();
   const navigate = useNavigate();
@@ -78,7 +78,7 @@ export function useSearchResults({
     resourceCache,
     updateResourceCache,
     t,
-    setOpenPreferencesModal,
+    setOpenSettingsModal: setOpenSettingsModal,
     setShowYamlUpload,
     clustersInfo,
     navigate: navigateAndCloseColumns,

src/components/App/App.tsx

@@ -14,7 +14,7 @@ import { useUrl } from 'hooks/useUrl';
 import { useSentry } from 'hooks/useSentry';
 
 import { clusterAtom } from 'state/clusterAtom';
-import { languageAtom } from 'state/preferences/languageAtom';
+import { languageAtom } from 'state/settings/languageAtom';
 import { activeNamespaceIdAtom } from 'state/activeNamespaceIdAtom';
 import { useAuthHandler } from 'state/authDataAtom';
 import { useGetConfiguration } from 'state/configuration/configurationAtom';
@@ -38,7 +38,7 @@ import {
 } from '@ui5/webcomponents-react';
 import { showKymaCompanionAtom } from 'state/companion/showKymaCompanionAtom';
 import KymaCompanion from 'components/KymaCompanion/components/KymaCompanion';
-import { Preferences } from 'components/Preferences/Preferences';
+import { Settings } from 'components/Settings/Settings';
 import { Header } from 'header/Header';
 import { ContentWrapper } from './ContentWrapper/ContentWrapper';
 import { Sidebar } from 'sidebar/Sidebar';
@@ -48,7 +48,7 @@ import { IncorrectPath } from './IncorrectPath';
 import { Spinner } from 'shared/components/Spinner/Spinner';
 import { ContextChooserMessage } from 'components/Clusters/components/ContextChooser/ContextChooser';
 
-import { themeAtom } from 'state/preferences/themeAtom';
+import { themeAtom } from 'state/settings/themeAtom';
 import { initTheme } from './initTheme';
 
 import './App.scss';
@@ -215,7 +215,7 @@ export default function App() {
                 </Route>
                 {makeGardenerLoginRoute}
               </Routes>
-              <Preferences />
+              <Settings />
             </ContentWrapper>
           </div>
         </div>