fix: Deleting community module issue (kyma-project#4211)

* Correct error handling and wait longer for delete

* Improve error handling

* Update public/i18n/en.yaml

Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>

---------

Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>

Author: KonradPietocha

public/i18n/en.yaml

@@ -934,6 +934,7 @@ modules:
       module-uninstall: Community Module deleted
       modules-updated: Community Modules updated
       resources-delete-failure: 'Failed to delete the {{module}} because the following resources cannot be deleted: {{resources}}'
+      resources-delete-in-progress: Resources are still being deleted. Try again later.
       source-yaml-added: Source YAML added
       source-yaml-failed: Failed to add Source YAML
       source-yaml-fetch-failed: 'Failed to download source yaml: {{error}}'

src/components/Modules/components/ModulesDeleteBox.tsx

@@ -218,6 +218,7 @@ export const ModulesDeleteBox = ({
         const allStillExistingResources = await checkIfAllResourcesAreDeleted(
           fetchFn,
           associatedResourcesUrls,
+          t,
         );
         if (allStillExistingResources.length !== 0) {
           notification.notifyError({

src/components/Modules/deleteModulesHelpers.tsx

@@ -10,6 +10,7 @@ import { getUrl } from 'resources/Namespaces/YamlUpload/useUploadResources';
 import { postForCommunityResources } from 'components/Modules/community/communityModulesHelpers';
 import { HttpError } from 'shared/hooks/BackendAPI/config';
 import retry from 'shared/utils/retry';
+import { TFunction } from 'i18next';
 
 interface Counts {
   [key: string]: number;
@@ -281,14 +282,20 @@ export const deleteResources = async (
 export const checkIfAllResourcesAreDeleted = async (
   fetchFn: Function,
   resourcesUrls: string[],
+  t: TFunction,
 ) => {
+  let urlDuringError = '';
+  let isDeletionInProgress = false;
   const results = await Promise.all(
     resourcesUrls.map(async (url) => {
       const result = await retry(
         async () => {
           try {
             const result = await fetchFn(url);
             const resources = await result.json();
+            urlDuringError = url;
+            isDeletionInProgress =
+              !!resources?.items?.[0]?.metadata?.deletionTimestamp;
             return resources?.items.length === 0;
           } catch (e) {
             if (e instanceof HttpError && e.code === 404) {
@@ -297,13 +304,20 @@ export const checkIfAllResourcesAreDeleted = async (
             throw e;
           }
         },
-        3,
-        1000,
+        5,
+        3000,
       );
       return { resource: url, result };
     }),
-  );
-  console.log(results);
+  ).catch((e) => {
+    console.warn(e);
+    if (isDeletionInProgress) {
+      throw new Error(
+        t('modules.community.messages.resources-delete-in-progress'),
+      );
+    }
+    return [{ resource: urlDuringError, result: false }];
+  });
   return results.filter((v) => !v.result).map((r) => r.resource);
 };