use NonEmptySet from Arrow-kt #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoc081098
added
enhancement
There was a problem hiding this comment.
Copilot reviewed 7 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (4)
- .idea/AndroidProjectSystem.xml: Language not supported
- .idea/kotlinc.xml: Language not supported
- .idea/runConfigurations.xml: Language not supported
- .idea/vcs.xml: Language not supported
Comments suppressed due to low confidence (2)
core/src/test/java/com/hoc/flowmvi/core/NonEmptySetTest.kt:1
- The custom NonEmptySet tests have been removed; please ensure that the critical behaviors of Arrow's NonEmptySet used in our codebase are covered by other tests.
package com.hoc.flowmvi.core
domain/src/main/java/com/hoc/flowmvi/domain/model/UserError.kt:6
- Converting NetworkError from an object to a data object may change identity semantics; please verify that this change is intentional and that equality checks in the codebase function as expected.
data object NetworkError : UserError() {
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #272 +/- ##
=======================================
Coverage 61.63% 61.63%
=======================================
Files 37 37
Lines 1100 1100
Branches 104 104
=======================================
Hits 678 678
Misses 408 408
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
😄
Vào 19:05, CN, 6 thg 4, 2025 Petrus Nguyễn Thái Học <
***@***.***> đã viết:
… Merged #272
<#272>
into master.
—
Reply to this email directly, view it on GitHub
<#272 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKMBQIPWBCSRSS3J3CFHUML2YEKCFAVCNFSM6AAAAAB2RUAXV6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJXGE2DGMBSHA3TMMQ>
.
You are receiving this because you are subscribed to this thread.Message
ID:
<Kotlin-Android-Open-Source/MVI-Coroutines-Flow/pull/272/issue_event/17143028762
@github.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes related to the migration from a custom
NonEmptySetimplementation to thearrowlibrary'sNonEmptySetand other project configuration updates. The most important changes are summarized below:Migration to
arrowlibrary'sNonEmptySet:core/src/main/java/com/hoc/flowmvi/core/EitherNes.kt: Updated import statements to usearrow.core.NonEmptySetand replaced the customNonEmptySet.ofmethod witharrow.core.nonEmptySetOf. [1] [2]domain/src/main/java/com/hoc/flowmvi/domain/model/UserError.kt: Replaced customNonEmptySetwitharrow.core.NonEmptySetand updatedServerErrorandUnexpectedto usedata object. [1] [2]domain/src/main/java/com/hoc/flowmvi/domain/model/UserValidationError.kt: Updated import statements to usearrow.core.NonEmptySetandtoNonEmptySetOrNull, and removed redundant comments. [1] [2]data/src/test/java/com/hoc/flowmvi/data/mapper/UserErrorMapperTest.kt: Replaced customNonEmptySetwitharrow.core.nonEmptySetOfin test cases. [1] [2]Removal of custom
NonEmptySetimplementation:core/src/main/java/com/hoc/flowmvi/core/NonEmptySet.kt: Deleted the custom implementation ofNonEmptySetclass.core/src/test/java/com/hoc/flowmvi/core/NonEmptySetTest.kt: Deleted the test cases for the customNonEmptySetclass.Project configuration updates:
.idea/AndroidProjectSystem.xml: Added new project system configuration for Android..idea/kotlinc.xml: Updated Kotlin version from2.0.20to2.1.20..idea/runConfigurations.xml: Added new JUnit configuration producers for better test discovery and execution..idea/vcs.xml: Removed duplicateCommitFormatinspection tool entry.