Skip to content

Commit d93bb01

Browse files
committed
Move source-set names capitalization from css styles to Gradle plugin
1 parent f98203a commit d93bb01

5 files changed

Lines changed: 35 additions & 28 deletions

File tree

dokka-runners/dokka-gradle-plugin/src/main/kotlin/engine/parameters/DokkaSourceSetSpec.kt

Lines changed: 28 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -445,6 +445,28 @@ constructor(
445445
//endregion
446446

447447
companion object {
448+
// only lower case keys based on source-set names
449+
@Suppress("SpellCheckingInspection")
450+
private val sourceSetNameReplacements = mapOf(
451+
"jvm" to "JVM",
452+
"js" to "JS",
453+
"android" to "Android JVM",
454+
"androidJvm" to "Android JVM",
455+
456+
"ios" to "iOS",
457+
"watchos" to "watchOS",
458+
"macos" to "macOS",
459+
"tvos" to "tvOS",
460+
461+
"androidNative" to "Android Native",
462+
463+
"wasmjs" to "Wasm/JS",
464+
"wasmwasi" to "Wasm/WASI",
465+
)
466+
467+
private fun formatDefaultSourceSetName(name: String): String {
468+
return sourceSetNameReplacements[name.toLowerCase()] ?: name.capitalize()
469+
}
448470

449471
/**
450472
* A factory for creating [DokkaSourceSetSpec].
@@ -462,11 +484,12 @@ constructor(
462484
analysisPlatform.convention(KotlinPlatform.DEFAULT)
463485
displayName.convention(
464486
analysisPlatform.map { platform ->
465-
if (name.equals("main", ignoreCase = true)) {
466-
platform.displayName
467-
} else {
468-
name.removeSuffix("Main")
469-
}
487+
formatDefaultSourceSetName(
488+
when {
489+
name.equals("main", ignoreCase = true) -> platform.displayName
490+
else -> name.removeSuffix("Main")
491+
}
492+
)
470493
}
471494
)
472495
}

dokka-subprojects/plugin-base-frontend/src/main/ui-kit/platform-tag/styles.scss

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@
3838

3939
cursor: pointer;
4040

41-
text-transform: capitalize;
42-
4341
border: 0 none;
4442

4543
border-radius: var(--size-s1);
@@ -72,15 +70,6 @@ button.platform-tag {
7270
padding-left: 44px;
7371
}
7472

75-
.platform-tag.js-like,
76-
.platform-selector-option.js-like,
77-
.platform-tag.jvm-like,
78-
.platform-selector-option.jvm-like,
79-
.platform-tag.wasm-like,
80-
.platform-selector-option.wasm-like {
81-
text-transform: uppercase;
82-
}
83-
8473
.filter-section .platform-tag[data-active] {
8574
color: #19191c;
8675
background-color: var(--platform-tag-color);

dokka-subprojects/plugin-base/src/main/kotlin/org/jetbrains/dokka/base/renderers/html/HtmlRenderer.kt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -623,12 +623,12 @@ public open class HtmlRenderer(
623623
div("platform-tags $cssClasses") {
624624
sourceSets.sortedBy { it.name }.forEach {
625625
div("platform-tag") {
626-
when (it.platform.key) {
627-
"common" -> classes = classes + "common-like"
628-
"native" -> classes = classes + "native-like"
629-
"jvm" -> classes = classes + "jvm-like"
630-
"js" -> classes = classes + "js-like"
631-
"wasm" -> classes = classes + "wasm-like"
626+
classes += when (it.platform) {
627+
Platform.common -> "common-like"
628+
Platform.native -> "native-like"
629+
Platform.jvm -> "jvm-like"
630+
Platform.js -> "js-like"
631+
Platform.wasm -> "wasm-like"
632632
}
633633
text(it.name)
634634
}

dokka-subprojects/plugin-base/src/main/resources/dokka/ui-kit/ui-kit.css

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2475,7 +2475,6 @@ a {
24752475
font: var(--font-text-s);
24762476
padding: 10px 12px;
24772477
position: relative;
2478-
text-transform: capitalize;
24792478
}
24802479

24812480
.platform-tags .platform-tag {
@@ -2504,10 +2503,6 @@ button.platform-tag:focus-visible {
25042503
padding-left: 44px;
25052504
}
25062505

2507-
.platform-selector-option.js-like, .platform-selector-option.jvm-like, .platform-selector-option.wasm-like, .platform-tag.js-like, .platform-tag.jvm-like, .platform-tag.wasm-like {
2508-
text-transform: uppercase;
2509-
}
2510-
25112506
.filter-section .platform-tag[data-active] {
25122507
background-color: var(--platform-tag-color);
25132508
color: #19191c;

dokka-subprojects/plugin-base/src/main/resources/dokka/ui-kit/ui-kit.min.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)