Merge branch 'UpdateReleaseVersion' into 'master'

Update release version

See merge request kount/third_party/ris-clients!6

Author: Sanjeev Kumar

kount_complete.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name        = 'kount_complete'
-  s.version     = '2.0.3'
+  s.version     = '2.0.4'
   s.summary     = "Kount Complete Services Wrapper"
   s.description = "A wrapper to facilitate making Kount RIS calls"
   s.email       = 'ruby@kount.com'

lib/kount.rb

@@ -20,7 +20,6 @@ module Kount
   #    }
   # @param options Hash
   def new(options = {})
-    raise ArgumentError, 'Config options required' if options.empty?
     Client.new(options)
   end
 

lib/kount/Response.rb

@@ -284,8 +284,8 @@ def get_browser
     end
 
     def get_numberrules_triggered
-      no_rules_triggered = @paramlist['RULES_TRIGGERED'].to_s
-      no_rules_triggered
+      # changed due to rubocop styling rules for ruby
+      @paramlist['RULES_TRIGGERED'].to_s
     end
 
     def get_rules_triggered
@@ -299,8 +299,8 @@ def get_rules_triggered
     end
 
     def get_warning_count
-      warning_count = @paramlist['WARNING_COUNT'].to_s
-      warning_count
+      # changed due to rubocop styling rules for ruby
+      @paramlist['WARNING_COUNT'].to_s
     end
 
     def get_warnings
@@ -313,8 +313,8 @@ def get_warnings
     end
 
     def get_error_count
-      errorcount = @paramlist['ERROR_COUNT'].to_s
-      errorcount
+      # changed due to rubocop styling rules for ruby
+      @paramlist['ERROR_COUNT'].to_s
     end
 
     def geterrors
@@ -327,8 +327,8 @@ def geterrors
     end
 
     def get_numbercounters_triggered
-      count_triggered = @paramlist['COUNTERS_TRIGGERED'].to_s
-      count_triggered
+      # changed due to rubocop styling rules for ruby
+      @paramlist['COUNTERS_TRIGGERED'].to_s
     end
 
     def get_counters_triggered

lib/kount/request.rb

@@ -12,8 +12,6 @@ class Request
     #
     # @param initial_params [Hash] Initial params for request
     def initialize(initial_params = {})
-      raise "Cannot directly instantiate a #{self.class}." if
-        self.class == Request
       @params = initial_params
     end
 

lib/kount/request/inquiry.rb

@@ -24,13 +24,11 @@ def initialize(initial_params = {})
     # @param ksalt [String] Kount supplied secret salt for KHASH
     def prepare_params(version, merchant_id, response_format, ksalt)
       super(version, merchant_id, response_format, ksalt)
-      begin
-        params.merge! collect_cart_items
-        # The Kount::Request has no knowledge of the KSALT or merchant_id, both
-        # of which are needed for KHASH. Request form params have everything we
-        # need at this point to do the KHASH if needed.
-        fixup_payment_params(ksalt, merchant_id)
-      end
+      params.merge! collect_cart_items
+      # The Kount::Request has no knowledge of the KSALT or merchant_id, both
+      # of which are needed for KHASH. Request form params have everything we
+      # need at this point to do the KHASH if needed.
+      fixup_payment_params(ksalt, merchant_id)
       params
     end
 

lib/kount/utils/khash.rb

@@ -4,9 +4,12 @@ class Khash
     # @param ptyp [String] Payment type code: CARD, GIFT, or OTHER
     # @return [String] KHASH version of string
     def self.hash_token(plain_text, ptyp, ksalt, merchant_id = '')
-      if ptyp == 'CARD'
+      # changed if-else to case-when to follow ruby coding standard
+
+      case ptyp
+      when 'CARD'
         HashPaymentToken(plain_text, ksalt)
-      elsif ptyp == 'CHEK'
+      when 'CHEK'
         HashCheckPayment(plain_text, ksalt)
       else
         HashGiftCard(plain_text, ksalt, merchant_id)

spec/khash_spec.rb

@@ -22,7 +22,7 @@
 
     describe "Test the HashCheckPayment Method" do
       it 'Test the HashCheckPayment Method for CHECK type' do
-        expect(Kount::Khash.hash_check_payment('01234567811111111111111', '')).to eq('012345440GD428TF29K0')
+        expect(Kount::Khash.hash_check_payment('0123456781111111', '')).to eq('012345IIY6S6GU6UZ9K5')
       end
     end
   end