Merge pull request #11 from Kount/develo-k360-sfra

Kount feedback fixes from emails

Author: aakashchugani

cartridges/int_kount_360_sfra/caches.json

@@ -2,7 +2,7 @@
   "caches": [
     {
       "id": "Kount360",
-      "expireAfterSeconds": 1140
+      "expireAfterSeconds": 900
     }
   ]
 }

cartridges/int_kount_360_sfra/cartridge/scripts/helpers/kount360Helpers.js

@@ -28,7 +28,7 @@ function getCachedToken() {
     if (
       currentToken &&
       currentToken.token &&
-      currentToken.expiresAt - 60 > today.getTime()
+      (currentToken.expiresAt - 60000) > today.getTime()
     ) {
         return currentToken.token;
     }

cartridges/int_kount_360_sfra/cartridge/scripts/helpers/kount360OrderModel.js

@@ -159,8 +159,8 @@ function getKountTransactions(order) {
                 transactions.push({
                     merchantTransactionId: transaction.transactionID || '',
                     processor: transaction.paymentProcessor ? transaction.paymentProcessor.ID : '',
-                    subtotal: order.adjustedMerchandizeTotalNetPrice && order.adjustedMerchandizeTotalNetPrice.available ? order.adjustedMerchandizeTotalNetPrice.multiply(100).value : null,
-                    orderTotal: order.adjustedMerchandizeTotalPrice && order.adjustedMerchandizeTotalPrice.available ? order.adjustedMerchandizeTotalPrice.multiply(100).value : null,
+                    subtotal: order.adjustedMerchandizeTotalPrice && order.adjustedMerchandizeTotalPrice.available ? order.adjustedMerchandizeTotalPrice.multiply(100).value : null,
+                    orderTotal: order.totalGrossPrice && order.totalGrossPrice.available ? order.totalGrossPrice.multiply(100).value : null,
                     currency: order.currencyCode || '',
                     tax: {
                         isTaxable: order.totalTax && order.totalTax.available ? order.totalTax.value > 0 : false,

cartridges/int_kount_360_sfra/cartridge/scripts/kount/libKount.js

@@ -10,6 +10,22 @@ var kount360Mappings = require('*/cartridge/kount360mappings/index');
 var basePostRISRequest = base.postRISRequest;
 var basePostRiskCall = base.postRiskCall;
 
+/**
+ * @description Maps UDF fields to Kount 360 format
+ * @param {dw.order.Order} order Order
+ * @returns {Object} Object with UDF fields mapped to Kount 360 format
+ */
+function mapKount360UDFFields(order) {
+    var baseUDFFields = base.getUDFFields(order);
+    var kount360UDFFields = {customFields: {}};
+
+    for (var i = 0; i < baseUDFFields.length; i++) {
+        kount360UDFFields.customFields[baseUDFFields[i].label] = baseUDFFields[i].value;
+    }
+
+    return kount360UDFFields;
+}
+
 /**
  * @description Makes POST request. Sends orders details for evaluating
  * @param {Object} RequiredInquiryKeysVal Payload to send to Kount risk service
@@ -40,8 +56,10 @@ function postRISRequest(RequiredInquiryKeysVal) {
         var inquirySource = mappingUtils.applyCustomMapping(RequiredInquiryKeysVal, kount360Mappings.kount360ReqValueMapping);
         var requestBody = mappingUtils.transform(kount360Mappings.kount360ReqMapping, inquirySource);
         var extendedOrderModel = orderModel.error || RequiredInquiryKeysVal.MODE === 'U' ? requestBody : kountUtils.extend(requestBody, orderModel);
+        var kount360UDFFields = mapKount360UDFFields(order);
+        var finalRequestBody = kountUtils.extend(extendedOrderModel, kount360UDFFields);
         var response = kount360APIService.call({
-            requestBody: extendedOrderModel,
+            requestBody: finalRequestBody,
             params: {
                 riskInquiry: RequiredInquiryKeysVal.MODE !== 'U' ? 'true' : 'false'
             },