Merge pull request #7 from Kount/develo-k360-sfra

fix feedback

Author: aakashchugani

cartridges/int_kount_360_sfra/cartridge/kount360mappings/kount360ReqMapping.json

@@ -12,15 +12,15 @@
     "items.[*].category": "PROD_TYPE",
     "items.[*].sku": "PROD_ITEM",
     "fulfillment.[*].shipping.method": "SHTP",
-    "fulfillment.[*].recipient.person.name.first": "S2NM",
-    "fulfillment.[*].recipient.person.email": "S2EM",
-    "fulfillment.[*].recipient.person.phoneNumber": "S2PN",
-    "fulfillment.[*].recipient.person.address.line1": "S2A1",
-    "fulfillment.[*].recipient.person.address.line2": "S2A2",
-    "fulfillment.[*].recipient.person.address.city": "S2CI",
-    "fulfillment.[*].recipient.person.address.region": "S2ST",
-    "fulfillment.[*].recipient.person.address.countryCode": "S2CC",
-    "fulfillment.[*].recipient.person.address.postalCode": "S2PC",
+    "fulfillment.[*].recipientPerson.name.first": "S2NM",
+    "fulfillment.[*].recipientPerson.emailAddress": "S2EM",
+    "fulfillment.[*].recipientPerson.phoneNumber": "S2PN",
+    "fulfillment.[*].recipientPerson.address.line1": "S2A1",
+    "fulfillment.[*].recipientPerson.address.line2": "S2A2",
+    "fulfillment.[*].recipientPerson.address.city": "S2CI",
+    "fulfillment.[*].recipientPerson.address.region": "S2ST",
+    "fulfillment.[*].recipientPerson.address.countryCode": "S2CC",
+    "fulfillment.[*].recipientPerson.address.postalCode": "S2PC",
     "transactions.[*].payment.type": "PTYP",
     "transactions.[*].payment.paymentToken": "PTOK",
     "transactions.[*].payment.bin": "LBIN",

cartridges/int_kount_360_sfra/cartridge/scripts/helpers/kount360OrderModel.js

@@ -121,14 +121,18 @@ function getFulfillment(order) {
                     },
                     emailAddress: order.customerEmail || '',
                     phoneNumber: shippingAddress.phone || ''
-                } : null
+                } : {}
             };
             var addressData = fulfillment.type === 'STORE_PICK_UP' ? {
                 id: shipment.custom.fromStoreId || '',
                 address: address
             } : address;
 
-            fulfillment[fulfillment.type === 'STORE_PICK_UP' ? 'store' : 'address'] = addressData;
+            if (fulfillment.type === 'STORE_PICK_UP') {
+                fulfillment.store = addressData;
+            } else {
+                fulfillment.recipientPerson.address = addressData;
+            }
             fulfillments.push(fulfillment);
         }
     } catch (e) {

cartridges/int_kount_360_sfra/cartridge/scripts/kount/kount360EventHub.js

@@ -16,10 +16,10 @@ var COHelpers = require('*/cartridge/scripts/checkout/checkoutHelpers');
  */
 function updateOrderStatus(orderStatus, order) {
     Transaction.wrap(function () {
-        if (orderStatus === 'APPROVED') {
+        if (orderStatus === 'APPROVE') {
             order.setExportStatus(Order.EXPORT_STATUS_READY);
             order.setConfirmationStatus(Order.CONFIRMATION_STATUS_CONFIRMED);
-        } else if (orderStatus === 'DECLINED') {
+        } else if (orderStatus === 'DECLINE') {
             order.setExportStatus(Order.EXPORT_STATUS_NOTEXPORTED);
             order.setConfirmationStatus(Order.CONFIRMATION_STATUS_NOTCONFIRMED);
         } else if (orderStatus === 'REVIEW') {