Skip to content

Upgrading Electron #39

@thegu5

Description

@thegu5

10.4.7: current
12.2.3: --enable-features=ImplLatencyRecovery,MainLatencyRecovery
modern: ???

This is the cause of several issues, with the most prominent being the freezing on mac when resizing the window, changing lobbies, reloading, etc.

We can't switch to modern electron due to https://issues.chromium.org/issues/415071737 (aka aim freeze - please upvote the issue 🥺). There are two different patches that attempt to fix the issue (mine in the chromium issue, and bigjakk's), but using a modern patched electron still feels unviable (having to maintain a patch, dealing with instability seen in glorp, etc).

Next steps:

  • can we get a patch that's good enough to upstream? (hard)
  • keep crankshaft-next up to date with master, get more people to test it, get a build for windows (someone builds it on my patch, or we switch to bigjakk's)

help wanted! if you have any ideas, information, fixes, etc - join the crankshaft discord

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions