ContactStructuralMechanicsApplication - Python coupling

[sunethwarna]

Hi all,

We have out that, one of the strategies in ContactStructuralMechanicsApplication includes pybind headers to get python::Process type as shown below:

Kratos/applications/ContactStructuralMechanicsApplication/custom_strategies/custom_strategies/residualbased_newton_raphson_contact_strategy.h

Lines 33 to 34 in 794c315

	#include "custom_python/process_factory_utility.h"
	#include "custom_utilities/contact_utilities.h"

Followings are some use cases of the pybind includes in the same file:

Kratos/applications/ContactStructuralMechanicsApplication/custom_strategies/custom_strategies/residualbased_newton_raphson_contact_strategy.h

Line 136 in 794c315

using ProcessesListType = typename ProcessFactoryUtility::Pointer;

Kratos/applications/ContactStructuralMechanicsApplication/custom_strategies/custom_strategies/residualbased_newton_raphson_contact_strategy.h

Lines 855 to 859 in 794c315

	if (mpMyProcesses != nullptr)
	mpMyProcesses->ExecuteInitializeSolutionStep();
	if (mpPostProcesses != nullptr)
	mpPostProcesses->ExecuteInitializeSolutionStep();

Would it be possible to change these from python::Process to Kratos::Process and decouple ContactStructuralMechanicsApplication to ContactStructuralMechanicsCore and ContactStructuralMechanicsApplication as in other applications?

@loumalouomega ?

[loumalouomega]

I don't remember why I did that, but could be...

[loumalouomega]

There is already KratosContactStructuralMechanicsCore and KratosContactStructuralMechanicsApplication

[sunethwarna]

I can remove it if it is not killing anyone's use cases. :D

[loumalouomega]

I can do it myself, because if I did it that way it was because some reason

[loumalouomega]

I don't see where is the problem, application is separtated in the standard manner

[sunethwarna]

We got a request that, they would like to use ContactStructuralMechanicsApplication without python layer (so they are linking against the cpp part only.) At the moment, they have replaced ProcessesListType with Kratos::Process which works for them. [They don't like to have pybind11 includes in their program which makes sense]. Is this possible? Am I missing something?

[loumalouomega]

This should not work a priori, as in fact the actual argument of the utility are raw python objects then reinterpreted. What I would do is to refactopr in order to remove that dependency. Or maybe just using preprocessor to not compile that part when no python compiled. i will try and tell you.

[loumalouomega]

Is this sitll an issue?