Skip to content

deps: bump ThirdParty/SDL2 from 859844e to 79de30a#527

Open
dependabot[bot] wants to merge 1 commit into
Workingfrom
dependabot/submodules/ThirdParty/SDL2-b53f1b0
Open

deps: bump ThirdParty/SDL2 from 859844e to 79de30a#527
dependabot[bot] wants to merge 1 commit into
Workingfrom
dependabot/submodules/ThirdParty/SDL2-b53f1b0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 8, 2026

Copy link
Copy Markdown
Contributor

Bumps ThirdParty/SDL2 from 859844e to 79de30a.

Commits
  • 79de30a wayland: Don't apply display orientation on Sailfish
  • 5f25ce9 x11: SetupWindowData shouldn't add to videodata->windowlist until success.
  • 430cacd _uitoa does not exist
  • 1df9ae4 directfb: Fix CreateRenderer callback signature
  • f0d1101 atomic: Implement loads on MSVC without RMW operations
  • 4b69833 Windows: Fix window caption drawing on borderless windows
  • 039a60c video: NULL-check display in SDL_DestroyWindow
  • d07d39b atomic: Fix infinite recursion in SDL_CompilerBarrier() fallback
  • 3ebdcc5 atomic: Fix and cleanup SDL_UnlockSpinlock()
  • dd1e04e atomic: Use __atomic_signal_fence() for SDL_CompilerBarrier()
  • Additional commits viewable in compare view

@dependabot @github

dependabot Bot commented on behalf of github Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Labels

The following labels could not be found: dependencies, submodules. Please create them before Dependabot can add them to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

❌ CI Error Report

Failed jobs: clang-tidy, macos-Debug-OpenGL, macos-Release-Metal, macos-Release-OpenGL, windows-vs2022-Release
Errors: 6 | Test failures: 3 | Test warnings: 15 | Compiler warnings: 7

Build Errors

File Line Error Jobs
/alc.h 49 typedef redefinition with different type (' truct ALCdevice_ truct' v ' truct ALCdevice') macos-Debug-OpenGL, macos-Release-OpenGL
/alc.h 50 typedef redefinition with different type (' truct ALCcontext_ truct' v ' truct ALCcontext') macos-Debug-OpenGL, macos-Release-OpenGL
r/include/objc/objc.h 85 type alia redefinition with different type ('bool' v 'int') macos-Release-Metal
Other errors (3)
/U er /runner/work/SparkEngine/SparkEngine/SparkEngine/Source/Graphic /RHI/Metal/MetalRayTracing.mm:59:17: error: u e of undeclared identifier 'SPARK_LOG_WARN' [macos-Release-Metal]
/U er /runner/work/SparkEngine/SparkEngine/SparkEngine/Source/Graphic /RHI/Metal/MetalRayTracing.mm:417:13: error: u e of undeclared identifier 'SPARK_LOG_INFO' [macos-Release-Metal]
/U er /runner/work/SparkEngine/SparkEngine/SparkEngine/Source/Graphic /RHI/Metal/MetalRayTracing.mm:449:13: error: u e of undeclared identifier 'SPARK_LOG_ERROR' [macos-Release-Metal]
Full error output
/Application /Xcode_16.4.app/Content /Developer/Platform /MacOSX.platform/Developer/SDK /MacOSX. dk/Sy tem/Library/Framework /OpenAL.framework/Header /alc.h:49:33: error: typedef redefinition with different type  (' truct ALCdevice_ truct' v  ' truct ALCdevice')
/Application /Xcode_16.4.app/Content /Developer/Platform /MacOSX.platform/Developer/SDK /MacOSX. dk/Sy tem/Library/Framework /OpenAL.framework/Header /alc.h:50:34: error: typedef redefinition with different type  (' truct ALCcontext_ truct' v  ' truct ALCcontext')
/Application /Xcode_16.4.app/Content /Developer/Platform /MacOSX.platform/Developer/SDK /MacOSX. dk/u r/include/objc/objc.h:85:18: error: type alia  redefinition with different type  ('bool' v  'int')
/U er /runner/work/SparkEngine/SparkEngine/SparkEngine/Source/Graphic /RHI/Metal/MetalRayTracing.mm:59:17: error: u e of undeclared identifier 'SPARK_LOG_WARN'
/U er /runner/work/SparkEngine/SparkEngine/SparkEngine/Source/Graphic /RHI/Metal/MetalRayTracing.mm:417:13: error: u e of undeclared identifier 'SPARK_LOG_INFO'
/U er /runner/work/SparkEngine/SparkEngine/SparkEngine/Source/Graphic /RHI/Metal/MetalRayTracing.mm:449:13: error: u e of undeclared identifier 'SPARK_LOG_ERROR'
### Test Failures
Test Jobs
1/1 Test #1: SparkEngineTests .................***Failed 15.72 sec windows-vs2022-Release
[ FAILED ] Training_GradientCheckHuber (1.2ms, 1 assertions) windows-vs2022-Release
0% tests passed, 1 tests failed out of 1 windows-vs2022-Release

⚠️ Test Warnings (Known Flaky)

These tests are registered as known flaky and do not block the build:

Test Jobs
[20:10:50.724] [TID:5476] [WARN ] [Network ] RCON unknown command: nonexistent_cmd (DedicatedServer.cpp:573) windows-vs2022-Release
[20:10:50.738] [TID:5476] [WARN ] [Network ] NetBuffer::ReadUint8 — buffer overrun at pos 1 (size=1) (NetworkBuffer.c... windows-vs2022-Release
[20:10:50.758] [TID:5476] [WARN ] [AI ] BuildNavMeshWithRecast: empty geometry (RecastDetourBackend.cpp:35) windows-vs2022-Release
[20:10:50.758] [TID:5476] [WARN ] [AI ] NavMeshBuilder: Recast build failed, falling back to triangle-soup builder (N... windows-vs2022-Release
[20:10:50.758] [TID:5476] [WARN ] [Audio ] XAudio2 backend requested but no AudioEngine provided, falling back to Nul... windows-vs2022-Release
[ [20:10:50.776] [TID:5476] [WARN ] [Graphics ] No graphics backend available — falling back to NullRHIDevice (headle... windows-vs2022-Release
[20:10:50.776] [TID:5476] [WARN ] [Graphics ] No graphics backend available — falling back to NullRHIDevice (headless... windows-vs2022-Release
[20:10:50.780] [TID:5476] [WARN ] [Editor ] Cannot host: userName is empty. (CollaborativeEditSession.cpp:454) windows-vs2022-Release
[20:10:50.780] [TID:5476] [WARN ] [Editor ] Already connected. (CollaborativeEditSession.cpp:459) windows-vs2022-Release
[20:10:50.783] [TID:5476] [WARN ] [Editor ] BroadcastEdit rejected: nodeId is empty. (CollaborativeEditSession.cpp:1108) windows-vs2022-Release
[20:10:50.783] [TID:5476] [WARN ] [Editor ] BroadcastEdit rejected: sourceEditor is not set. (CollaborativeEditSessio... windows-vs2022-Release
[20:10:50.784] [TID:5476] [WARN ] [Editor ] SetLocalSelection rejected: nodeId exceeds 255 chars (length=300). (Colla... windows-vs2022-Release
[20:10:56.358] [TID:5476] [WARN ] [Network ] Connection rejected for pending client 5: server full (4/4) (NetworkConn... windows-vs2022-Release
[20:10:56.360] [TID:5476] [WARN ] [Network ] Invalid packet magic 0x6A0E5CB3 (expected 0x5350524B) (NetworkManager.cp... windows-vs2022-Release
[20:10:56.360] [TID:5476] [WARN ] [Network ] Invalid packet magic 0xC6BB6E5B (expected 0x5350524B) (NetworkManager.cp... windows-vs2022-Release
Compiler Warnings (7)
../../../ThirdParty/SDL2/ rc/event /SDL_quit.c:83:41: warning: ca t from 'void (*)(int,  truct __ iginfo *, void *)' to 'void (*)(int)' convert  to incompatible function type [-Wca t-function-type-mi match] [macos-Debug-OpenGL, macos-Release-Metal, macos-Release-OpenGL]
../../../ThirdParty/SDL2/ rc/joy tick/iphoneo /SDL_mfijoy tick.m:504:27: warning: 'gamepad' i  deprecated: fir t deprecated in macOS 10.12 [-Wdeprecated-declaration ] [macos-Debug-OpenGL, macos-Release-Metal, macos-Release-OpenGL]
../../../ThirdParty/SDL2/ rc/joy tick/iphoneo /SDL_mfijoy tick.m:800:24: warning: 'controllerPau edHandler' i  deprecated: fir t deprecated in macOS 10.15 - U e the Menu button found on the controller'  input profile, if it exi t . [-Wdeprecated-declaration ] [macos-Debug-OpenGL, macos-Release-Metal, macos-Release-OpenGL]
../../../ThirdParty/SDL2/ rc/joy tick/iphoneo /SDL_mfijoy tick.m:1263:13: warning: 'GCGamepad' i  deprecated: fir t deprecated in macOS 10.12 [-Wdeprecated-declaration ] [macos-Debug-OpenGL, macos-Release-Metal, macos-Release-OpenGL]
../../../ThirdParty/SDL2/ rc/video/cocoa/SDL_cocoaevent .m:188:55: warning:  emicolon before method body i  ignored [-W emicolon-before-method-body] [macos-Debug-OpenGL, macos-Release-Metal, macos-Release-OpenGL]
../../../ThirdParty/SDL2/ rc/video/cocoa/SDL_cocoametalview.m:82:47: warning:  emicolon before method body i  ignored [-W emicolon-before-method-body] [macos-Debug-OpenGL, macos-Release-Metal, macos-Release-OpenGL]
../../../ThirdParty/SDL2/ rc/video/cocoa/SDL_cocoamode .m:122:23: warning: 'CGDi playModeCopyPixelEncoding' i  deprecated: fir t deprecated in macOS 10.11 - No longer  upported [-Wdeprecated-declaration ] [macos-Debug-OpenGL, macos-Release-Metal, macos-Release-OpenGL]

Updated: 2026-06-08T20:17:48Z — this comment is updated in-place, not duplicated.

Bumps [ThirdParty/SDL2](https://github.com/libsdl-org/SDL) from `859844e` to `79de30a`.
- [Release notes](https://github.com/libsdl-org/SDL/releases)
- [Commits](libsdl-org/SDL@859844e...79de30a)

---
updated-dependencies:
- dependency-name: ThirdParty/SDL2
  dependency-version: b53f1b06447cfe699e2649afc52a1a54e5f19f71
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot changed the title deps: bump ThirdParty/SDL2 from e4f75ba to b53f1b0 deps: bump ThirdParty/SDL2 from 859844e to 79de30a Jun 8, 2026
@dependabot dependabot Bot force-pushed the dependabot/submodules/ThirdParty/SDL2-b53f1b0 branch from 8a1829e to 4bf8514 Compare June 8, 2026 19:31
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Code Coverage (GCC + lcov)

Utils/StringUtils.h                            |18.1%   116| 0.0%  21|    -    0
Utils/Telemetry.h                              |20.6%   136| 0.0%  23|    -    0
Utils/ThreadDebugger.h                         |11.6%   199| 0.0%  23|    -    0
Utils/ThreadSafeQueue.h                        |27.5%    40| 0.0%  11|    -    0
Utils/Timer.cpp                                |19.4%    36| 0.0%   7|    -    0
Utils/Timer.h                                  | 100%     2| 0.0%   2|    -    0
Utils/TimerManager.h                           |18.6%   102| 0.0%  19|    -    0
Utils/Tween.h                                  |26.3%    38| 0.0%   6|    -    0
Utils/UUID.h                                   |43.2%    37| 0.0%  16|    -    0
Utils/Validate.h                               |    -     0|    -   0|    -    0
Utils/WineDetection.cpp                        |23.1%    39| 0.0%   9|    -    0

[/home/runner/work/SparkEngine/SparkEngine/SparkSDK/Include/Spark/]
IEngineContext.h                               |7300%     1| 0.0%   1|    -    0
IModule.h                                      | 800%     1| 0.0%   1|    -    0
ServiceInterfaces.h                            | 200%     3| 0.0%   3|    -    0
Version.h                                      |    -     0|    -   0|    -    0

[/home/runner/work/SparkEngine/SparkEngine/Templates/EmptyProject/Source/]
GameModule.h                                   |38.9%    18| 0.0%   6|    -    0

[/home/runner/work/SparkEngine/SparkEngine/Templates/FPSStarter/Source/]
GameModule.h                                   |36.0%    25| 0.0%   7|    -    0

[/home/runner/work/SparkEngine/SparkEngine/Templates/MultiplayerArena/Source/]
GameModule.h                                   |34.6%    26| 0.0%   7|    -    0

[/home/runner/work/SparkEngine/SparkEngine/Templates/PlatformerKit/Source/]
GameModule.h                                   |25.0%    32| 0.0%   7|    -    0

[/home/runner/work/SparkEngine/SparkEngine/Templates/RPGStarter/Source/]
GameModule.h                                   |37.5%    24| 0.0%   8|    -    0
================================================================================
                                         Total:|30.4% 35381| 0.0%  6k|    -    0

Per-Subsystem Coverage

Subsystem Lines Hit Coverage Threshold Status
AI 3731 942 25.2% 35%
Animation 905 277 30.6% 35%
Audio 0 0 0% 30%
Camera 0 0 0% 40%
Core 4944 2950 59.7% 40%
ECS 426 213 50% 40%
Editor 7503 3046 40.6% 25%
GameModules 6621 3232 48.8% 30%
Graphics 17920 9063 50.6% 30%
Networking 3578 2376 66.4% 35%
Physics 0 0 0% 35%
Scripting 283 80 28.3% 30%
Utils 9877 6144 62.2% 60%

Total: 50.8% (28323/55788 lines)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants