Validate that at least one translation is provided when deserializing with TranslationsMixin. Fixes #256.

Author: spectras

hvad/contrib/restframework/utils.py

@@ -11,6 +11,7 @@ class TranslationListSerializer(serializers.ListSerializer):
     many = True
     default_error_messages = {
         'not_a_dict': _l('Expected a dictionary of items, but got a {input_type}.'),
+        'no_translation': _l('At least one translation must be provided.'),
     }
 
     def to_internal_value(self, data):
@@ -21,6 +22,11 @@ def to_internal_value(self, data):
             raise ValidationError({
                 api_settings.NON_FIELD_ERRORS_KEY: [message]
             })
+        if not data:
+            message = self.error_messages['no_translation']
+            raise ValidationError({
+                api_settings.NON_FIELD_ERRORS_KEY: [message]
+            })
 
         ret, errors = {}, {}
         for language, translation in data.items():

hvad/tests/contrib/restframework.py

@@ -288,6 +288,14 @@ def test_serialize_custom(self):
 
     def test_invalid(self):
         'Submit invalid data'
+        # No translations
+        data = {
+            'shared_field': 'shared',
+            'translations': {},
+        }
+        serializer = TranslationsSerializer(data=data)
+        self.assertFalse(serializer.is_valid())
+        self.assertTrue(serializer.errors['translations'])
 
         # Invalid translations type
         data = {