HttpClient extension, pipeline behaviour config (#51)

* HttpClient extension, pipeline behaviour config

* HttpClientFactoryExtension and unit test

* Catch simplified

Author: urbanox

src/Kros.AspNetCore/Extensions/HttpClientFactoryExtensions.cs

@@ -0,0 +1,37 @@
+using Microsoft.AspNetCore.Http;
+using System.Linq;
+using System.Net.Http;
+using System.Net.Http.Headers;
+
+namespace Kros.AspNetCore.Net
+{
+    /// <summary>
+    /// Extensions for HttpClientFactory.
+    /// </summary>
+    public static class HttpClientFactoryExtensions
+    {
+        /// <summary>
+        /// Creates HttpClient with authorization header from <paramref name="httpContextAccessor"/>.
+        /// </summary>
+        public static HttpClient CreateClientWithAuthorization(this IHttpClientFactory httpClientFactory, IHttpContextAccessor httpContextAccessor)
+        {
+            HttpClient client = httpClientFactory.CreateClient();
+            try
+            {
+                string authHeader = httpContextAccessor.HttpContext.Request.Headers["Authorization"].FirstOrDefault();
+                if (authHeader != null)
+                {
+                    AuthenticationHeaderValue.TryParse(authHeader, out AuthenticationHeaderValue newVal);
+                    client.DefaultRequestHeaders.Authorization = newVal;
+                }
+            }
+            catch
+            {
+                client.Dispose();
+                throw;
+            }
+
+            return client;
+        }
+    }
+}

src/Kros.AspNetCore/Kros.AspNetCore.csproj

@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <TargetFramework>netcoreapp2.2</TargetFramework>
-    <Version>1.4.0</Version>
+    <Version>1.5.0</Version>
     <Authors>KROS a.s.</Authors>
     <Description>General utilities and helpers for building ASP.NET Core WEB API</Description>
     <PackageProjectUrl>https://github.com/Kros-sk/Kros.AspNetCore/tree/master/src/Kros.AspNetCore</PackageProjectUrl>

src/Kros.MediatR.Extensions/PipelineBehaviorsConfig.cs

@@ -0,0 +1,20 @@
+using System.Reflection;
+
+namespace Kros.MediatR.Extensions
+{
+    /// <summary>
+    /// Config for pipeline behaviours.
+    /// </summary>
+    public class PipelineBehaviorsConfig
+    {
+        /// <summary>
+        /// Assembly with pipeline behaviours.
+        /// </summary>
+        public Assembly PipelineBehaviorsAssembly { get; set; }
+
+        /// <summary>
+        /// Assembly with requests.
+        /// </summary>
+        public Assembly RequestsAssembly { get; set; }
+    }
+}

src/Kros.MediatR.Extensions/ServiceCollectionExtensions.cs

@@ -20,16 +20,20 @@ public static class ServiceCollectionExtensions
         /// </summary>
         /// <typeparam name="TRequest">Request type.</typeparam>
         /// <param name="services">Service container.</param>
+        /// <param name="configAction">Pipeline behaviors config.</param>
         /// <exception cref="InvalidOperationException">When number of implementation
         /// <typeparamref name="TRequest"/> and response are different.</exception>
-        public static IServiceCollection AddPipelineBehaviorsForRequest<TRequest>(this IServiceCollection services)
+        public static IServiceCollection AddPipelineBehaviorsForRequest<TRequest>(this IServiceCollection services, Action<PipelineBehaviorsConfig> configAction = null)
         {
+            var config = new PipelineBehaviorsConfig();
+            configAction?.Invoke(config);
+
             Type requestType = typeof(TRequest);
             Type pipeLineType = typeof(IPipelineBehavior<,>);
             string requestInterfaceName = typeof(IRequest<>).Name;
 
-            IList<Type> requests = GetTypes(requestType);
-            IEnumerable<Type> pipelineBehaviors = GetPipelineBehaviors(requestType, pipeLineType);
+            IList<Type> requests = GetTypes(requestType, config.RequestsAssembly);
+            IEnumerable<Type> pipelineBehaviors = GetPipelineBehaviors(requestType, pipeLineType, config.PipelineBehaviorsAssembly);
 
             foreach (Type behavior in pipelineBehaviors)
             {
@@ -59,14 +63,15 @@ public static IServiceCollection AddPipelineBehaviorsForRequest<TRequest>(this I
             return services;
         }
 
-        private static IEnumerable<Type> GetPipelineBehaviors(Type requestType, Type pipeLineType)
-            => Assembly.GetAssembly(requestType).GetTypes()
+        private static IEnumerable<Type> GetPipelineBehaviors(Type requestType, Type pipeLineType, Assembly behavioursAssembly)
+            => (behavioursAssembly ?? Assembly.GetAssembly(requestType))
+            .GetTypes()
             .Where(t
                 => t.GetInterface(pipeLineType.Name) != null
                 && t.GetGenericArguments()[0].GetInterface(requestType.Name) != null);
 
-        private static IList<Type> GetTypes(Type type)
-            => Assembly.GetAssembly(type)
+        private static IList<Type> GetTypes(Type type, Assembly assembly)
+            => (assembly ?? Assembly.GetAssembly(type))
             .GetTypes()
             .Where(t => !t.IsInterface && !t.IsAbstract & type.IsAssignableFrom(t))
             .ToList();

tests/Kros.AspNetCore.Tests/Extensions/HttpClientFactoryExtensionsShould.cs

@@ -0,0 +1,30 @@
+using FluentAssertions;
+using Kros.AspNetCore.Net;
+using Microsoft.AspNetCore.Http;
+using NSubstitute;
+using System.Net.Http;
+using Xunit;
+
+namespace Kros.AspNetCore.Tests.Extensions
+{
+    public class HttpClientFactoryExtensionsShould
+    {
+        [Fact]
+        public void CopyAuthorizationHeader()
+        {
+            var httpClient = new HttpClient();
+            IHttpClientFactory httpClientFactory = Substitute.For<IHttpClientFactory>();
+            httpClientFactory.CreateClient().Returns(httpClient);
+
+            var httpContext = new DefaultHttpContext();
+            httpContext.Request.Headers["Authorization"] = "Bearer sfasdfasdf414weqr";
+            IHttpContextAccessor httpContextAccessor = Substitute.For<IHttpContextAccessor>();
+            httpContextAccessor.HttpContext.Returns(httpContext);
+
+            using (HttpClient clientAuth = httpClientFactory.CreateClientWithAuthorization(httpContextAccessor))
+            {
+                clientAuth.DefaultRequestHeaders.Authorization.Should().Equals(httpContext.Request.Headers["Authorization"]);
+            }
+        }
+    }
+}