Skip to content

excess over mintFeeAmount not returned #113

@dckc

Description

@dckc

I'm doing some testing and I didn't have the mintFeeAmount handy, so I tried 50IST. Minting worked, but it took all 50IST. Some experimentation suggests the mintFeeAmount is 5IST, so I would expect to get 45IST back.

But the contract computes the platform / royalty split on the whole give.Price, not just mintFeeAmount:

const royaltyFee = multiplyBy(give.Price, mintRoyaltyRate);
const platformFee = multiplyBy(give.Price, mintPlatformFeeRate);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions