Skip to content

Commit 4c59de3

Browse files
committed
Return document bitmap
1 parent 28e9ffa commit 4c59de3

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
# 0.1.4
44
> 2020-07-21
5+
- Return preview bitmap on user confirmation
56
- Added fullscreen
67

78
# 0.1.3

README.md

+1-2
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@ class ScannerActivity : BaseScannerActivity() {
3737
}
3838
}
3939

40-
override fun onDocumentAccepted(path: String) {
41-
Toast.makeText(this, path, Toast.LENGTH_LONG).show()
40+
override fun onDocumentAccepted(bitmap: Bitmap) {
4241
}
4342

4443
override fun onClose() {

app/src/main/java/net/kuama/documentscanner/presentation/BaseScannerActivity.kt

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
package net.kuama.documentscanner.presentation
22

3+
import android.graphics.Bitmap
34
import android.os.Bundle
45
import android.util.Log
56
import android.view.View
6-
import android.view.Window
7-
import android.view.WindowManager
87
import android.widget.SeekBar
98
import androidx.activity.viewModels
109
import androidx.appcompat.app.AppCompatActivity
10+
import androidx.core.view.drawToBitmap
1111
import androidx.lifecycle.Observer
1212
import kotlinx.android.synthetic.main.activity_scanner.*
1313
import net.kuama.documentscanner.R
@@ -97,7 +97,7 @@ abstract class BaseScannerActivity : AppCompatActivity() {
9797

9898
confirmDocument.setOnClickListener {
9999
previewWrap.visibility = View.GONE
100-
onDocumentAccepted(viewModel.documentPath!!)
100+
onDocumentAccepted(documentPreview.drawToBitmap())
101101
}
102102

103103
closeScanner.setOnClickListener {
@@ -127,6 +127,6 @@ abstract class BaseScannerActivity : AppCompatActivity() {
127127
}
128128

129129
abstract fun onError(throwable: Throwable)
130-
abstract fun onDocumentAccepted(path: String)
130+
abstract fun onDocumentAccepted(bitmap: Bitmap)
131131
abstract fun onClose()
132132
}

app/src/main/java/net/kuama/documentscanner/presentation/ScannerActivity.kt

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package net.kuama.documentscanner.presentation
22

3+
import android.graphics.Bitmap
34
import android.widget.Toast
45
import net.kuama.documentscanner.R
56
import net.kuama.documentscanner.exceptions.NullCorners
@@ -16,8 +17,7 @@ class ScannerActivity : BaseScannerActivity() {
1617
}
1718
}
1819

19-
override fun onDocumentAccepted(path: String) {
20-
Toast.makeText(this, path, Toast.LENGTH_LONG).show()
20+
override fun onDocumentAccepted(bitmap: Bitmap) {
2121
}
2222

2323
override fun onClose() {

gradle.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@ android.useAndroidX=true
1919
android.enableJetifier=true
2020
# Kotlin code style for this project: "official" or "obsolete":
2121
kotlin.code.style=official
22-
version_code=5
22+
version_code=6
2323
version_name=0.1.4

0 commit comments

Comments
 (0)