Update fedora Docker tag to v44 #38
Conversation
|
WalkthroughUpdated the CI Dockerfile base image from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
gh-actions/Dockerfile (4)
11-11: Clean DNF cache after upgrade to reduce image size.Add a clean to the same layer to avoid leaving metadata in the image.
-RUN dnf -y upgrade --refresh +RUN dnf -y upgrade --refresh && dnf clean all
14-15: Validate package names on Fedora 44 and tighten install flags.Fedora major bumps sometimes rename/remove Python/COPR packages and change DNF plugin availability. Also, avoid weak deps to keep the image lean.
-# hadolint ignore=DL3008 -RUN dnf -y install curl wget sudo python-copr python-copr-doc \ - dnf-plugins-core git && dnf clean all +# hadolint ignore=DL3008 +RUN dnf -y --setopt=install_weak_deps=False install \ + curl wget sudo git dnf-plugins-core python-copr python-copr-doc \ + && dnf clean allIf any of these packages are unavailable in 44, please swap to their Fedora 44 equivalents (e.g., python3-* or copr-cli) before merging.
17-19: Write sudoers entry to /etc/sudoers.d instead of editing the main file.Safer and more conventional; avoids accidental duplicate appends.
RUN useradd -m -d $USER_HOME $USERNAME && \ usermod -aG wheel $USERNAME && \ - echo "$USERNAME ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers + printf '%s ALL=(ALL) NOPASSWD:ALL\n' "$USERNAME" > /etc/sudoers.d/$USERNAME
31-31: Confirm ENTRYPOINT bash is intentional for CI.A bash entrypoint can override commands from downstream users of this image. If this is meant only for interactive use, consider leaving CMD empty or using
CMD ["/bin/bash"]instead.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
gh-actions/Dockerfile(1 hunks)
🔇 Additional comments (1)
gh-actions/Dockerfile (1)
1-1: Major base image bump — verify manifest/platforms and package availabilityFile: gh-actions/Dockerfile (line 1):
FROM fedora:44@sha256:e610aabae07cf173f3fab7acfeb194cf348ec7af0cc299a79a279afec9a3b4b7
- Confirm the digest resolves to a manifest-list covering your target platforms (amd64/arm64).
- Verify packages referenced later still exist on Fedora 44 (e.g., python-copr, python-copr-doc, dnf-plugins-core) and that DNF plugin behavior didn't change.
Verification attempt failed in the sandbox: docker not available (/bin/bash: docker: command not found). Run locally and report results:
docker buildx imagetools inspect fedora:44@sha256:e610aabae07cf173f3fab7acfeb194cf348ec7af0cc299a79a279afec9a3b4b7 docker build --no-cache -f gh-actions/Dockerfile .
KubeArchitectBot
force-pushed
the
renovate/gh-actions-fedora-44.x
branch
from
56921a1 to
137d241
Compare
KubeArchitectBot
changed the title
KubeArchitectBot
changed the title
KubeArchitectBot
force-pushed
the
renovate/gh-actions-fedora-44.x
branch
from
a4cfcd3 to
137d241
Compare
KubeArchitectBot
force-pushed
the
renovate/gh-actions-fedora-44.x
branch
from
137d241 to
06a2943
Compare
KubeArchitectBot
force-pushed
the
renovate/gh-actions-fedora-44.x
branch
from
06a2943 to
7f1869d
Compare
KubeArchitectBot
force-pushed
the
renovate/gh-actions-fedora-44.x
branch
from
7f1869d to
5b9cb75
Compare
This PR contains the following updates:
42->44Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.