fix: update PR remplate and tighten file opening

Author: KulikDM

.github/PULL_REQUEST_TEMPLATE.md

@@ -22,6 +22,6 @@
 
 - [ ] Have you created a <NewThresholder>.py in ~/pythresh/thresholds/?
 - [ ] Have you created a <NewThresholder>\_example.py in ~/examples/?
-- [ ] Have you created a test\_<NewThresholder>.py in ~/pythresh/test/?
+- [ ] Have you created a test\_<NewThresholder>.py in ~/tests/?
 - [ ] Have you lint your code locally prior to submission?
 - [ ] Have you added a reference of the new thresholder in your explanation?

.pre-commit-config.yaml

@@ -14,7 +14,7 @@ repos:
         args: [--fix=lf]
 
   - repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: v0.15.13
+    rev: v0.15.15
     hooks:
       - id: ruff
         name: Fix code

pythresh/models/__init__.py

@@ -1,4 +1,4 @@
-from importlib.resources import files
+from importlib.resources import as_file, files
 
 import joblib
 import numpy as np
@@ -109,8 +109,8 @@ def eval(self, decision):
 
         contam = []
         counts = len(decision)
-        model_path = files("pythresh.models").joinpath(clf)
-        model = joblib.load(model_path)
+        with as_file(files("pythresh.models").joinpath(clf)) as model_path:
+            model = joblib.load(model_path)
 
         # Sklearn 1.8.0 API patch
         for e in getattr(model, "estimators_", {}).values():

pythresh/thresholds/meta.py

@@ -1,4 +1,4 @@
-from importlib.resources import files
+from importlib.resources import as_file, files
 
 import numpy as np
 import scipy.stats as stats
@@ -174,9 +174,9 @@ def eval(self, X):
         if self.method == "model":
             # Load trained ranking model
             clf = "rank_model_XGB.json"
-            model_path = files("pythresh.models").joinpath(clf)
             ranker = xgb.XGBRanker()
-            ranker.load_model(model_path)
+            with as_file(files("pythresh.models").joinpath(clf)) as model_path:
+                ranker.load_model(model_path)
 
             # Transform data
             scaler = MinMaxScaler()