[UI] Implement Save File Dialog (currently desktop-only)

Fix dialog robustness on Mac

fix #61

Author: KvanTTT

composeApp/src/androidMain/kotlin/org/dots/game/PlatformUtils.android.kt

@@ -57,9 +57,19 @@ actual suspend fun downloadFileText(fileUrl: String): String = URI.create(fileUr
     it.readBytes().decodeToString()
 }
 
+@Composable
+actual fun SaveFileDialog(
+    title: String?,
+    selectedFile: String?,
+    extension: String,
+    onFileSelected: (String?) -> Unit,
+    content: String
+) {
+}
+
 @Composable
 actual fun OpenFileDialog(
-    title: String,
+    title: String?,
     selectedFile: String?,
     allowedExtensions: List<String>,
     onFileSelected: (String?) -> Unit
@@ -146,4 +156,4 @@ private object AndroidPickedFiles {
     fun exists(path: String): Boolean = nameToUri.containsKey(path)
 }
 
-actual val platform: String = "android"
+actual val platform: String = "android"

composeApp/src/androidMain/kotlin/org/dots/game/views/KataGoDotsSettingsForm.android.kt

@@ -0,0 +1,13 @@
+package org.dots.game.views
+
+import androidx.compose.runtime.Composable
+import org.dots.game.KataGoDotsEngine
+import org.dots.game.KataGoDotsSettings
+
+@Composable
+actual fun KataGoDotsSettingsForm(
+    kataGoDotsSettings: KataGoDotsSettings,
+    onSettingsChange: (KataGoDotsEngine) -> Unit,
+    onDismiss: () -> Unit
+) {
+}

composeApp/src/commonMain/kotlin/org/dots/game/App.kt

@@ -192,13 +192,20 @@ fun App(currentGameSettings: CurrentGameSettings = loadClassSettings(CurrentGame
             SaveDialog(
                 games,
                 getField(),
+                currentGameSettings.path,
                 dumpParameters,
                 uiSettings,
-                onDismiss = {
+                onDismiss = { newDumpParameters, newPath ->
                     showSaveGameDialog = false
                     focusRequester.requestFocus()
-                    dumpParameters = it
-                    saveClassSettings(it)
+                    dumpParameters = newDumpParameters
+                    saveClassSettings(newDumpParameters)
+                    if (newPath != null) {
+                        openGameSettings = openGameSettings.copy(pathOrContent = newPath)
+                        saveClassSettings(openGameSettings)
+                        currentGameSettings.path = newPath
+                        saveClassSettings(currentGameSettings, games)
+                    }
                 })
         }
 

composeApp/src/commonMain/kotlin/org/dots/game/PlatformUtils.kt

@@ -16,12 +16,21 @@ expect fun fileExists(filePath: String): Boolean
 
 expect suspend fun downloadFileText(fileUrl: String): String
 
+@Composable
+expect fun SaveFileDialog(
+    title: String?,
+    selectedFile: String?,
+    extension: String,
+    onFileSelected: (String?) -> Unit,
+    content: String,
+)
+
 @Composable
 expect fun OpenFileDialog(
-    title: String = "Open File",
+    title: String?,
     selectedFile: String?,
     allowedExtensions: List<String> = emptyList(),
-    onFileSelected: (String?) -> Unit
+    onFileSelected: (String?) -> Unit,
 )
 
 expect val platform: String

composeApp/src/commonMain/kotlin/org/dots/game/views/SaveDialog.kt

@@ -10,6 +10,7 @@ import androidx.compose.ui.text.TextStyle
 import androidx.compose.ui.text.font.FontFamily
 import androidx.compose.ui.unit.dp
 import androidx.compose.ui.window.Dialog
+import org.dots.game.SaveFileDialog
 import org.dots.game.UiSettings
 import org.dots.game.core.Field
 import org.dots.game.core.Games
@@ -20,9 +21,10 @@ import org.dots.game.sgf.SgfWriter
 fun SaveDialog(
     games: Games,
     field: Field,
+    path: String?,
     dumpParameters: DumpParameters,
     uiSettings: UiSettings,
-    onDismiss: (DumpParameters) -> Unit,
+    onDismiss: (dumpParameters: DumpParameters, newPath: String?) -> Unit,
 ) {
     val strings by remember { mutableStateOf(uiSettings.language.getStrings()) }
     var minX = field.realWidth - 1
@@ -55,6 +57,35 @@ fun SaveDialog(
     var isSgf by remember { mutableStateOf(dumpParameters.isSgf) }
     var fieldRepresentation by remember { mutableStateOf("") }
 
+    var path by remember { mutableStateOf(path ?: "") }
+    var showSaveDialog by remember { mutableStateOf(false) }
+
+    fun createDumpParameters(): DumpParameters {
+        return DumpParameters(
+            printNumbers = printNumbers,
+            padding = padding,
+            printCoordinates = printCoordinates,
+            debugInfo = debugInfo,
+            isSgf = isSgf
+        )
+    }
+
+    if (showSaveDialog) {
+        SaveFileDialog(
+            title = "Save game to ${if (isSgf) "sgf" else "txt"}",
+            selectedFile = path,
+            extension = if (isSgf) "sgf" else "txt",
+            onFileSelected = {
+                if (it != null) {
+                    path = it
+                    onDismiss(createDumpParameters(), path)
+                }
+                showSaveDialog = false
+            },
+            content = fieldRepresentation,
+        )
+    }
+
     fun updateFieldRepresentation() {
         fieldRepresentation = if (isSgf) {
             SgfWriter.write(games)
@@ -66,13 +97,7 @@ fun SaveDialog(
     updateFieldRepresentation()
 
     Dialog(onDismissRequest = {
-        onDismiss(DumpParameters(
-            printNumbers = printNumbers,
-            padding = padding,
-            printCoordinates = printCoordinates,
-            debugInfo = debugInfo,
-            isSgf = isSgf
-        ))
+        onDismiss(createDumpParameters(), null)
     }) {
         Card(modifier = Modifier.wrapContentHeight()) {
             Column(modifier = Modifier.padding(20.dp)) {
@@ -125,6 +150,23 @@ fun SaveDialog(
                         })
                     }
                 }
+
+                Row(verticalAlignment = Alignment.CenterVertically) {
+                    Text("Path", Modifier.fillMaxWidth(0.1f))
+                    TextField(path, {
+                        path = it
+                    },
+                    modifier = Modifier.fillMaxWidth(0.8f).padding(vertical = 10.dp),
+                        maxLines = 1,
+                        singleLine = true,
+                    )
+                    Button(
+                        onClick = { showSaveDialog = true },
+                        Modifier.padding(horizontal = 10.dp),
+                    ) {
+                        Text("Save")
+                    }
+                }
             }
         }
     }

composeApp/src/desktopMain/kotlin/org/dots/game/PlatformUtils.desktop.kt

@@ -107,15 +107,41 @@ data class WindowSettings(
     }
 }
 
+@Composable
+actual fun SaveFileDialog(
+    title: String?,
+    selectedFile: String?,
+    extension: String,
+    onFileSelected: (String?) -> Unit,
+    content: String,
+) {
+    FileDialog(title, selectedFile, listOf(extension), onFileSelected, content)
+}
+
 @Composable
 actual fun OpenFileDialog(
-    title: String,
+    title: String?,
+    selectedFile: String?,
+    allowedExtensions: List<String>,
+    onFileSelected: (String?) -> Unit,
+) {
+    FileDialog(title, selectedFile, allowedExtensions, onFileSelected, content = null)
+}
+
+@Composable
+private fun FileDialog(
+    title: String?,
     selectedFile: String?,
     allowedExtensions: List<String>,
-    onFileSelected: (String?) -> Unit
+    onFileSelected: (String?) -> Unit,
+    content: String?,
 ) {
+    // Save mode doesn't allow multiple extensions
+    require(content == null || allowedExtensions.size <= 1)
+
     val fileDialog = remember {
-        FileDialog(null as Frame?, title, FileDialog.LOAD).apply {
+        val mode = if (content != null) FileDialog.SAVE else FileDialog.LOAD
+        FileDialog(null as Frame?, title, mode).apply {
             if (allowedExtensions.isNotEmpty()) {
                 // TODO: figure out why it doesn't work on Windows and fix
                 filenameFilter = FilenameFilter { _, name ->
@@ -127,17 +153,24 @@ actual fun OpenFileDialog(
                     }
                 }
             }
-            file = selectedFile
+            if (selectedFile != null) {
+                val fileObj = File(selectedFile)
+                directory = fileObj.parent
+                file = fileObj.name
+            }
             isVisible = true
         }
     }
 
     LaunchedEffect(Unit) {
         withContext(Dispatchers.IO) {
             val selectedFile = fileDialog.file?.let {
-                File(fileDialog.directory, it).absolutePath
+                File(fileDialog.directory, it)
+            }
+            if (selectedFile != null && content != null) {
+                selectedFile.writeText(content)
             }
-            onFileSelected(selectedFile)
+            onFileSelected(selectedFile?.absolutePath)
         }
     }
 }

composeApp/src/nativeMain/kotlin/org/dots/game/PlatformUtils.native.kt

@@ -25,9 +25,19 @@ actual fun fileExists(filePath: String): Boolean = false
 
 actual suspend fun downloadFileText(fileUrl: String): String = error("File downloading by url is not supported")
 
+@Composable
+actual fun SaveFileDialog(
+    title: String?,
+    selectedFile: String?,
+    extension: String,
+    onFileSelected: (String?) -> Unit,
+    content: String
+) {
+}
+
 @Composable
 actual fun OpenFileDialog(
-    title: String,
+    title: String?,
     selectedFile: String?,
     allowedExtensions: List<String>,
     onFileSelected: (String?) -> Unit

composeApp/src/webMain/kotlin/org/dots/game/PlatformUtils.web.kt

@@ -38,10 +38,21 @@ actual suspend fun downloadFileText(fileUrl: String): String {
     return response.text().await()
 }
 
+@Composable
+actual fun SaveFileDialog(
+    title: String?,
+    selectedFile: String?,
+    extension: String,
+    onFileSelected: (String?) -> Unit,
+    content: String
+) {
+    // TODO: See https://github.com/KvanTTT/dots-game/issues/65
+}
+
 @OptIn(ExperimentalWasmJsInterop::class)
 @Composable
 actual fun OpenFileDialog(
-    title: String,
+    title: String?,
     selectedFile: String?,
     allowedExtensions: List<String>,
     onFileSelected: (String?) -> Unit
@@ -132,4 +143,4 @@ private object WasmVirtualFS {
     fun exists(path: String): Boolean = files.containsKey(path)
 }
 
-actual val platform: String = "web"
+actual val platform: String = "web"