Skip to content

Commit 0899cd0

Browse files
authored
Merge pull request #737 from KxSystems/ee-refactor
Refactor for wrapper changes
2 parents 390f8e5 + 2455604 commit 0899cd0

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

src/classes/localConnection.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,21 +138,22 @@ export class LocalConnection {
138138
args.push(
139139
context ?? ".",
140140
command,
141+
null,
141142
stringify ? "text" : "structuredText",
142143
);
143144
}
144145
this.connection.k(wrapper, ...args, (err: Error, res: QueryResult) => {
145146
if (err) {
146147
reject(handleQueryResults(err.toString(), QueryResultType.Error));
147-
} else if (res.errored) {
148+
} else if (res.error) {
148149
resolve(
149150
handleQueryResults(
150-
res.error + (res.backtrace ? "\n" + res.backtrace : ""),
151+
res.errorMsg + (res.stacktrace ? "\n" + res.stacktrace : ""),
151152
QueryResultType.Error,
152153
),
153154
);
154155
} else {
155-
const result = res.result === null ? "" : res.result;
156+
const result = res.data === null ? "" : res.data;
156157
if (stringify) {
157158
resolve(result);
158159
} else {

src/models/queryResult.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@ export type QueryResult = {
2626
text: string;
2727
index: number;
2828
}[];
29+
30+
errorMsg?: string;
31+
stacktrace?: string;
2932
};
3033

3134
export enum QueryResultType {

src/utils/core.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,7 @@ export async function convertBase64License(
500500
}
501501

502502
export function isTable(result: QueryResult): boolean {
503-
if (!result.result || !result.meta || result.meta.length === 0) {
503+
if (!result.data || !result.meta || result.meta.length === 0) {
504504
return false;
505505
}
506506
return true;

src/utils/queryUtils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ export function getPythonWrapper(
319319
sample_fn: "first",
320320
sample_size: 10000,
321321
};
322-
return `{[returnFormat;code;sample_fn;sample_size] res:${wrapper}[returnFormat;code;sample_fn;sample_size];$[res\`errored;res\`error;res\`result]}["${args.returnFormat}";"${args.code}";"${args.sample_fn}";${args.sample_size}]`;
322+
return `{[returnFormat;code;sample_fn;sample_size] res:${wrapper}[returnFormat;code;sample_fn;sample_size];$[res\`error;res\`errorMsg;res\`data]}["${args.returnFormat}";"${args.code}";"${args.sample_fn}";${args.sample_size}]`;
323323
}
324324

325325
export function getQSQLWrapper(

0 commit comments

Comments
 (0)