Skip to content

Commit 7a5c24e

Browse files
authored
Merge pull request #703 from KxSystems/ee-auto
Added auto resizing for results view columns
2 parents d3eedbc + 6d4031d commit 7a5c24e

File tree

3 files changed

+40
-9
lines changed

3 files changed

+40
-9
lines changed

src/services/resultsPanelProvider.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -261,14 +261,19 @@ export class KdbResultsViewProvider implements WebviewViewProvider {
261261
const columnWidths = saveColumnWidths();
262262
const gridOptions = {
263263
defaultColDef: {
264-
sortable: true,
265264
resizable: true,
266-
filter: true,
267-
flex: 1,
268-
minWidth: 100,
265+
sortable: false,
266+
filter: false,
269267
editable: false,
268+
flex: 1,
270269
},
271270
theme: message.theme,
271+
autoSizeStrategy: {
272+
type: 'fitCellContents',
273+
defaultMinWidth: 100,
274+
defaultMaxWidth: 1000,
275+
scaleUpToFitGridWidth: true,
276+
},
272277
columnDefs: message.columnDefs,
273278
domLayout: "autoHeight",
274279
pagination: true,

src/utils/resultsRenderer.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ export function convertToGrid(
8383
field: "index",
8484
headerName: "Index",
8585
cellDataType: "number",
86+
pinned: "left",
8687
});
8788
}
8889

test/suite/webPanels/resultsPanelProvider.test.ts

Lines changed: 30 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,12 @@ describe("ResultsPanelProvider", () => {
162162
{ index: 2, prop1: "value3", prop2: "value4" },
163163
],
164164
columnDefs: [
165-
{ field: "index", headerName: "Index", cellDataType: "number" },
165+
{
166+
field: "index",
167+
headerName: "Index",
168+
cellDataType: "number",
169+
pinned: "left",
170+
},
166171
{
167172
field: "prop1",
168173
headerName: "prop1 [type1]",
@@ -205,7 +210,12 @@ describe("ResultsPanelProvider", () => {
205210
{ index: 2, prop1: "value2", prop2: "value4" },
206211
],
207212
columnDefs: [
208-
{ field: "index", headerName: "Index", cellDataType: "number" },
213+
{
214+
field: "index",
215+
headerName: "Index",
216+
cellDataType: "number",
217+
pinned: "left",
218+
},
209219
{
210220
field: "prop1",
211221
headerName: "prop1 [type1]",
@@ -236,7 +246,12 @@ describe("ResultsPanelProvider", () => {
236246
const expectedOutput = JSON.stringify({
237247
rowData: [],
238248
columnDefs: [
239-
{ field: "index", headerName: "Index", cellDataType: "number" },
249+
{
250+
field: "index",
251+
headerName: "Index",
252+
cellDataType: "number",
253+
pinned: "left",
254+
},
240255
{
241256
field: "prop1",
242257
headerName: "prop1 [type1]",
@@ -272,7 +287,12 @@ describe("ResultsPanelProvider", () => {
272287
{ index: 3, sym: "c", val: 3 },
273288
],
274289
columnDefs: [
275-
{ field: "index", headerName: "Index", cellDataType: "number" },
290+
{
291+
field: "index",
292+
headerName: "Index",
293+
cellDataType: "number",
294+
pinned: "left",
295+
},
276296
{ field: "sym", headerName: "sym [type1]", cellDataType: "text" },
277297
{ field: "val", headerName: "val [type2]", cellDataType: "text" },
278298
],
@@ -290,7 +310,12 @@ describe("ResultsPanelProvider", () => {
290310
const expectedOutput = JSON.stringify({
291311
rowData: [{ index: 1, value: "1,2,3" }],
292312
columnDefs: [
293-
{ field: "index", headerName: "Index", cellDataType: "number" },
313+
{
314+
field: "index",
315+
headerName: "Index",
316+
cellDataType: "number",
317+
pinned: "left",
318+
},
294319
{
295320
field: "value",
296321
headerName: "value [type1]",

0 commit comments

Comments
 (0)