upgrade env

Author: Kyonru

.github/workflows/cli.yml

@@ -23,26 +23,40 @@ jobs:
       - name: Install dependencies
         run: npm ci
 
-      - name: Build CLI
+      - name: Build CLI (local)
         run: npm run build:cli
 
       - name: Install Chrome system dependencies
         run: |
           sudo apt-get update -y
           sudo apt-get install -y libgbm1
 
-      - name: Download test model
+      - name: Smoke test — spritesheet
+        run: npm run cli -- example.fbx --format spritesheet --frames 4 --width 64
+          --height 64 --output ./sprite-sheet-test
+
+      - name: Verify output
         run: |
-          curl -fsSL \
-            "https://raw.githubusercontent.com/KhronosGroup/glTF-Sample-Models/main/2.0/Box/glTF-Binary/Box.glb" \
-            -o test.glb
+          test -f ./sprite-sheet-test/spritesheet.png || (echo "spritesheet.png not found" && exit 1)
+          echo "Output files:"
+          ls ./sprite-sheet-test/
 
-      - name: Smoke test — spritesheet
-        run: node ./dist/cli/index.js test.glb --format spritesheet --frames 4 --width
-          64 --height 64 --output ./test-out
+      - name: Smoke test — Love2d
+        run: npm run cli -- example.fbx --format love2d --frames 4 --width 64 --height
+          64 --output ./love2d-test
+
+      - name: Verify output
+        run: |
+          test -f ./love2d-test/spritesheet.lua || (echo "spritesheet.lua not found" && exit 1)
+          echo "Output files:"
+          ls ./love2d-test/
+
+      - name: SmokeTest - Workflow
+        run: npm run cli -- example.fbx --workflow platformer --cameraDistance 2.5
+          --output ./workflow-test
 
       - name: Verify output
         run: |
-          test -f ./test-out/spritesheet.png || (echo "spritesheet.png not found" && exit 1)
+          test -f ./workflow-test/spritesheet.png || (echo "spritesheet.png not found" && exit 1)
           echo "Output files:"
-          ls ./test-out/
+          ls ./workflow-test/

cli/browser.ts

@@ -27,11 +27,19 @@ export async function openPage(browser: Browser, port: number): Promise<Page> {
     if (msg.type() === "error") console.error(`[browser] ${text}`);
     else console.log(`[browser] ${text}`);
   });
-  page.on("pageerror", (err) => console.error(`[browser:pageerror] ${err.message}`));
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  page.on("pageerror", (err: any) =>
+    console.error(`[browser:pageerror] ${err.message}`),
+  );
 
-  await page.goto(`http://localhost:${port}`, { waitUntil: "networkidle0", timeout: 30000 });
+  await page.goto(`http://localhost:${port}`, {
+    waitUntil: "networkidle0",
+    timeout: 30000,
+  });
 
-  await page.waitForFunction(() => "__SSH_BRIDGE__" in window, { timeout: 15000 });
+  await page.waitForFunction(() => "__SSH_BRIDGE__" in window, {
+    timeout: 15000,
+  });
 
   return page;
 }

cli/index.ts

@@ -160,9 +160,21 @@ async function main() {
     );
     for (const f of files) console.log(`  ${f}`);
   } finally {
-    await browser?.close();
-    if (serverProc) stopServer(serverProc);
+    try {
+      await browser?.close();
+    } catch {
+      // Browser might already be closed
+      console.log("[sprite-sheet-helper] Browser already closed");
+    }
+    if (serverProc) {
+      stopServer(serverProc);
+      // Give server time to shut down
+      await new Promise((r) => setTimeout(r, 100));
+      console.log("[sprite-sheet-helper] Server stopped");
+    }
   }
+
+  process.exit(0);
 }
 
 main().catch((err: Error) => {

cli/inject.ts

@@ -12,7 +12,6 @@ export async function injectModel(
   const bytes = await readFile(modelPath);
   const base64 = bytes.toString("base64");
   const fileName = basename(modelPath);
-  console.log(`[sprite-sheet-helper] File name: ${fileName}`);
 
   const uuid = await page.evaluate(
     async (b64: string, name: string) => {
@@ -21,15 +20,12 @@ export async function injectModel(
 
       const bytes = Uint8Array.from(atob(b64), (c) => c.charCodeAt(0));
       const file = new File([bytes], name);
-      console.log("Injecting model passed: file", name);
 
       const uuid = bridge.stores.entities.getState().addEntity("model", name);
       bridge.stores.transforms
         .getState()
         .initTransform(uuid, { position: [0, 0.8, 0] });
 
-      console.log("Injected model passed: uuid", uuid);
-
       // const label = name ?? file.name ?? "Model";
       // const uuid = addEntity("model", label);
 
@@ -50,11 +46,8 @@ export async function injectModel(
 
       try {
         await bridge.stores.models.getState().loadFromFile(uuid, file);
-        console.log("Injected model passed: loadFromFile", uuid);
         bridge.stores.entities.getState().selectEntity(uuid);
-        console.log("Injected model passed: selectEntity", uuid);
       } catch (err) {
-        console.log("Injected model passed: loadFromFile failed", err);
         throw new Error(
           `loadFromFile failed: ${(err as Error)?.message ?? err}`,
         );
@@ -66,8 +59,6 @@ export async function injectModel(
     fileName,
   );
 
-  console.log(`[sprite-sheet-helper] uuid: ${uuid}`);
-
   // Wait for the React component to emit MODEL_READY event
   await page.evaluate((id: string) => {
     return new Promise<void>((resolve) => {