api: Add 'Builder' suffix to Component factory methods that return a builder #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashike
reviewed
Dec 10, 2020
kashike
approved these changes
Dec 10, 2020
lucko
requested changes
Dec 10, 2020
There was a problem hiding this comment.
I've put my comments re: this change on the original issue: #222 (comment)
I'm against merging this as-is.
|
Due to opposition and several proposed alternatives, I'm going to close this PR. If the issue is ever revisited, any other approach would effectively be starting from scratch anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #222, see there for discussion on the concept