Skip to content

Commit 7460630

Browse files
authored
Use more granular latency buckets for spring commands (beyond-all-reason#907)
Bucket sizes are most often subsequent powers of some base number, depending on required granularity in 1.2-4 range. Current buckets have some large gaps at the low end, then switch to someting like 2x and then I think 1000 is too little. In this change I'm using fibonacci numbers which is roughly ~1.6 base and have an overall nice progression. For the latency range we are interested in it's still only 18 buckets, so it's totally fine from cardinality perspective, we can even push it further if needed.
1 parent 8a328a3 commit 7460630

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

lib/teiserver/telemetry/libs/telemetry_lib.ex

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ defmodule Teiserver.Telemetry.TelemetryLib do
7777
event_name: [:spring, :in],
7878
measurement: :duration,
7979
reporter_options: [
80-
buckets: [1, 10, 50, 100, 150, 250, 500, 1_000]
80+
buckets: [1, 2, 3, 5, 8, 13, 21, 34, 55, 89, 144, 233, 377, 610, 987, 1597, 2584, 4181]
8181
],
8282
tags: [:command]
8383
),
@@ -86,7 +86,7 @@ defmodule Teiserver.Telemetry.TelemetryLib do
8686
event_name: [:spring, :out],
8787
measurement: :duration,
8888
reporter_options: [
89-
buckets: [1, 10, 50, 100, 150, 250, 500, 1_000]
89+
buckets: [1, 2, 3, 5, 8, 13, 21, 34, 55, 89, 144, 233, 377, 610, 987, 1597, 2584, 4181]
9090
],
9191
tags: [:command]
9292
),

0 commit comments

Comments
 (0)