Skip to content

Commit fa5331a

Browse files
authored
Fixed a bug where the Spack install flags (such as --test root) were not passed to the install command. (#1873)
1 parent cf86192 commit fa5331a

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

scripts/build_lbann.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ DRY_RUN=
2424
CLEAN_BUILD=
2525
# Flag for passing subcommands to spack dev-build
2626
DEV_BUILD_FLAGS=
27-
# Flag for passing subcommands to spack install and dev-build
28-
INSTALL_DEV_BUILD_EXTRAS=
27+
# Flag for passing subcommands to spack install
28+
INSTALL_BUILD_EXTRAS=
2929

3030
LBANN_VARIANTS=
3131
CMD_LINE_VARIANTS=
@@ -169,7 +169,7 @@ while :; do
169169
DIHYDROGEN_VER=
170170
;;
171171
--test)
172-
INSTALL_DEV_BUILD_EXTRAS="--test root"
172+
INSTALL_BUILD_EXTRAS="--test root"
173173
;;
174174
--hydrogen-repo)
175175
if [ -n "${2}" ]; then
@@ -718,7 +718,7 @@ fi
718718

719719
##########################################################################################
720720
# Actually install LBANN from local source
721-
CMD="spack install ${BUILD_JOBS}"
721+
CMD="spack install ${BUILD_JOBS} ${INSTALL_BUILD_EXTRAS}"
722722
echo ${CMD} | tee -a ${LOG}
723723
[[ -z "${DRY_RUN:-}" ]] && { ${CMD} || exit_on_failure "${CMD}"; }
724724

0 commit comments

Comments
 (0)