Skip to content

Commit c8dbd37

Browse files
committed
Fix naked returns
1 parent b2855ad commit c8dbd37

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

upnp.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -69,18 +69,18 @@ type upnpNAT struct {
6969
func Discover() (nat NAT, err error) {
7070
ssdp, err := net.ResolveUDPAddr("udp4", "239.255.255.250:1900")
7171
if err != nil {
72-
return
72+
return nil, err
7373
}
7474
conn, err := net.ListenPacket("udp4", ":0")
7575
if err != nil {
76-
return
76+
return nil, err
7777
}
7878
socket := conn.(*net.UDPConn)
7979
defer socket.Close()
8080

8181
err = socket.SetDeadline(time.Now().Add(3 * time.Second))
8282
if err != nil {
83-
return
83+
return nil, err
8484
}
8585

8686
st := "ST: urn:schemas-upnp-org:device:InternetGatewayDevice:1\r\n"
@@ -236,17 +236,17 @@ func getOurIP(serviceIP string) (ip string, err error) {
236236
func getServiceURL(rootURL string) (url string, err error) {
237237
r, err := http.Get(rootURL)
238238
if err != nil {
239-
return
239+
return '', err
240240
}
241241
defer r.Body.Close()
242242
if r.StatusCode >= 400 {
243243
err = errors.New(fmt.Sprint(r.StatusCode))
244-
return
244+
return '', err
245245
}
246246
var root root
247247
err = xml.NewDecoder(r.Body).Decode(&root)
248248
if err != nil {
249-
return
249+
return '', err
250250
}
251251
a := &root.Device
252252
if a.DeviceType != "urn:schemas-upnp-org:device:InternetGatewayDevice:1" {
@@ -325,7 +325,7 @@ func soapRequest(url, function, message string) (replyXML []byte, err error) {
325325
if r.StatusCode >= 400 {
326326
err = errors.New("Error " + strconv.Itoa(r.StatusCode) + " for " + function)
327327
r = nil
328-
return
328+
return nil, err
329329
}
330330
var reply soapEnvelope
331331
err = xml.NewDecoder(r.Body).Decode(&reply)

0 commit comments

Comments
 (0)