Added nil check gaurd to SetAuditors

Signed-off-by: Effi-S <effi.szt@gmail.com>

Author: Effi-S

cmd/tokengen/cobra/pp/zkatdlognoghv1/update.go

@@ -99,7 +99,9 @@ func Update(args *UpdateArgs) error {
 	// Clear auditor and issuers if provided, and add them again.
 	// If not provided, do not change them.
 	if len(args.Auditors) > 0 {
-		pp.SetAuditors(nil)
+		if err := pp.SetAuditors(nil); err != nil {
+			return errors.Wrapf(err, "failed to clear auditors")
+		}
 	}
 	if len(args.Issuers) > 0 {
 		pp.SetIssuers(nil)

integration/token/fungible/support.go

@@ -1855,7 +1855,7 @@ func PrepareUpdatedPublicParams(network *integration.Infrastructure, auditor str
 		Validate() error
 		Serialize() ([]byte, error)
 		SetIssuers(identities []driver.Identity)
-		SetAuditors(identities []driver.Identity)
+		SetAuditors(identities []driver.Identity) error
 		AddAuditor(identity2 driver.Identity)
 		AddIssuer(identity2 driver.Identity)
 	}
@@ -1876,7 +1876,7 @@ func PrepareUpdatedPublicParams(network *integration.Infrastructure, auditor str
 		pp.AddAuditor(auditorId)
 		pp.AddIssuer(issuerId)
 	} else {
-		pp.SetAuditors([]driver.Identity{auditorId})
+		gomega.Expect(pp.SetAuditors([]driver.Identity{auditorId})).NotTo(gomega.HaveOccurred())
 		pp.SetIssuers([]driver.Identity{issuerId})
 	}
 

token/core/fabtoken/v1/setup/setup.go

@@ -225,9 +225,15 @@ func (p *PublicParams) SetIssuers(ids []driver.Identity) {
 	p.IssuerIDs = ids
 }
 
-// SetAuditors sets the auditors to the passed identities
-func (p *PublicParams) SetAuditors(ids []driver.Identity) {
+// SetAuditors sets the auditor to the first of the passed identities.
+// fabtoken supports a single auditor, so it uses ids[0] and ignores the rest.
+// It returns an error if ids is empty or nil, leaving the current auditor untouched.
+func (p *PublicParams) SetAuditors(ids []driver.Identity) error {
+	if len(ids) == 0 {
+		return errors.New("no auditor identities provided")
+	}
 	p.Auditor = ids[0]
+	return nil
 }
 
 // Auditors returns the list of authorized auditors

token/core/fabtoken/v1/setup/setup_test.go

@@ -119,7 +119,13 @@ func TestPublicParams_Methods(t *testing.T) {
 
 		// Test SetAuditors
 		newAuditor := driver.Identity([]byte("auditor2"))
-		pp.SetAuditors([]driver.Identity{newAuditor})
+		assert.NoError(t, pp.SetAuditors([]driver.Identity{newAuditor}))
+		assert.Equal(t, newAuditor, pp.AuditorIdentity())
+
+		// Test SetAuditors with an empty/nil slice returns an error and leaves
+		// the current auditor untouched (guards against the index-out-of-range panic).
+		assert.Error(t, pp.SetAuditors(nil))
+		assert.Error(t, pp.SetAuditors([]driver.Identity{}))
 		assert.Equal(t, newAuditor, pp.AuditorIdentity())
 	})
 
@@ -730,7 +736,7 @@ func TestPublicParams_SettersWithMultipleValues(t *testing.T) {
 		[]byte("auditor1"),
 		[]byte("auditor2"),
 	}
-	pp.SetAuditors(auditors)
+	assert.NoError(t, pp.SetAuditors(auditors))
 	assert.Equal(t, driver.Identity([]byte("auditor1")), pp.AuditorIdentity())
 	assert.Equal(t, []driver.Identity{driver.Identity([]byte("auditor1"))}, pp.Auditors())
 }

token/core/zkatdlog/nogh/v1/setup/setup.go

@@ -620,9 +620,12 @@ func (p *PublicParams) SetIssuers(ids []driver.Identity) {
 	p.IssuerIDs = ids
 }
 
-// SetAuditors sets the auditors to the passed identities
-func (p *PublicParams) SetAuditors(ids []driver.Identity) {
+// SetAuditors sets the auditors to the passed identities.
+// zkatdlog supports a list of auditors, so an empty or nil slice simply clears it.
+// It always returns a nil error; the signature matches the shared setter contract.
+func (p *PublicParams) SetAuditors(ids []driver.Identity) error {
 	p.AuditorIDs = ids
+	return nil
 }
 
 func (p *PublicParams) ComputeHash() ([]byte, error) {

token/core/zkatdlog/nogh/v1/setup/setup_test.go

@@ -289,9 +289,14 @@ func TestPublicParamsModification(t *testing.T) {
 
 	// Test SetAuditors
 	newAuditors := []driver.Identity{driver.Identity("newAuditor")}
-	pp.SetAuditors(newAuditors)
+	assert.NoError(t, pp.SetAuditors(newAuditors))
 	assert.Equal(t, newAuditors, pp.Auditors())
 
+	// zkatdlog supports a list of auditors, so an empty/nil slice clears them
+	// without error (unlike fabtoken's single-auditor setter).
+	assert.NoError(t, pp.SetAuditors(nil))
+	assert.Empty(t, pp.Auditors())
+
 	// Test AddIssuer
 	issuer1 := driver.Identity("issuer1")
 	issuer2 := driver.Identity("issuer2")