Skip to content

Commit 88bdcba

Browse files
author
Hayim.Shaul@ibm.com
committed
fix unit tests
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe03.vpc.cloud9.ibm.com>
1 parent 6055b06 commit 88bdcba

22 files changed

Lines changed: 128 additions & 112 deletions

File tree

token/sdk/dig/sdk.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,13 +137,15 @@ func (p *SDK) Install() error {
137137
p.Container().Provide(digutils.Identity[*ftscore.TMSProvider](), dig.As(new(ftsdriver.TokenManagerServiceProvider))),
138138
p.Container().Provide(tms.NewPostInitializer),
139139

140-
p.Container().Provide(func(ttxStoreServiceManager ttxdb.StoreServiceManager, configService fscconfig.ConfigService) *network2.LockerProvider {
140+
p.Container().Provide(func(ttxStoreServiceManager ttxdb.StoreServiceManager, configService driver.ConfigService) *network2.LockerProvider {
141141
cfg, err := config.New(configService)
142142
if err != nil {
143143
logging.MustGetLogger().Errorf("error getting selector config for locker, using defaults: %s", err.Error())
144+
144145
return network2.NewLockerProvider(ttxStoreServiceManager, 2*time.Second, 5*time.Minute)
145146
}
146147
limits := cfg.GetLimits()
148+
147149
return network2.NewLockerProviderWithLimits(ttxStoreServiceManager, 2*time.Second, 5*time.Minute, limits.MaxLocksPerTransaction)
148150
}, dig.As(new(simple.LockerProvider))),
149151
p.Container().Provide(selectorProviders[sdriver.Driver(p.ConfigService().GetString("token.selector.driver"))], dig.As(new(token.SelectorManagerProvider))),

token/sdk/vault/vault.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,12 @@ func (q *QueryEngine) IsMine(ctx context.Context, id *token.ID) (bool, error) {
9292
return q.StoreService.IsMine(ctx, id.TxId, id.Index)
9393
}
9494

95+
// UnspentTokensIteratorBy returns an iterator over unspent tokens owned by a wallet and optionally limited in size.
96+
func (q *QueryEngine) UnspentTokensIteratorBy(ctx context.Context, id string, tokenType token.Type, limit int) (driver.UnspentTokensIterator, error) {
97+
return q.StoreService.UnspentTokensIteratorBy(ctx, id, tokenType, limit)
98+
}
99+
100+
95101
// CertificationStorage manages token certifications in the database.
96102
type CertificationStorage struct {
97103
*tokendb.StoreService

token/services/identity/role/mock/otv.go

Lines changed: 10 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

token/services/identity/role/mock/tv.go

Lines changed: 10 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

token/services/identity/role/wallets.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ type UnspentTokensIterator = driver.UnspentTokensIterator
3434
//
3535
//go:generate counterfeiter -o mock/otv.go -fake-name OwnerTokenVault . OwnerTokenVault
3636
type OwnerTokenVault interface {
37-
UnspentTokensIteratorBy(ctx context.Context, id string, tokenType token.Type) (UnspentTokensIterator, error)
37+
UnspentTokensIteratorBy(ctx context.Context, id string, tokenType token.Type, limit int) (UnspentTokensIterator, error)
3838
Balance(ctx context.Context, id string, tokenType token.Type) (*big.Int, error)
3939
}
4040

@@ -366,7 +366,7 @@ func (w *LongTermOwnerWallet) GetSigner(ctx context.Context, identity Identity)
366366
// ListTokens returns all unspent tokens for the wallet matching the
367367
// provided listing options.
368368
func (w *LongTermOwnerWallet) ListTokens(ctx context.Context, opts *driver.ListTokensOptions) (*token.UnspentTokens, error) {
369-
it, err := w.TokenVault.UnspentTokensIteratorBy(ctx, w.WalletID, opts.TokenType)
369+
it, err := w.TokenVault.UnspentTokensIteratorBy(ctx, w.WalletID, opts.TokenType, 0)
370370
if err != nil {
371371
return nil, errors.Wrap(err, "token selection failed")
372372
}
@@ -393,7 +393,7 @@ func (w *LongTermOwnerWallet) Balance(ctx context.Context, opts *driver.ListToke
393393
// ListTokensIterator returns an iterator to scan unspent tokens instead of
394394
// materializing them in memory.
395395
func (w *LongTermOwnerWallet) ListTokensIterator(ctx context.Context, opts *driver.ListTokensOptions) (driver.UnspentTokensIterator, error) {
396-
it, err := w.TokenVault.UnspentTokensIteratorBy(ctx, w.WalletID, opts.TokenType)
396+
it, err := w.TokenVault.UnspentTokensIteratorBy(ctx, w.WalletID, opts.TokenType, 0)
397397
if err != nil {
398398
return nil, errors.Wrap(err, "token selection failed")
399399
}

token/services/identity/role/wfactory.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import (
2020

2121
//go:generate counterfeiter -o mock/tv.go -fake-name TokenVault . TokenVault
2222
type TokenVault interface {
23-
UnspentTokensIteratorBy(ctx context.Context, id string, tokenType token.Type) (driver.UnspentTokensIterator, error)
23+
UnspentTokensIteratorBy(ctx context.Context, id string, tokenType token.Type, limit int) (driver.UnspentTokensIterator, error)
2424
ListHistoryIssuedTokens(ctx context.Context) (*token.IssuedTokens, error)
2525
Balance(ctx context.Context, id string, tokenType token.Type) (*big.Int, error)
2626
}

token/services/interop/htlc/wallet.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ type Vault interface {
2626

2727
type QueryEngine interface {
2828
// UnspentTokensIteratorBy returns an iterator over all unspent tokens by type and id. Type can be empty
29-
UnspentTokensIteratorBy(ctx context.Context, id string, tokenType token2.Type) (driver.UnspentTokensIterator, error)
29+
UnspentTokensIteratorBy(ctx context.Context, id string, tokenType token2.Type, limit int) (driver.UnspentTokensIterator, error)
3030
}
3131

3232
type TokenVault interface {
@@ -255,7 +255,7 @@ func (w *OwnerWallet) filterIterator(ctx context.Context, tokenType token2.Type,
255255
} else {
256256
walletID = recipientWallet(ctx, w.wallet)
257257
}
258-
it, err := w.queryEngine.UnspentTokensIteratorBy(ctx, walletID, tokenType)
258+
it, err := w.queryEngine.UnspentTokensIteratorBy(ctx, walletID, tokenType, 0)
259259
if err != nil {
260260
return nil, errors.WithMessagef(err, "failed to get iterator over unspent tokens")
261261
}

token/services/nfttx/filter.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ type Filter interface {
2424

2525
type QueryService interface {
2626
UnspentTokensIterator(ctx context.Context) (*token.UnspentTokensIterator, error)
27-
UnspentTokensIteratorBy(ctx context.Context, id string, tokenType token2.Type) (driver.UnspentTokensIterator, error)
27+
UnspentTokensIteratorBy(ctx context.Context, id string, tokenType token2.Type, limit int) (driver.UnspentTokensIterator, error)
2828
GetTokens(ctx context.Context, inputs ...*token2.ID) ([]*token2.Token, error)
2929
}
3030

@@ -62,7 +62,7 @@ func (s *filter) selectByFilter(ctx context.Context, filter Filter, q string) ([
6262
return nil, nil, errors.Wrap(err, "failed to convert quantity")
6363
}
6464

65-
unspentTokens, err := s.queryService.UnspentTokensIteratorBy(ctx, s.wallet, "")
65+
unspentTokens, err := s.queryService.UnspentTokensIteratorBy(ctx, s.wallet, "", 0)
6666
if err != nil {
6767
return nil, nil, errors.Wrap(err, "token selection failed")
6868
}

token/services/nfttx/mock/query_service.go

Lines changed: 10 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

token/services/selector/benchmark_test.go

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,18 @@ func NewSelector(qs *testutils.MockQueryService, walletIDByRawIdentity WalletIDB
167167
return qs
168168
}
169169

170-
s, _ := selector.NewManager(lock, qf, testutils.SelectorNumRetries, testutils.SelectorTimeout, false, testutils.TokenQuantityPrecision).NewSelector(testutils.TxID)
170+
s, _ := selector.NewManager(
171+
lock,
172+
qf,
173+
testutils.SelectorNumRetries,
174+
testutils.SelectorTimeout,
175+
false,
176+
testutils.TokenQuantityPrecision,
177+
0,
178+
0,
179+
0,
180+
0,
181+
).NewSelector(testutils.TxID)
171182

172183
return &extendedSelector{
173184
Selector: s,

0 commit comments

Comments
 (0)