You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Browse filesBrowse the repository at this point in the historyBrowse files
Hayim.Shaul@ibm.com
committed
docs: document exported metric names and coverage gaps
The SDK never spells out the metric names Prometheus exports. The
fully-qualified name is assembled at registration time from the Go package
of the caller, and the TMS-scoped provider in token/core/common/metrics adds
a stack frame, so metrics created through it are exported under that
package rather than their own. Documentation written from the bare Name
field of the options therefore lists names no query matches.
Add docs/development/metrics.md: the derivation rules, every metric under
the name Prometheus actually serves, its type, labels, meaning and source,
example queries, and a ranked analysis of what a node still cannot report.
Guard the page with token/services/metricsdoc, which instantiates every
metrics constructor the way production wires it, reads the resulting names
back out of a Prometheus registry, and compares them against a golden file
and against the page itself. Renaming, adding or relocating a metric fails
the test until the documentation is updated.
Export NewMetrics/NewClientMetrics in the auditor, certification and
Fabric-X queue packages so the guard can build their instrumentation
without constructing the surrounding service.
Correct docs/drivers/metrics.md, which listed declared names as if they
were queryable, and make docs/development/monitoring.md the entry point.
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe03.vpc.cloud9.ibm.com>
Copy file name to clipboardExpand all lines: docs/development/monitoring.md
+10Lines changed: 10 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -5,3 +5,13 @@ We adopt the monitoring infrastructure provided by the [`Fabric Smart Client`](h
5
5
We use the following two methods to monitor the performance of the application:
6
6
***Metrics** provide an overview of the overall system performance using aggregated results, e.g. total requests, requests per second, current state of a variable, average duration, percentile of duration
7
7
***Traces** help us analyze single requests by breaking down their lifecycles into smaller components
8
+
9
+
## Where to look next
10
+
11
+
*[Metrics Reference](./metrics.md) — every metric Panurus exports, under the exact name Prometheus
12
+
serves it, plus how those names are derived, example queries, and the current coverage gaps.
13
+
*[Driver Metrics](../drivers/metrics.md) — how the driver service wrappers are built and which
0 commit comments