Skip to content

Commit cd7e7a4

Browse files
authored
network service/fabric: remove RWSetProcessor #1199 (#1200)
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
1 parent 08731b2 commit cd7e7a4

2 files changed

Lines changed: 15 additions & 140 deletions

File tree

token/services/network/fabric/network.go

Lines changed: 15 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import (
2525
"github.com/hyperledger-labs/fabric-token-sdk/token/services/network/fabric/endorsement"
2626
"github.com/hyperledger-labs/fabric-token-sdk/token/services/network/fabric/finality"
2727
"github.com/hyperledger-labs/fabric-token-sdk/token/services/network/fabric/lookup"
28-
tokens2 "github.com/hyperledger-labs/fabric-token-sdk/token/services/tokens"
28+
"github.com/hyperledger-labs/fabric-token-sdk/token/services/tokens"
2929
"github.com/hyperledger-labs/fabric-token-sdk/token/services/ttx"
3030
"github.com/hyperledger-labs/fabric-token-sdk/token/services/utils"
3131
"github.com/hyperledger-labs/fabric-token-sdk/token/token"
@@ -41,6 +41,9 @@ const (
4141

4242
var logger = logging.MustGetLogger()
4343

44+
type GetTokensFunc = func() (*tokens.Service, error)
45+
type GetTMSProviderFunc = func() *token2.ManagementServiceProvider
46+
4447
type lm struct {
4548
lm *fabric.LocalMembership
4649
}
@@ -123,7 +126,7 @@ type Network struct {
123126
ledger *ledger
124127
configuration common2.Configuration
125128
filterProvider common2.TransactionFilterProvider[*common2.AcceptTxInDBsFilter]
126-
tokensProvider *tokens2.ServiceManager
129+
tokensProvider *tokens.ServiceManager
127130
finalityTracer trace.Tracer
128131

129132
setupListenerProvider SetupListenerProvider
@@ -141,7 +144,7 @@ func NewNetwork(
141144
ch *fabric.Channel,
142145
configuration common2.Configuration,
143146
filterProvider common2.TransactionFilterProvider[*common2.AcceptTxInDBsFilter],
144-
tokensProvider *tokens2.ServiceManager,
147+
tokensProvider *tokens.ServiceManager,
145148
viewManager ViewManager,
146149
tmsProvider *token2.ManagementServiceProvider,
147150
endorsementServiceProvider EndorsementServiceProvider,
@@ -226,38 +229,12 @@ func (n *Network) Connect(ns string) ([]token2.ServiceOption, error) {
226229
Namespace: ns,
227230
}
228231

229-
if n.llm.PermanentLookupListenerSupported() {
230-
setUpKey, err := n.keyTranslator.CreateSetupKey()
231-
if err != nil {
232-
return nil, errors.Errorf("failed creating setup key")
233-
}
234-
if err := n.llm.AddPermanentLookupListener(ns, setUpKey, n.setupListenerProvider.GetListener(tmsID)); err != nil {
235-
return nil, errors.Errorf("failed adding setup key listener")
236-
}
237-
} else {
238-
if err := n.n.ProcessorManager().AddProcessor(
239-
ns,
240-
NewTokenRWSetProcessor(
241-
n.Name(),
242-
ns,
243-
lazy.NewGetter[*tokens2.Service](func() (*tokens2.Service, error) {
244-
return n.tokensProvider.ServiceByTMSId(tmsID)
245-
}).Get,
246-
func() *token2.ManagementServiceProvider {
247-
return n.tmsProvider
248-
},
249-
n.keyTranslator,
250-
)); err != nil {
251-
return nil, errors.WithMessagef(err, "failed to add processor to fabric network [%s]", n.n.Name())
252-
}
253-
transactionFilter, err := n.filterProvider.New(tmsID)
254-
if err != nil {
255-
return nil, errors.WithMessagef(err, "failed to create transaction filter for [%s]", tmsID)
256-
}
257-
committer := n.ch.Committer()
258-
if err := committer.AddTransactionFilter(transactionFilter); err != nil {
259-
return nil, errors.WithMessagef(err, "failed to fetch attach transaction filter [%s]", tmsID)
260-
}
232+
setUpKey, err := n.keyTranslator.CreateSetupKey()
233+
if err != nil {
234+
return nil, errors.Errorf("failed creating setup key")
235+
}
236+
if err := n.llm.AddPermanentLookupListener(ns, setUpKey, n.setupListenerProvider.GetListener(tmsID)); err != nil {
237+
return nil, errors.Errorf("failed adding setup key listener")
261238
}
262239

263240
// Let the endorsement service initialize itself, if needed
@@ -388,7 +365,7 @@ func waitTimeout(wg *sync.WaitGroup, timeout time.Duration) error {
388365
}
389366
}
390367

391-
func NewSetupListenerProvider(tmsProvider *token2.ManagementServiceProvider, tokensProvider *tokens2.ServiceManager) *setupListenerProvider {
368+
func NewSetupListenerProvider(tmsProvider *token2.ManagementServiceProvider, tokensProvider *tokens.ServiceManager) *setupListenerProvider {
392369
return &setupListenerProvider{
393370
tmsProvider: tmsProvider,
394371
tokensProvider: tokensProvider,
@@ -397,13 +374,13 @@ func NewSetupListenerProvider(tmsProvider *token2.ManagementServiceProvider, tok
397374

398375
type setupListenerProvider struct {
399376
tmsProvider *token2.ManagementServiceProvider
400-
tokensProvider *tokens2.ServiceManager
377+
tokensProvider *tokens.ServiceManager
401378
}
402379

403380
func (p *setupListenerProvider) GetListener(tmsID token2.TMSID) lookup.Listener {
404381
return &setupListener{
405382
GetTMSProvider: func() *token2.ManagementServiceProvider { return p.tmsProvider },
406-
GetTokens: lazy.NewGetter[*tokens2.Service](func() (*tokens2.Service, error) {
383+
GetTokens: lazy.NewGetter[*tokens.Service](func() (*tokens.Service, error) {
407384
return p.tokensProvider.ServiceByTMSId(tmsID)
408385
}).Get,
409386
TMSID: tmsID,

token/services/network/fabric/processor.go

Lines changed: 0 additions & 102 deletions
This file was deleted.

0 commit comments

Comments
 (0)