fix linter

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

Author: adecaro

integration/nwo/token/common/utils.go

@@ -22,7 +22,7 @@ const (
 )
 
 func pathExists(path string) bool {
-	if _, err := os.Stat(path); os.IsNotExist(err) {
+	if _, err := os.Stat(path); os.IsNotExist(err) { //nolint:gosec
 		return false
 	}
 

integration/nwo/txgen/model/config.go

@@ -42,7 +42,7 @@ type UserAlias = string
 type UserConfig struct {
 	Name     UserAlias `json:"name"     yaml:"name"`
 	Username Username  `json:"username" yaml:"username"`
-	Password string    `json:"password" yaml:"password"`
+	Password string    `json:"password" yaml:"password"` //nolint:gosec
 	Endpoint string    `json:"endpoint" yaml:"endpoint"`
 }
 

integration/nwo/txgen/service/metrics/reporter.go

@@ -59,14 +59,14 @@ func (c *reporter) Summary() string {
 	b := strings.Builder{}
 
 	if c.RequestsSent.(gettable).Get() != 0 {
-		b.WriteString(fmt.Sprintf("Total requests %d, average duration of the request %v\n",
+		fmt.Fprintf(&b, "Total requests %d, average duration of the request %v\n",
 			int(c.RequestsSent.(gettable).Get()),
-			time.Duration(c.RequestDuration.(retrievable).Avg())))
-		b.WriteString(fmt.Sprintf("Success ratio %.2f%%\n",
-			c.RequestsReceived.(gettable).Get()/c.RequestsSent.(gettable).Get()*100))
-		b.WriteString(fmt.Sprintf("Minimum request took %v, maximum %v\n",
+			time.Duration(c.RequestDuration.(retrievable).Avg()))
+		fmt.Fprintf(&b, "Success ratio %.2f%%\n",
+			c.RequestsReceived.(gettable).Get()/c.RequestsSent.(gettable).Get()*100)
+		fmt.Fprintf(&b, "Minimum request took %v, maximum %v\n",
 			time.Duration(c.RequestDuration.(retrievable).Min()),
-			time.Duration(c.RequestDuration.(retrievable).Max())))
+			time.Duration(c.RequestDuration.(retrievable).Max()))
 	}
 
 	return b.String()

integration/nwo/txgen/service/user/rest/intermediary_api.go

@@ -8,7 +8,7 @@ package rest
 
 type LoginRequest struct {
 	Username string `json:"username"`
-	Password string `json:"password"`
+	Password string `json:"password"` //nolint:gosec
 }
 
 type LoginResponse struct {

integration/nwo/txgen/service/user/rest/user.go

@@ -173,7 +173,7 @@ func (u *restUser) doRequest(request *http.Request, requestType c.ApiRequestType
 		With(metrics.OperationLabel, operationType).Add(1)
 
 	start := time.Now()
-	response, err := u.httpClient.Do(request)
+	response, err := u.httpClient.Do(request) //nolint:gosec
 
 	successType := metrics.SuccessValues[err == nil || response != nil && response.StatusCode >= http.StatusBadRequest]
 	u.metrics.RequestsReceived.

token/core/zkatdlog/nogh/v1/issue/issuer_test.go

@@ -232,7 +232,7 @@ func prepareZKIssue(t *testing.T, bits uint64, curveID math.CurveID, numOutputs
 func prepareInputsForZKIssue(pp *v1.PublicParams, numOutputs int) ([]*token.Metadata, []*math.G1) {
 	values := make([]uint64, numOutputs)
 	for i := range numOutputs {
-		values[i] = uint64(i*10 + 10) //nolint:gosec
+		values[i] = uint64(i*10 + 10)
 	}
 	curve := math.Curves[pp.Curve]
 	rand, _ := curve.Rand()

token/core/zkatdlog/nogh/v1/transfer/transfer_test.go

@@ -235,12 +235,12 @@ func prepareInputsForZKTransfer(pp *v1.PublicParams, numInputs int, numOutputs i
 	// prepare inputs
 	sumInputs := uint64(0)
 	for i := range numInputs {
-		v := uint64(i*10 + 500) //nolint:gosec
+		v := uint64(i*10 + 500)
 		sumInputs += v
 		inValues[i] = v
 	}
 
-	outputValue := sumInputs / uint64(numOutputs)
+	outputValue := sumInputs / uint64(numOutputs) //nolint:gosec
 	sumOutputs := uint64(0)
 	for i := range numOutputs {
 		outValues[i] = outputValue

token/core/zkatdlog/nogh/v1/transfer_test.go

@@ -169,7 +169,7 @@ func newTransferEnv(benchmarkCase *benchmark2.Case, configurations *benchmark.Se
 	for i := range benchmarkCase.NumOutputs {
 		outputs[i] = &token.Token{
 			Owner:    ownerID,
-			Quantity: token.NewQuantityFromUInt64(uint64(i*10 + 10)).Hex(), //nolint:gosec
+			Quantity: token.NewQuantityFromUInt64(uint64(i*10 + 10)).Hex(),
 			Type:     "ABC",
 		}
 	}
@@ -179,7 +179,7 @@ func newTransferEnv(benchmarkCase *benchmark2.Case, configurations *benchmark.Se
 	ids := make([]*token.ID, numInputs)
 	values := make([]uint64, numInputs)
 	for i := range numInputs {
-		values[i] = uint64(i*10 + 10) //nolint:gosec
+		values[i] = uint64(i*10 + 10)
 	}
 	baseTokens, metadata, err := v1token.GetTokensWithWitness(values, "ABC", pp.PedersenGenerators, math.Curves[pp.Curve])
 	if err != nil {

token/core/zkatdlog/nogh/v1/validator/testing/env.go

@@ -449,12 +449,12 @@ func prepareTransfer(benchCase *benchmark2.Case, pp *v1.PublicParams, signer dri
 	inValues := make([]*math.Zr, benchCase.NumInputs)
 	sumInputs := uint64(0)
 	for i := range benchCase.NumInputs {
-		v := uint64(i*10 + 500) //nolint:gosec
+		v := uint64(i*10 + 500)
 		sumInputs += v
 		inValues[i] = c.NewZrFromUint64(v)
 	}
 
-	outputValue := sumInputs / uint64(benchCase.NumOutputs)
+	outputValue := sumInputs / uint64(benchCase.NumOutputs) //nolint:gosec
 	sumOutputs := uint64(0)
 	outValues := make([]uint64, benchCase.NumOutputs)
 	for i := range benchCase.NumOutputs {

token/sdk/db/checks.go

@@ -11,9 +11,8 @@ import (
 	"github.com/hyperledger-labs/fabric-token-sdk/token/services/auditor"
 	"github.com/hyperledger-labs/fabric-token-sdk/token/services/storage/auditdb"
 	"github.com/hyperledger-labs/fabric-token-sdk/token/services/storage/db/common"
-	"github.com/hyperledger-labs/fabric-token-sdk/token/services/storage/ttxdb"
 	"github.com/hyperledger-labs/fabric-token-sdk/token/services/tokens"
-	"github.com/hyperledger-labs/fabric-token-sdk/token/services/ttx"
+	"github.com/hyperledger-labs/fabric-token-sdk/token/services/ttx/dep"
 )
 
 type AuditorCheckServiceProvider struct {
@@ -31,7 +30,7 @@ func NewAuditorCheckServiceProvider(tmsProvider common.TokenManagementServicePro
 }
 
 func (a *AuditorCheckServiceProvider) CheckService(id token.TMSID, adb *auditdb.StoreService, tdb *tokens.Service) (auditor.CheckService, error) {
-	return common.NewChecksService(append(common.NewDefaultCheckers(a.tmsProvider, a.networkProvider, adb, tdb, id), a.checkers...)), nil
+	return common.NewChecksService(append(common.NewDefaultCheckers(a.tmsProvider, a.networkProvider, adb, id), a.checkers...)), nil
 }
 
 type OwnerCheckServiceProvider struct {
@@ -48,6 +47,6 @@ func NewOwnerCheckServiceProvider(tmsProvider common.TokenManagementServiceProvi
 	}
 }
 
-func (a *OwnerCheckServiceProvider) CheckService(id token.TMSID, txdb *ttxdb.StoreService, tdb *tokens.Service) (ttx.CheckService, error) {
-	return common.NewChecksService(append(common.NewDefaultCheckers(a.tmsProvider, a.networkProvider, txdb, tdb, id), a.checkers...)), nil
+func (a *OwnerCheckServiceProvider) CheckService(id token.TMSID, adb dep.StoreService, _ dep.TokensService) (dep.CheckService, error) {
+	return common.NewChecksService(append(common.NewDefaultCheckers(a.tmsProvider, a.networkProvider, adb, id), a.checkers...)), nil
 }