Skip to content

auditor: scope the upgrade fallback's output filter by action, not ActionIndex + issuer presence #2249

Description

@EvanYan1024

Raised in the review of #2199.

extractIssueOutputs and extractTransferOutputs each number outputs by their own loop index, so issuedToEIDAndRH separates issue outputs from transfer outputs only via the len(o.Issuer) != 0 && len(o.Owner) != 0 heuristic. A request combining an upgrade issue at index 0 with a transfer at index 0 already mixes both actions' outputs in the filter; it is correct today only because no driver attaches an issuer to an owned transfer output.

Scoping the filter by the action itself rather than by ActionIndex + issuer presence would make it correct by construction.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions