fix: correct domain name after change (#809)

<!--
Thank you for your pull request. Please review the requirements below.

Bug fixes and new features should be reported on the issue tracker:
https://github.com/lif-initiative/lif-core/issues

Contributing guide:
https://github.com/lif-initiative/lif-core/blob/main/docs/CONTRIBUTING.md
Code of Conduct:
https://github.com/lif-initiative/lif-core/blob/main/CODE_OF_CONDUCT.md
-->

##### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to
[x]. -->

- [x] commit message follows commit guidelines (see
commitlint.config.mjs)
- [ ] tests are included (unit and/or integration tests)
- [ ] all tests are successful
- [x] documentation is changed or added (in /docs directory)
- [ ] code passes linting checks (`uv run ruff check`)
- [ ] code passes formatting checks (`uv run ruff format`)
- [ ] code passes type checking (`uv run ty check`)
- [ ] pre-commit hooks have been run successfully
- [ ] database schema changes: migration files created and CHANGELOG.md
updated
- [ ] API changes: base (Python code) documentation in `docs/`
      and project README updated
- [x] configuration changes: relevant folder README updated
- [ ] breaking changes: added to MIGRATION.md with upgrade instructions
      and CHANGELOG.md entry

##### Type of Change
<!-- Check all that apply -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality
      to not work as expected)
- [x] Documentation update
- [x] Infrastructure/deployment change
- [ ] Performance improvement
- [ ] Code refactoring

##### Description of Change
<!-- Provide a clear and detailed description of the change below this
comment.
Include:
- What problem does this solve?
- What is the solution?
- Are there any side effects or limitations?
- How should reviewers test this?
-->
The domain names for dev services were changed to add ".dev" in to make
clear the services are part of dev rather than demo environment. Some
URLs were not updated. This PR resolves those.

##### Related Issues
<!-- Link to related issues using #issue_number -->

Closes # [[add Github issue number]]
Resolves #802 

##### Testing
<!-- Describe the testing you've done -->

- [ ] Manual testing performed
- [ ] Automated tests added/updated
- [ ] Integration testing completed

##### Project Area(s) Affected
<!-- Check all project areas affected by this change -->

- [ ] bases/
- [ ] components/
- [ ] orchestrators/
- [ ] frontends/
- [ ] deployments/
- [x] CloudFormation/SAM templates
- [ ] Database schema
- [ ] API endpoints
- [x] Documentation
- [ ] Testing

##### Additional Notes
<!-- Any additional information that reviewers should know -->
These changes only affect deployment to AWS, so testing is limited
before merging.

Author: bjagg

.github/workflows/lif_advisor_app.yml

@@ -31,7 +31,7 @@ jobs:
     env:
       WORKING_DIR: ./frontends/lif_advisor_app
       ECR_REPOSITORY: lif/dev/lif_advisor_app
-      VITE_LIF_ADVISOR_API_URL: 'https://advisor-api.lif.unicon.net'
+      VITE_LIF_ADVISOR_API_URL: 'https://advisor-api.dev.lif.unicon.net'
     steps:
     - name: Checkout repository
       uses: actions/checkout@v4
@@ -56,7 +56,7 @@ jobs:
         aws-region: ${{ env.AWS_REGION }}
         ecr-repository: ${{ env.ECR_REPOSITORY }}
         build-args: |
-          LIF_ADVISOR_API_URL=https://advisor-api.lif.unicon.net
+          LIF_ADVISOR_API_URL=https://advisor-api.dev.lif.unicon.net
 
     - name: Update the lif-advisor-app ECS Service
       uses: ./.github/actions/update-cluster

.github/workflows/lif_mdr_frontend.yml

@@ -46,7 +46,7 @@ jobs:
       working-directory: ${{ env.WORKING_DIR }}
       run: |
         npm ci
-        echo "VITE_API_URL=https://mdr-api.${{ env.DOMAIN }}" > .env
+        echo "VITE_API_URL=https://mdr-api.${{ env.ENV_NAME }}.${{ env.DOMAIN }}" > .env
         npm run build
 
     - name: Sync to S3

cloudformation/README.md

@@ -62,8 +62,8 @@ The service.yml template supports making services public. To make a service publ
 
 1. Set `UseLbForService = true`
 2. Set `DomainNames` or `PathPattern` (for dev/demo use DomainNames)
-    * Example: `advisor.lif.unicon.net`
-    * Must be within the domain for the given env (dev - `?.lif.unicon.net`, demo - `?.demo.lif.unicon.net`)
+    * Example: `advisor.dev.lif.unicon.net`
+    * Must be within the domain for the given env (dev - `?.dev.lif.unicon.net`, demo - `?.demo.lif.unicon.net`)
 3. Set `Priority`
     * Must be a unique integer for the given env with respect to other public services
     * Look at other param files for public services (UseLbForService = true) for the env: