tidying

Author: LJ-Jenkins

R/keylist.r

@@ -82,7 +82,7 @@ is.keylist <- function(x) inherits(x, c("klist", "knlist"))
 #' @rdname keylist
 #' @export
 as.keylist <- function(x, ...) {
-  UseMethod("as.keylist", x)
+  UseMethod("as.keylist")
 }
 
 #' @rdname keylist

R/klist.r

@@ -67,7 +67,7 @@ as.klist <- function(x, ...) {
 #' @rdname klist
 #' @export
 as.klist.default <- function(x, ..., .recursive = FALSE) {
-  x <- as.list(x)
+  x <- as.list(x, ...)
   if (isTRUE(.recursive)) {
     .Call(validate_klist_list_c, x)
   } else {
@@ -110,22 +110,19 @@ print.klist <- function(x, ...) {
 
 #' @export
 "[.klist" <- function(x, i, value) {
-  x <- NextMethod()
-  .Call(if_list_force_class, x, "klist")
+  .Call(if_list_force_class, NextMethod(), "klist")
 }
 
 # this will cause setNames to change too
 
 #' @rdname klist
 #' @export
 "names<-.klist" <- function(x, value) {
-  x <- NextMethod()
-  .Call(validate_klist_node_c, x)
+  .Call(validate_klist_node_c, NextMethod())
 }
 
 #' @rdname klist
 #' @export
 c.klist <- function(...) {
-  x <- NextMethod()
-  .Call(validate_klist_node_c, as.list(x))
+  .Call(validate_klist_node_c, NextMethod())
 }

R/knlist.r

@@ -120,8 +120,7 @@ stop_non_chr_assignment <- function(i) {
 
 #' @export
 "[.knlist" <- function(x, i, value) {
-  x <- NextMethod()
-  .Call(if_list_force_class, x, "knlist")
+  .Call(if_list_force_class, NextMethod(), "knlist")
 }
 
 #' @export
@@ -144,13 +143,11 @@ stop_non_chr_assignment <- function(i) {
   if (is.null(value)) {
     stop("Names cannot be removed from a knlist object.")
   }
-  x <- NextMethod()
-  .Call(validate_knlist_node_c, x)
+  .Call(validate_knlist_node_c, NextMethod())
 }
 
 #' @rdname knlist
 #' @export
 c.knlist <- function(...) {
-  x <- NextMethod()
-  .Call(validate_knlist_node_c, as.list(x))
+  .Call(validate_knlist_node_c, NextMethod())
 }