Skip to content

Fortran test does not validate correctness #179

Open
@lindstro

Description

As identified in #163, the lone Fortran test does not actually ensure that the data is correctly compressed or decompressed. It also has other shortcomings:

  • The array being compressed is composed of 32-bit integers, but zFORp_stream_set_rate() is called with zFORp_type_float.
  • In spite of the small range and number of integers, the test will never losslessly compress the array, regardless of the rate set. This is because the integers are not properly normalized (shifted).
  • Even if validation were performed, no return code is provided to the OS to indicate whether the test passed. Given the difficulties of portably returning an exit code from Fortran, ctest's PASS_REGULAR_EXPRESSION may be preferable.
  • The source file extension should be .f90.

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions