Merge pull request #18 from LMAX-Exchange/fix-intellij-warnings

fix IntelliJ warnings

Author: markus-lmax

nanofix-client/src/main/java/com/lmax/nanofix/ChannelInitializer.java

@@ -50,15 +50,12 @@ class ChannelInitializer implements ConnectionObserver {
     @Override
     public void connectionEstablished() {
         outboundMessageSender.initialiseOutboundChannel(transport.getWritableByteChannel());
-        channelReaderExecutorService.execute(new Runnable() {
-            @Override
-            public void run() {
-                final ReadableByteChannel readableByteChannel = transport.getReadableByteChannel();
-                try {
-                    inputStreamReader.blockingStart(readableByteChannel);
-                } catch (RuntimeException e) {
-                    LOGGER.error("Exception thrown while reading from stream, channel: " + readableByteChannel, e);
-                }
+        channelReaderExecutorService.execute(() -> {
+            final ReadableByteChannel readableByteChannel = transport.getReadableByteChannel();
+            try {
+                inputStreamReader.blockingStart(readableByteChannel);
+            } catch (RuntimeException e) {
+                LOGGER.error("Exception thrown while reading from stream, channel: {}", readableByteChannel, e);
             }
         });
         countDownLatch.countDown();

nanofix-client/src/main/java/com/lmax/nanofix/FixClient.java

@@ -73,7 +73,7 @@ public void send(final String message) {
     }
 
     /**
-     * Sends a array of bytes string.
+     * Sends an array of bytes string.
      *
      * @param bytes a FIX messages.
      */
@@ -82,7 +82,7 @@ public void send(final byte[] bytes) {
     }
 
     /**
-     * Initiates a TCP connection with the remote host specified on construction..
+     * Initiates a TCP connection with the remote host specified on construction.
      */
     public void connect() {
         transportOps.connect();
@@ -94,7 +94,7 @@ public void connect() {
     }
 
     /**
-     * Initiates a TCP connection with the remote host specified on construction..
+     * Initiates a TCP connection with the remote host specified on construction.
      *
      * @param timeout the time to wait for a connection to be established
      * @param units   the {@link TimeUnit unit} of the timeout

nanofix-client/src/main/java/com/lmax/nanofix/FixClientConfiguration.java

@@ -38,7 +38,7 @@ public static FixClientConfiguration createInitiatingFixClient(final String host
     }
 
     /**
-     * Listening listening fix client that will listen for inbound tcp connections on port
+     * Listening fix client that will listen for inbound tcp connections on port
      *
      * @param port tcp port number int between 0 and 65535
      */

nanofix-client/src/main/java/com/lmax/nanofix/FixClientFactory.java

@@ -42,12 +42,8 @@
 public final class FixClientFactory {
     private static final Logger LOGGER = LoggerFactory.getLogger(FixClientFactory.class);
 
-    static final Thread.UncaughtExceptionHandler UNCAUGHT_EXCEPTION_HANDLER = new Thread.UncaughtExceptionHandler() {
-        @Override
-        public void uncaughtException(Thread thread, Throwable throwable) {
-            LOGGER.error("Uncaught Exception thrown in thread: " + thread.getName(), throwable);
-        }
-    };
+    static final Thread.UncaughtExceptionHandler UNCAUGHT_EXCEPTION_HANDLER = (thread, throwable) ->
+            LOGGER.error("Uncaught Exception thrown in thread: {}", thread.getName(), throwable);
 
     private FixClientFactory() {
     }
@@ -68,7 +64,7 @@ public static FixClient createFixClient(final String host, final int port) {
     }
 
     /**
-     * Create an listening fix client that will listen for inbound tcp connections on port
+     * Create a listening fix client that will listen for inbound tcp connections on port
      *
      * @param port tcp port number int between 0 and 65535
      */

nanofix-client/src/main/java/com/lmax/nanofix/FixSession.java

@@ -23,12 +23,10 @@
 import com.lmax.nanofix.outgoing.OutboundMessageHandler;
 
 public class FixSession {
-    private int outboundSequenceNumber;
-    private OutboundMessageHandler outboundMessageSender;
+    private final OutboundMessageHandler outboundMessageSender;
 
     public FixSession(final OutboundMessageHandler outboundMessageSender) {
         this.outboundMessageSender = outboundMessageSender;
-        this.outboundSequenceNumber = 1;
     }
 
     public void send(final Collection<FixMessage> messages) {

nanofix-client/src/main/java/com/lmax/nanofix/FixUtil.java

@@ -38,8 +38,8 @@ public static Charset getCharset() {
 
     public static byte[] newMessage(String... tags) {
         StringBuilder sb = new StringBuilder();
-        for (int i = 0, n = tags.length; i < n; i++) {
-            sb.append(tags[i]);
+        for (final String tag : tags) {
+            sb.append(tag);
             sb.append(FixTagParser.SOH);
         }
         return sb.toString().getBytes(FixUtil.getCharset());

nanofix-client/src/main/java/com/lmax/nanofix/concurrent/NamedThreadFactory.java

@@ -28,7 +28,7 @@ public class NamedThreadFactory implements ThreadFactory {
     private final String name;
     private final boolean daemon;
     private final AtomicInteger count = new AtomicInteger(0);
-    private Thread.UncaughtExceptionHandler uncaughtExceptionHandler;
+    private final Thread.UncaughtExceptionHandler uncaughtExceptionHandler;
 
     public NamedThreadFactory(final String name, boolean daemon, Thread.UncaughtExceptionHandler uncaughtExceptionHandler) {
         this.name = name;

nanofix-client/src/main/java/com/lmax/nanofix/incoming/FixMessage.java

@@ -43,7 +43,7 @@ public boolean hasValue(int tagId) {
     }
 
     public void replace(int tagId, String value) {
-        final LinkedList<String> values = new LinkedList<String>();
+        final LinkedList<String> values = new LinkedList<>();
         values.add(value);
         multimap.replaceValues(tagId, values);
     }

nanofix-client/src/main/java/com/lmax/nanofix/incoming/FixMessagePublisher.java

@@ -20,7 +20,7 @@
 import java.util.concurrent.CopyOnWriteArrayList;
 
 public class FixMessagePublisher implements FixMessageHandler {
-    List<FixMessageHandler> handlers = new CopyOnWriteArrayList<FixMessageHandler>();
+    List<FixMessageHandler> handlers = new CopyOnWriteArrayList<>();
 
     public void subscribeToAllMessages(final FixMessageHandler fixMessageHandler) {
         handlers.add(fixMessageHandler);

nanofix-client/src/main/java/com/lmax/nanofix/incoming/FixParseException.java

@@ -16,9 +16,8 @@
 
 package com.lmax.nanofix.incoming;
 
-@SuppressWarnings("serial")
-public final class FixParseException
-        extends RuntimeException {
+public final class FixParseException extends RuntimeException {
+
     public FixParseException(final String msg) {
         super(msg);
     }