From d273b74b6b3f4a87cde3d5503e6f3c2f326c2ad9 Mon Sep 17 00:00:00 2001 From: Markus Stoy Date: Mon, 13 Oct 2025 17:52:39 +0100 Subject: [PATCH 1/2] change Checkstyle and IntelliJ formatting settings to put left curlies on the same line to be consistent with updated LMAX code style --- .gitignore | 8 +- .idea/codeStyleSettings.xml | 7 - config/checkstyle/checkstyle.xml | 15 +- ...onnectionNotificationsIntegrationTest.java | 24 +- .../integration/FixClientLifecycleTest.java | 19 +- .../integration/ReceivingFixMessagesTest.java | 35 +- .../fixture/IntegrationSocketFactory.java | 134 ++---- .../fixture/SignallingConnectionObserver.java | 12 +- .../com/lmax/nanofix/ChannelInitializer.java | 31 +- .../main/java/com/lmax/nanofix/FixClient.java | 73 ++-- .../lmax/nanofix/FixClientConfiguration.java | 36 +- .../com/lmax/nanofix/FixClientFactory.java | 33 +- .../java/com/lmax/nanofix/FixSession.java | 18 +- .../main/java/com/lmax/nanofix/FixUtil.java | 17 +- .../java/com/lmax/nanofix/SystemConfig.java | 9 +- .../com/lmax/nanofix/byteoperations/Bits.java | 126 +++--- .../lmax/nanofix/byteoperations/ByteUtil.java | 105 ++--- .../com/lmax/nanofix/concurrent/Blocker.java | 3 +- .../concurrent/NamedThreadFactory.java | 16 +- .../nanofix/concurrent/ThreadBlocker.java | 15 +- .../exceptions/GeneralRuntimeException.java | 6 +- .../fields/BusinessRejectionReason.java | 9 +- .../lmax/nanofix/fields/EncryptMethod.java | 9 +- .../java/com/lmax/nanofix/fields/MsgType.java | 26 +- .../java/com/lmax/nanofix/fields/OrdType.java | 9 +- .../nanofix/fields/SessionRejectReason.java | 9 +- .../java/com/lmax/nanofix/fields/Side.java | 11 +- .../java/com/lmax/nanofix/fields/Tags.java | 26 +- .../nanofix/incoming/ByteChannelReader.java | 40 +- .../incoming/ByteStreamMessageParser.java | 3 +- .../com/lmax/nanofix/incoming/FixMessage.java | 35 +- .../nanofix/incoming/FixMessageHandler.java | 3 +- .../nanofix/incoming/FixMessagePublisher.java | 12 +- .../incoming/FixMessageStreamFactory.java | 18 +- .../nanofix/incoming/FixParseException.java | 13 +- .../incoming/FixStreamMessageParser.java | 142 +++---- .../lmax/nanofix/incoming/FixTagHandler.java | 3 +- .../lmax/nanofix/incoming/FixTagParser.java | 45 +- .../incoming/MessageParserCallback.java | 5 +- .../incoming/RawFixMessageHandler.java | 15 +- .../com/lmax/nanofix/outgoing/FixMessage.java | 12 +- .../nanofix/outgoing/FixMessageBuilder.java | 149 +++---- .../outgoing/OutboundMessageHandler.java | 49 +-- .../transport/AsyncTcpSocketFactory.java | 74 +--- .../lmax/nanofix/transport/BindException.java | 6 +- .../nanofix/transport/ConnectionObserver.java | 3 +- .../DelegatingServerSocketChannel.java | 12 +- .../PublishingConnectionObserver.java | 21 +- .../lmax/nanofix/transport/SocketFactory.java | 6 +- .../lmax/nanofix/transport/TcpTransport.java | 101 ++--- .../com/lmax/nanofix/transport/Transport.java | 3 +- .../transport/TransportClosedException.java | 6 +- .../nanofix/transport/TransportConfig.java | 3 +- .../transport/TransportConfigImpl.java | 9 +- .../transport/TransportOperations.java | 3 +- .../lmax/nanofix/ChannelInitializerTest.java | 24 +- .../lmax/nanofix/byteoperations/BitsTest.java | 33 +- .../nanofix/byteoperations/ByteUtilTest.java | 386 +++++++++--------- .../nanofix/concurrent/ThreadBlockerTest.java | 28 +- .../incoming/ByteChannelReaderTest.java | 25 +- .../incoming/FixMessageFactoryTest.java | 12 +- .../lmax/nanofix/incoming/FixMessageTest.java | 18 +- .../lmax/nanofix/incoming/FixMessageUtil.java | 56 +-- ...ixStreamMessageParserPermutationsTest.java | 125 ++---- .../incoming/FixStreamMessageParserTest.java | 207 ++++------ .../nanofix/incoming/FixTagParserTest.java | 21 +- .../MessageParserCallbackTestFactory.java | 5 +- .../nanofix/outgoing/ByteBufferMatcher.java | 24 +- .../outgoing/FixMessageBuilderTest.java | 23 +- .../outgoing/OutboundMessageHandlerTest.java | 49 +-- .../nanofix/transport/TcpTransportTest.java | 18 +- 71 files changed, 962 insertions(+), 1724 deletions(-) diff --git a/.gitignore b/.gitignore index 2580543..7cf27ab 100644 --- a/.gitignore +++ b/.gitignore @@ -2,18 +2,18 @@ /client/build /integration-tests/build /out -/ideabuild/ -/eclipse /opt /cache /ivysettings.xml /foo.txt /foo.xml -/.idea -*.iml /nanofix.ipr .gradle/ +/.idea/ +*.iml +!.idea/codeStyleSettings.xml + nanofix-client/build/ diff --git a/.idea/codeStyleSettings.xml b/.idea/codeStyleSettings.xml index 08c019e..d0a46c0 100644 --- a/.idea/codeStyleSettings.xml +++ b/.idea/codeStyleSettings.xml @@ -183,13 +183,6 @@