Velocity/panning scrolling with selection may affect unselected notes

[yohannd1]

System Information

Linux core2 6.18.2-arch2-1 #1 SMP PREEMPT_DYNAMIC Thu, 18 Dec 2025 18:00:18 +0000 x86_64 GNU/Linux

LMMS Version(s)

LMMS 1.3.0-alpha.1.935+2ac3cbb

Most Recent Working Version

No response

Bug Summary

Scrolling to change velocity/panning can affect unselected notes if hovering over them in the bottom section of the piano roll.

Expected Behaviour

Unselected notes should be unaffected.

Steps To Reproduce

1. Open piano roll
2. Place some notes
3. Select a subset of them
4. Go to the note velocity/panning bar
5. Hover the value indicator of an unselected note and scroll it up/down
6. It will affect the unselected note, as not intended

Logs

No response

Screenshots / Minimum Reproducible Project

vid.mp4

Please search the issue tracker for existing bug reports before submitting your own.

• I have searched all existing issues and confirmed that this is not a duplicate.

[yohannd1]

Searched through the code and the culpirit seems to be this:

I have made a fix and it seems to work now, but I'm not so sure this is the intended behavior (hence why I didn't make a PR yet). Is this a good solution?

diff --git a/src/gui/editors/PianoRoll.cpp b/src/gui/editors/PianoRoll.cpp
index 09d975625..4fc420e1e 100644
--- a/src/gui/editors/PianoRoll.cpp
+++ b/src/gui/editors/PianoRoll.cpp
@@ -4055,15 +4056,31 @@ void PianoRoll::wheelEvent(QWheelEvent * we )
 
 		// When alt is pressed we only edit the note under the cursor
 		bool altPressed = we->modifiers() & Qt::AltModifier;
 		// go through notes to figure out which one we want to change
 		NoteVector nv;
+		bool isSelection = false;
 		for ( Note * i : m_midiClip->notes() )
 		{
-			if( i->withinRange( ticks_start, ticks_end ) || ( i->selected() && !altPressed ) )
+			if (i->selected() && !altPressed) // found a selected note
+			{
+				if (!isSelection)
+				{
+					// drop other notes if we are realizing this is a selection now
+					isSelection = true;
+					nv.clear();
+				}
+
+				nv.push_back(i);
+			}
+
+			// not on selection - just push back the note if it is within range
+			if (!isSelection && i->withinRange(ticks_start, ticks_end))
 			{
 				nv.push_back(i);
 			}
 		}
 		if( nv.size() > 0 )
 		{
 			const int step = (we->angleDelta().y() > 0 ? 1 : -1) * (we->inverted() ? -1 : 1);

[messmerd]

@yohannd1 This does seem like a bug, and your proposed solution looks correct to me. Go ahead and open that PR