Negative subwindow positions get invalidated when loading project

[yohannd1]

System Information

Linux core2 6.18.2-arch2-1 #1 SMP PREEMPT_DYNAMIC Thu, 18 Dec 2025 18:00:18 +0000 x86_64 GNU/Linux

LMMS Version(s)

LMMS 1.3.0-alpha.1.935+2ac3cbb

Most Recent Working Version

No response

Bug Summary

When loading a project, widgets whose top-left is to the top or the left of the visible region get their positions reset.

Expected Behaviour

I believe this should not happen, and widgets should be kept in their previous positions (will elaborate on this on the next comment).

Steps To Reproduce

1. Create a project
2. Place two or more widgets/windows on the screen
3. Drag the background as to hide one or more widgets on the left or top of the screen
4. Save the project and reload it
5. The previously hidden widgets will appear on screen

Logs

No response

Screenshots / Minimum Reproducible Project

vid.mp4

Please search the issue tracker for existing bug reports before submitting your own.

• I have searched all existing issues and confirmed that this is not a duplicate.

[yohannd1]

From what I've tested, these lines are responsible for restraining the position:

In this sense, simply removing the qMax calls and leaving the raw value solve the issue and makes it work as I expect.

diff --git a/src/gui/MainWindow.cpp b/src/gui/MainWindow.cpp
index 69360111c..b32882474 100644
--- a/src/gui/MainWindow.cpp
+++ b/src/gui/MainWindow.cpp
@@ -689,8 +689,8 @@ void MainWindow::saveWidgetState( QWidget * _w, QDomElement & _de )
 
 void MainWindow::restoreWidgetState( QWidget * _w, const QDomElement & _de )
 {
-	QRect r( qMax( 1, _de.attribute( "x" ).toInt() ),
-			qMax( 1, _de.attribute( "y" ).toInt() ),
+	QRect r(_de.attribute("x").toInt(),
+			_de.attribute("y").toInt(),
 			qMax( _w->sizeHint().width(), _de.attribute( "width" ).toInt() ),
 			qMax( _w->minimumHeight(), _de.attribute( "height" ).toInt() ) );
 	if( _de.hasAttribute( "visible" ) && !r.isNull() )

Is this alright?

[headquarter8302]

Presumably this was done to prevent people from saving the project and not knowing/forgetting where the widget was placed, since these widgets don't return to the viewable window in any way.

I'll ask the others on the Discord to comment on this

[szeli1]

Please could you rename this issue to "Negative subwindow positions get invalidated when loading project"? I think this is a better description of the problem.