LTplus-AG
diff --git a/‎.changeset/fix-rebar-rendering-issue-631.md‎
Lines changed: 22 additions & 0 deletions b/‎.changeset/fix-rebar-rendering-issue-631.md‎
Lines changed: 22 additions & 0 deletions
diff --git a/‎packages/wasm/pkg/ifc-lite.d.ts‎
Lines changed: 3 additions & 3 deletions b/‎packages/wasm/pkg/ifc-lite.d.ts‎
Lines changed: 3 additions & 3 deletions
diff --git a/‎packages/wasm/pkg/ifc-lite.js‎
Lines changed: 6 additions & 6 deletions b/‎packages/wasm/pkg/ifc-lite.js‎
Lines changed: 6 additions & 6 deletions
diff --git a/‎packages/wasm/pkg/ifc-lite_bg.wasm‎
5.45 KB b/‎packages/wasm/pkg/ifc-lite_bg.wasm‎
5.45 KB
diff --git a/‎packages/wasm/pkg/ifc-lite_bg.wasm.d.ts‎
Lines changed: 3 additions & 3 deletions b/‎packages/wasm/pkg/ifc-lite_bg.wasm.d.ts‎
Lines changed: 3 additions & 3 deletions
diff --git a/‎rust/geometry/src/processors/tests.rs‎
Lines changed: 95 additions & 0 deletions b/‎rust/geometry/src/processors/tests.rs‎
Lines changed: 95 additions & 0 deletions
@@ -0,0 +1,22 @@
+---
+"@ifc-lite/wasm": patch
+"@ifc-lite/geometry": patch
+---
+
+Fix `IfcReinforcingBar` stirrup rendering (issue #631, sample
+`IfcReinforcingBar.ifc`).
+
+`IfcSweptDiskSolid` directrixes that use `IfcIndexedPolyCurve` over
+`IfcCartesianPointList3D` (typical for stirrups and other bent rebar that
+lives outside the XY plane) used to fall back to a 2D parser that read x/y
+from indices 0–1 and silently dropped the Z coordinate. The stirrup
+collapsed onto z=0 and the resulting tube was a flat near-degenerate line.
+
+The 3D curve dispatcher now has a native arm for `IfcIndexedPolyCurve` that
+reads `IfcCartesianPointList2D` (z=0) or `IfcCartesianPointList3D` verbatim
+and fits `IfcArcIndex` segments using a circumcircle in the plane of their
+three control points. Straight schema conformance — no spec deviation.
+
+The second sample on the issue (`Rebar2.ifc`) was already rendering its
+directrix correctly under the existing segment-index trim path; no change
+needed there.
@@ -1194,9 +1194,9 @@ export interface InitOutput {
   readonly profileentryjs_expressId: (a: number) => number;
   readonly symboliccircle_expressId: (a: number) => number;
   readonly __wbg_gpuinstancedgeometryref_free: (a: number, b: number) => void;
-  readonly __wasm_bindgen_func_elem_1165: (a: number, b: number, c: number) => void;
-  readonly __wasm_bindgen_func_elem_1164: (a: number, b: number) => void;
-  readonly __wasm_bindgen_func_elem_1205: (a: number, b: number, c: number, d: number) => void;
+  readonly __wasm_bindgen_func_elem_1167: (a: number, b: number, c: number) => void;
+  readonly __wasm_bindgen_func_elem_1166: (a: number, b: number) => void;
+  readonly __wasm_bindgen_func_elem_1206: (a: number, b: number, c: number, d: number) => void;
   readonly __wbindgen_export: (a: number) => void;
   readonly __wbindgen_export2: (a: number, b: number, c: number) => void;
   readonly __wbindgen_export3: (a: number, b: number) => number;
 
@@ -212,12 +212,12 @@ if (!('encodeInto' in cachedTextEncoder)) {
 
 let WASM_VECTOR_LEN = 0;
 
-function __wasm_bindgen_func_elem_1165(arg0, arg1, arg2) {
-    wasm.__wasm_bindgen_func_elem_1165(arg0, arg1, addHeapObject(arg2));
+function __wasm_bindgen_func_elem_1167(arg0, arg1, arg2) {
+    wasm.__wasm_bindgen_func_elem_1167(arg0, arg1, addHeapObject(arg2));
 }
 
-function __wasm_bindgen_func_elem_1205(arg0, arg1, arg2, arg3) {
-    wasm.__wasm_bindgen_func_elem_1205(arg0, arg1, addHeapObject(arg2), addHeapObject(arg3));
+function __wasm_bindgen_func_elem_1206(arg0, arg1, arg2, arg3) {
+    wasm.__wasm_bindgen_func_elem_1206(arg0, arg1, addHeapObject(arg2), addHeapObject(arg3));
 }
 
 const GeoReferenceJsFinalization = (typeof FinalizationRegistry === 'undefined')
@@ -3093,7 +3093,7 @@ function __wbg_get_imports() {
                 const a = state0.a;
                 state0.a = 0;
                 try {
-                    return __wasm_bindgen_func_elem_1205(a, state0.b, arg0, arg1);
+                    return __wasm_bindgen_func_elem_1206(a, state0.b, arg0, arg1);
                 } finally {
                     state0.a = a;
                 }
@@ -3207,7 +3207,7 @@ function __wbg_get_imports() {
     };
     imports.wbg.__wbindgen_cast_49a1621a976e807f = function(arg0, arg1) {
         // Cast intrinsic for `Closure(Closure { dtor_idx: 154, function: Function { arguments: [Externref], shim_idx: 155, ret: Unit, inner_ret: Some(Unit) }, mutable: true }) -> Externref`.
-        const ret = makeMutClosure(arg0, arg1, wasm.__wasm_bindgen_func_elem_1164, __wasm_bindgen_func_elem_1165);
+        const ret = makeMutClosure(arg0, arg1, wasm.__wasm_bindgen_func_elem_1166, __wasm_bindgen_func_elem_1167);
         return addHeapObject(ret);
     };
     imports.wbg.__wbindgen_cast_d6cd19b81560fd6e = function(arg0) {
 
@@ -215,9 +215,9 @@ export const meshcollection_rtcOffsetX: (a: number) => number;
 export const profileentryjs_expressId: (a: number) => number;
 export const symboliccircle_expressId: (a: number) => number;
 export const __wbg_gpuinstancedgeometryref_free: (a: number, b: number) => void;
-export const __wasm_bindgen_func_elem_1165: (a: number, b: number, c: number) => void;
-export const __wasm_bindgen_func_elem_1164: (a: number, b: number) => void;
-export const __wasm_bindgen_func_elem_1205: (a: number, b: number, c: number, d: number) => void;
+export const __wasm_bindgen_func_elem_1167: (a: number, b: number, c: number) => void;
+export const __wasm_bindgen_func_elem_1166: (a: number, b: number) => void;
+export const __wasm_bindgen_func_elem_1206: (a: number, b: number, c: number, d: number) => void;
 export const __wbindgen_export: (a: number) => void;
 export const __wbindgen_export2: (a: number, b: number, c: number) => void;
 export const __wbindgen_export3: (a: number, b: number) => number;
 
@@ -537,6 +537,101 @@ fn test_extruded_area_solid_tapered() {
     assert!((max.z - 2000.0).abs() < 0.01);
 }
 
+/// Issue #631, sample `IfcReinforcingBar.ifc` (stirrup).
+///
+/// `IfcSweptDiskSolid` directrix is an `IfcIndexedPolyCurve` over an
+/// `IfcCartesianPointList3D`. Before this fix the 3D curve dispatcher had no
+/// arm for `IfcIndexedPolyCurve`, so points were re-read as 2D and collapsed
+/// onto z=0 — the stirrup rendered as a flat near-zero-length line. Verify
+/// that the swept tube spans the full Z range of the input points.
+#[test]
+fn test_swept_disk_indexed_polycurve_3d() {
+    // A simple 3D arc: start (0,0,0), mid (10,0,10), end (20,0,0).
+    // This lives in the XZ plane — Y stays zero, Z varies non-trivially.
+    let content = r#"
+#1=IFCCARTESIANPOINTLIST3D(((0.0,0.0,0.0),(10.0,0.0,10.0),(20.0,0.0,0.0)));
+#2=IFCINDEXEDPOLYCURVE(#1,(IFCARCINDEX((1,2,3))),.F.);
+#3=IFCSWEPTDISKSOLID(#2,1.0,$,$,$);
+"#;
+
+    let mut decoder = EntityDecoder::new(content);
+    let schema = IfcSchema::new();
+    let processor = SweptDiskSolidProcessor::new(schema.clone());
+
+    let entity = decoder.decode_by_id(3).unwrap();
+    assert_eq!(entity.ifc_type, IfcType::IfcSweptDiskSolid);
+    let mesh = processor.process(&entity, &mut decoder, &schema).unwrap();
+
+    assert!(!mesh.is_empty(), "3D indexed polycurve directrix should produce geometry");
+
+    let (min, max) = mesh.bounds();
+    // The tube radius is 1.0, so Z extent of the mesh should be close to
+    // (arc max Z + radius) - (-radius) ≈ 11. Without this fix the directrix
+    // collapses to a 1-D line on x and Z extent is ~2 (just the tube radius
+    // around z=0).
+    let z_extent = (max.z - min.z) as f64;
+    assert!(
+        z_extent > 5.0,
+        "stirrup arc should span its declared 3D Z range; got z_extent={}",
+        z_extent
+    );
+}
+
+/// Issue #631, sample `Rebar2.ifc`.
+///
+/// The directrix is a planar `IfcCompositeCurve` whose arc segments are
+/// authored as `IfcTrimmedCurve` over an `IfcCircle` placed by
+/// `IfcAxis2Placement3D`. `get_placement_2d` used to read attribute index 1 of
+/// the placement as `RefDirection`, but on a 3D placement that index is the
+/// `Axis` (Z direction). Every arc came back with rotation=0° regardless of
+/// the file's actual `RefDirection`, twisting each bend by the file's
+/// authored angle — visibly distorting Revit-exported bent rebar.
+///
+/// Verify that an arc anchored to `IfcAxis2Placement3D` with `RefDirection`
+/// rotated 90° actually rotates: the bottom of the arc (parameter 270°) lands
+/// at the rotated +X direction, not at world -Y.
+#[test]
+fn test_trimmed_circle_3d_placement_reads_ref_direction() {
+    // Circle radius 10, centred at (100, 100, 0), placed in XY plane with
+    // RefDirection = +Y (rotation 90°). A 270° trim with sense=T produces a
+    // point at radius * (cos(270°+90°), sin(270°+90°)) = (10, 0) in the local
+    // frame ⇒ (100 + 10*cos(90°), 100 + 10*sin(90°)) ≈ (100, 110) in world.
+    //
+    // Without the fix the rotation reads as 0° (the Z-axis x/y components),
+    // so 270° lands at (100, 90) — visibly off.
+    let content = r#"
+#1=IFCCARTESIANPOINT((100.0,100.0,0.0));
+#2=IFCDIRECTION((0.0,0.0,1.0));
+#3=IFCDIRECTION((0.0,1.0,0.0));
+#4=IFCAXIS2PLACEMENT3D(#1,#2,#3);
+#5=IFCCIRCLE(#4,10.0);
+#6=IFCTRIMMEDCURVE(#5,(IFCPARAMETERVALUE(270.0)),(IFCPARAMETERVALUE(0.0)),.T.,.PARAMETER.);
+#7=IFCCOMPOSITECURVESEGMENT(.CONTINUOUS.,.T.,#6);
+#8=IFCCOMPOSITECURVE((#7),.F.);
+#9=IFCSWEPTDISKSOLID(#8,0.5,$,$,$);
+"#;
+
+    let mut decoder = EntityDecoder::new(content);
+    let schema = IfcSchema::new();
+    let processor = SweptDiskSolidProcessor::new(schema.clone());
+
+    let entity = decoder.decode_by_id(9).unwrap();
+    let mesh = processor.process(&entity, &mut decoder, &schema).unwrap();
+    assert!(!mesh.is_empty());
+
+    let (min, max) = mesh.bounds();
+    // With RefDirection respected (90° rotation), the trim from 270° to 360°
+    // sweeps from local-frame "below center" to local-frame "right of center";
+    // in world that maps to "left of center" to "below center" because +X
+    // local = +Y world. Mesh extents should clear well above center.y - radius
+    // in the bug case (would otherwise stay near y=100-r).
+    assert!(
+        (max.y as f64) > 105.0,
+        "Arc should rotate with RefDirection — max.y={} suggests rotation was ignored",
+        max.y
+    );
+}
+
 #[test]
 fn test_extruded_area_solid_tapered_falls_back_when_end_missing() {
     // A malformed file with no EndSweptArea should still render as a uniform