Merge pull request #117 from Obiajulu-gif/stream_storage

contracts/stream_contract: update stream storage tests only

Author: ogazboiz

.github/workflows/security.yml

@@ -20,6 +20,22 @@ jobs:
     - name: Setup Node.js
       uses: actions/setup-node@v4
       with:
+        node-version: '20.19.0'
+        cache: 'npm'
+        
+    - name: Install dependencies
+      env:
+        HUSKY: 0
+      run: npm ci
+      
+    - name: Run npm audit (production dependencies)
+      run: npm audit --omit=dev --audit-level=critical
+      
+    - name: Check for known vulnerabilities in frontend (production dependencies)
+      run: npm audit --workspace=frontend --omit=dev --audit-level=critical
+        
+    - name: Check for known vulnerabilities in backend (production dependencies)
+      run: npm audit --workspace=backend --omit=dev --audit-level=critical
         node-version: '20'
         cache: 'npm'
 
@@ -53,16 +69,16 @@ jobs:
         language: [ 'javascript', 'typescript' ]
 
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-
-      - name: Initialize CodeQL
-        uses: github/codeql-action/init@v3
-        with:
-          languages: ${{ matrix.language }}
-
-      - name: Autobuild
-        uses: github/codeql-action/autobuild@v3
-
-      - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@v3
+    - name: Checkout repository
+      uses: actions/checkout@v4
+      
+    - name: Initialize CodeQL
+      uses: github/codeql-action/init@v3
+      with:
+        languages: ${{ matrix.language }}
+        
+    - name: Autobuild
+      uses: github/codeql-action/autobuild@v3
+      
+    - name: Perform CodeQL Analysis
+      uses: github/codeql-action/analyze@v3

contracts/stream_contract/src/test.rs

@@ -112,6 +112,10 @@ fn test_initialize_rejects_second_call() {
     let admin = Address::generate(&env);
     let treasury = Address::generate(&env);
 
+    assert_eq!(stream_id1, 1);
+    assert_eq!(stream_id2, 2);
+    assert!(client.get_stream(&stream_id1).is_some());
+    assert!(client.get_stream(&stream_id2).is_some());
     client.initialize(&admin, &treasury, &100);
     let result = client.try_initialize(&admin, &treasury, &100);
     assert_eq!(result, Err(Ok(StreamError::AlreadyInitialized)));
@@ -340,6 +344,10 @@ fn test_top_up_rejects_negative_amount() {
     let client = create_contract(&env);
     let id = client.create_stream(&sender, &Address::generate(&env), &token, &10_000, &100);
 
+    let contract_id = env.register(StreamContract, ());
+    let client = StreamContractClient::new(&env, &contract_id);
+    let token_client = token::Client::new(&env, &token_address);
+    token_client.approve(&sender, &contract_id, &20_000, &1_000_000);
     assert_eq!(
         client.try_top_up_stream(&sender, &id, &-50),
         Err(Ok(StreamError::InvalidAmount))
@@ -514,6 +522,10 @@ fn test_withdraw_emits_event() {
     let client = create_contract(&env);
     let id = client.create_stream(&sender, &recipient, &token, &500, &100);
 
+    let contract_id = env.register(StreamContract, ());
+    let client = StreamContractClient::new(&env, &contract_id);
+    let token_client = token::Client::new(&env, &token_address);
+    token_client.approve(&sender, &contract_id, &20_000, &1_000_000);
     // Advance time by 100 seconds to allow full withdrawal (500 tokens / 100 seconds = 5 tokens/sec)
     env.ledger().with_mut(|l| {
         l.timestamp += 100;