[Backend] sorobanService.simulateContractCall: extract STALE_THRESHOLD_MS / fee / placeholder source magic

[ogazboiz]

Join the discussion on Telegram

Why this matters

Issue #505 covered the named-constants pass in this file but only enumerated the simulated-tx flow magic literals. There is still a small set of unexplained magic in the file that the previous PR didn't itemize:

backend/src/services/sorobanService.ts:

• Line 8: const STALE_THRESHOLD_MS = 30_000; — explained as 30s with no rationale comment
• Line 56: new Account('GAAZI4TCR3TY5OJHCTJC2A4QSY6CJWJH5IAJTGKIN2ER7LBNVKOCCWN', '0') — placeholder source account inlined twice (once here)
• Line 60: fee: '100' — for simulation calls
• Line 91: fee: '1000' — for real submit calls
• Lines 68, 98: .setTimeout(30) — explained as seconds but not labeled

Acceptance criteria

• Add module-level constants with short doc comments for each: SIMULATION_FEE, SUBMIT_FEE, TX_TIMEOUT_SECONDS, SIMULATION_PLACEHOLDER_ACCOUNT
• Reference the constants in simulateContractCall and submitContractCall
• Add a one-line comment explaining why STALE_THRESHOLD_MS is 30s (= avg ledger close × N)

Files to touch

• backend/src/services/sorobanService.ts (lines 8, 56, 60, 68, 91, 98)

Out of scope

• Rewriting the dual-mode (simulate vs submit) abstraction itself

[EbukaMoses]

@EbukaMoses has applied to work on this issue as part of the Stellar Wave Program's 5th wave.

Hello Maintainer,

I’d like to apply to work on this issue.

I’m Ebuka Moses, a full-stack and blockchain developer with experience building, testing, and maintaining smart contracts, particularly using Rust and blockchain-based architectures. I’m comfortable working with contract logic, validation, access control, persistent storage, and event handling, and I always pay close attention to correctness, security, and edge cases.

I take time to fully understand the issue requirements before implementing a solution, and I ensure my work follows the project’s coding standards. I also write clear, well-tested code and submit clean pull requests with meaningful commits.

I’m confident I can deliver a solid solution that meets the acceptance criteria and adds value to the project.

Thank you for your consideration, and I look forward to contributing.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @EbukaMoses to this issue.

[drips-wave]

Congratulations, @EbukaMoses! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on June 2, 2026.

🧑‍💻 @EbukaMoses: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox!

@EbukaMoses's PR #740 was approved and merged by @ogazboiz.

🏆 @EbukaMoses: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (716 total points). Track your full progress on GrantFox.

👏 Great work, @EbukaMoses! Keep contributing to LabsCrypt.