Merge pull request quarkusio#46649 from Ladicek/arc-multiple-disposers-error

ArC: improve error message in case multiple disposers are found for a producer

Author: mkouba

independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BeanDeployment.java

@@ -1473,7 +1473,12 @@ private DisposerInfo findDisposer(Set<Type> beanTypes, BeanInfo declaringBean, A
             }
         }
         if (found.size() > 1) {
-            throw new DefinitionException("Multiple disposer methods found for " + producer);
+            StringBuilder error = new StringBuilder("Multiple disposer methods found for producer '")
+                    .append(producer).append("' declared on ").append(declaringBean).append(":\n");
+            for (DisposerInfo disposer : found) {
+                error.append("\t- ").append(disposer.getDisposerMethod()).append("\n");
+            }
+            throw new DefinitionException(error.toString());
         }
         return found.isEmpty() ? null : found.get(0);
     }

independent-projects/arc/tests/src/test/java/io/quarkus/arc/test/producer/disposer/illegal/MultipleDisposersTest.java

@@ -0,0 +1,49 @@
+package io.quarkus.arc.test.producer.disposer.illegal;
+
+import static org.junit.jupiter.api.Assertions.assertInstanceOf;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+import jakarta.enterprise.context.Dependent;
+import jakarta.enterprise.inject.Disposes;
+import jakarta.enterprise.inject.Produces;
+import jakarta.enterprise.inject.spi.DefinitionException;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+import io.quarkus.arc.test.ArcTestContainer;
+
+public class MultipleDisposersTest {
+    @RegisterExtension
+    public ArcTestContainer container = ArcTestContainer.builder()
+            .beanClasses(ProducerDisposer.class)
+            .shouldFail()
+            .build();
+
+    @Test
+    public void trigger() {
+        Throwable error = container.getFailure();
+        assertNotNull(error);
+        assertInstanceOf(DefinitionException.class, error);
+        assertTrue(error.getMessage().contains("Multiple disposer methods found"));
+        assertTrue(error.getMessage().contains("produceString"));
+        assertTrue(error.getMessage().contains("disposeString"));
+        assertTrue(error.getMessage().contains("disposeCharSequence"));
+    }
+
+    @Dependent
+    static class ProducerDisposer {
+        @Produces
+        @Dependent
+        String produceString() {
+            return "";
+        }
+
+        void disposeString(@Disposes String ignored) {
+        }
+
+        void disposeCharSequence(@Disposes CharSequence ignored) {
+        }
+    }
+}