UI: Remove the Gtk port

This was added before the recent efforts to make the Qt port look good
everywhere, and has since been entirely unmaintained. Let's remove it
for now. In the future, if we decide we want a Gtk port again, let's
start with safe-language bindings from the get-go.

Author: trflynn89

.devcontainer/features/ladybird/install-fedora.sh

@@ -5,6 +5,6 @@ set -e
 dnf install -y git gh
 
 # Ladybird dev dependencies
-dnf install -y autoconf-archive automake bison ccache cmake curl google-noto-sans-mono-fonts liberation-sans-fonts \
+dnf install -y autoconf-archive automake ccache cmake curl google-noto-sans-mono-fonts liberation-sans-fonts \
     libdrm-devel libglvnd-devel libtool nasm ncurses-devel ninja-build patchelf perl-FindBin perl-IPC-Cmd perl-lib perl-Time-Piece qt6-qtbase-devel \
     qt6-qttools-devel qt6-qtwayland-devel tar unzip zip zlib-ng-compat-static

.devcontainer/features/ladybird/install-ubuntu.sh

@@ -31,7 +31,7 @@ install_cmake() {
 ### Install packages
 
 apt update -y
-apt install -y autoconf autoconf-archive automake bison build-essential ccache curl fonts-liberation2 git glslang-tools libdrm-dev libgl1-mesa-dev libncurses-dev libtool libxkbcommon-dev lsb-release nasm ninja-build pkg-config python3 qt6-base-dev qt6-tools-dev-tools qt6-wayland shellcheck tar unzip zip
+apt install -y autoconf autoconf-archive automake build-essential ccache curl fonts-liberation2 git glslang-tools libdrm-dev libgl1-mesa-dev libncurses-dev libtool lsb-release nasm ninja-build pkg-config python3 qt6-base-dev qt6-tools-dev-tools qt6-wayland shellcheck tar unzip zip
 
 install_cmake
 

.github/workflows/lagom-template.yml

@@ -92,10 +92,6 @@ jobs:
             echo "host_cxx=$(xcrun --find clang++)" >> "$GITHUB_OUTPUT"
           fi
 
-          if ${{ inputs.os_name == 'Linux' && inputs.build_preset == 'Sanitizer' }} ; then
-            CMAKE_OPTIONS="$CMAKE_OPTIONS -DLADYBIRD_GUI_FRAMEWORK=Gtk"
-          fi
-
           if ${{ inputs.clang_plugins }} ; then
             echo "ccache_key=${{ inputs.build_preset }}-CLANG_PLUGINS" >> "$GITHUB_OUTPUT"
             CMAKE_OPTIONS="$CMAKE_OPTIONS -DENABLE_CLANG_PLUGINS=ON"
@@ -176,7 +172,7 @@ jobs:
           cmake --install . --strip --prefix "${GITHUB_WORKSPACE}/Install"
 
       - name: Build with Qt
-        if: ${{ (inputs.os_name == 'macOS' || inputs.os_name == 'Linux') && inputs.build_preset == 'Sanitizer' }}
+        if: ${{ inputs.os_name == 'macOS' && inputs.build_preset == 'Sanitizer' }}
         working-directory: ${{ github.workspace }}
         run: |
           cmake --preset ${{ inputs.build_preset }} -B Build -DLADYBIRD_GUI_FRAMEWORK=Qt

CMakeLists.txt

@@ -14,26 +14,20 @@ if (APPLE AND NOT CMAKE_OSX_DEPLOYMENT_TARGET)
     set(CMAKE_OSX_DEPLOYMENT_TARGET 14.0)
 endif()
 
-include("Meta/CMake/gui_framework.cmake")
-
 # Pass additional information to vcpkg if we are using it.
 if (CMAKE_TOOLCHAIN_FILE MATCHES "vcpkg.cmake$")
     set(CMAKE_PROJECT_ladybird_INCLUDE_BEFORE "Meta/CMake/vcpkg/generate_vcpkg_toolchain_variables.cmake")
-    if (LADYBIRD_GUI_FRAMEWORK STREQUAL "Qt" OR LADYBIRD_GUI_FRAMEWORK STREQUAL "Gtk")
-        string(TOLOWER "${LADYBIRD_GUI_FRAMEWORK}" framework_feature)
-        set(VCPKG_MANIFEST_FEATURES "${framework_feature}" CACHE STRING "" FORCE)
-    endif()
 endif()
 
 if (APPLE AND NOT CMAKE_OSX_SYSROOT)
     set(CMAKE_OSX_SYSROOT macosx)
 endif()
 
 project(ladybird
-        VERSION 0.1.0
-        LANGUAGES C CXX
-        DESCRIPTION "Ladybird Web Browser"
-        HOMEPAGE_URL "https://ladybird.org"
+    VERSION 0.1.0
+    LANGUAGES C CXX
+    DESCRIPTION "Ladybird Web Browser"
+    HOMEPAGE_URL "https://ladybird.org"
 )
 
 if (ANDROID OR IOS)

Documentation/BuildInstructionsLadybird.md

@@ -255,7 +255,6 @@ If you want to run other applications, such as the JS REPL or the WebAssembly RE
 Ladybird will be built with one of the following browser frontends, depending on the platform:
 * [AppKit](https://developer.apple.com/documentation/appkit?language=objc) - The native UI on macOS.
 * [Qt](https://doc.qt.io/qt-6/) - The UI used on all other platforms.
-* [GTK 4](https://docs.gtk.org/gtk4/) - An alternative UI on Linux (experimental).
 * [Android UI](https://developer.android.com/develop/ui) - The native UI on Android.
 
 You can pick the UI using the `LADYBIRD_GUI_FRAMEWORK` option, or the `--gui` argument to ladybird.py.
@@ -268,26 +267,6 @@ cmake --preset Release -DLADYBIRD_GUI_FRAMEWORK=Qt
 ./Meta/ladybird.py run --gui=Qt
 ```
 
-#### Additional prerequisites for the GTK UI
-
-Building with `LADYBIRD_GUI_FRAMEWORK=Gtk` requires additional system packages, as some vcpkg
-dependencies (e.g. gettext) need to be rebuilt from source:
-
-**Debian/Ubuntu:**
-```bash
-sudo apt install bison libxkbcommon-dev
-```
-
-**Arch Linux/Manjaro:**
-```bash
-sudo pacman -S bison
-```
-
-**Fedora:**
-```bash
-sudo dnf install bison
-```
-
 ### Build error messages you may encounter
 
 The section lists out some particular error messages you may run into, and explains how to deal with them.

Documentation/GtkFrontend.md

@@ -24,6 +24,8 @@ if (CMAKE_OSX_DEPLOYMENT_TARGET)
     string(APPEND EXTRA_VCPKG_VARIABLES "set(VCPKG_OSX_DEPLOYMENT_TARGET ${CMAKE_OSX_DEPLOYMENT_TARGET})\n")
 endif()
 
+file(WRITE "${CMAKE_CURRENT_BINARY_DIR}/build-vcpkg-variables.cmake" "${EXTRA_VCPKG_VARIABLES}")
+
 # Munge the VCPKG_TRIPLET to correspond to the right one for our presets
 # Just make sure not to override if the developer is trying to cross-compile
 # or the developer set it manually, or if this is not the first run of CMake
@@ -86,9 +88,3 @@ if (NOT DEFINED CACHE{VCPKG_TARGET_TRIPLET} AND NOT DEFINED CACHE{VCPKG_HOST_TRI
     set(VCPKG_TARGET_TRIPLET ${full_triplet} CACHE STRING "")
     set(VCPKG_HOST_TRIPLET ${full_triplet} CACHE STRING "")
 endif()
-
-if (VCPKG_TARGET_TRIPLET MATCHES ".*linux.*" AND "gtk" IN_LIST VCPKG_MANIFEST_FEATURES)
-    string(APPEND EXTRA_VCPKG_VARIABLES "set(X_VCPKG_FORCE_VCPKG_WAYLAND_LIBRARIES ON)\n")
-endif()
-
-file(WRITE "${CMAKE_CURRENT_BINARY_DIR}/build-vcpkg-variables.cmake" "${EXTRA_VCPKG_VARIABLES}")