Fix water-sensitivity check not working, and bad projectile lighting.

Author: LambdAurora

CHANGELOG.md

@@ -206,6 +206,12 @@
 
 - Fixed in-world item light source data reload not applying.
 
+### 3.1.2
+
+- Added base light of 8 to allays.
+- Fixed dynamic lighting of various projectiles.
+- Fixed water-sensitive items lighting up underwater while they shouldn't.
+
 [SpruceUI]: https://github.com/LambdAurora/SpruceUI "SpruceUI page"
 [pridelib]: https://github.com/Queerbric/pridelib "Pridelib page"
 [Sodium]: https://modrinth.com/mod/sodium "Sodium Modrinth page"

build_logic/src/main/kotlin/lambdynamiclights/Constants.kt

@@ -5,7 +5,7 @@ import org.gradle.accessors.dm.LibrariesForLibs
 object Constants {
 	const val GROUP = "dev.lambdaurora"
 	const val NAME = "lambdynamiclights"
-	const val VERSION = "3.1.1"
+	const val VERSION = "3.1.2"
 	const val JAVA_VERSION = 21
 
 	private var minecraftVersion: String? = null

src/main/java/dev/lambdaurora/lambdynlights/LambDynLightsConstants.java

@@ -15,7 +15,7 @@
  * Contains constants about LambDynamicLights.
  *
  * @author LambdAurora
- * @version 3.0.1
+ * @version 3.1.2
  * @since 3.0.1
  */
 public final class LambDynLightsConstants {
@@ -24,6 +24,11 @@ public final class LambDynLightsConstants {
 	 */
 	public static final String NAMESPACE = "lambdynlights";
 
+	/**
+	 * The unsupported development mode text.
+	 */
+	public static final String DEV_MODE_OVERLAY_TEXT = "[LambDynamicLights Dev Version (Unsupported)]";
+
 	/**
 	 * {@return {@code true} if this mod is in development mode, or {@code false} otherwise}
 	 */

src/main/java/dev/lambdaurora/lambdynlights/api/DynamicLightHandler.java

@@ -10,6 +10,7 @@
 package dev.lambdaurora.lambdynlights.api;
 
 import dev.lambdaurora.lambdynlights.LambDynLights;
+import net.minecraft.world.entity.Entity;
 import net.minecraft.world.entity.LivingEntity;
 import net.minecraft.world.entity.monster.Creeper;
 import org.jetbrains.annotations.NotNull;
@@ -22,7 +23,7 @@
  *
  * @param <T> The type of the light source.
  * @author LambdAurora
- * @version 1.3.0
+ * @version 3.1.2
  * @since 1.1.0
  */
 public interface DynamicLightHandler<T> {
@@ -52,7 +53,7 @@ default boolean isWaterSensitive(T lightSource) {
 	 * @param <T> The type of the entity.
 	 * @return The completed handler.
 	 */
-	static <T extends LivingEntity> @NotNull DynamicLightHandler<T> makeHandler(
+	static <T extends Entity> @NotNull DynamicLightHandler<T> makeHandler(
 			Function<T, Integer> luminance, Function<T, Boolean> waterSensitive
 	) {
 		return new DynamicLightHandler<>() {

src/main/java/dev/lambdaurora/lambdynlights/api/DynamicLightHandlers.java

@@ -20,7 +20,7 @@
 
 /**
  * @author LambdAurora
- * @version 3.0.0
+ * @version 3.1.2
  * @since 1.1.0
  */
 public final class DynamicLightHandlers {
@@ -32,6 +32,7 @@ private DynamicLightHandlers() {
 	 * Registers the default handlers.
 	 */
 	public static void registerDefaultHandlers() {
+		registerDynamicLightHandler(EntityType.ALLAY, allay -> 8);
 		registerDynamicLightHandler(EntityType.BLAZE, DynamicLightHandler.makeHandler(blaze -> 10, blaze -> true));
 		registerDynamicLightHandler(EntityType.CREEPER, DynamicLightHandler.makeCreeperEntityHandler(null));
 		registerDynamicLightHandler(EntityType.ENDERMAN, entity -> {
@@ -41,7 +42,8 @@ public static void registerDefaultHandlers() {
 			return luminance;
 		});
 		registerDynamicLightHandler(EntityType.ITEM,
-				entity -> LambDynLights.getLuminanceFromItemStack(entity.getItem(), entity.isSubmergedInWater()));
+				entity -> LambDynLights.getLuminanceFromItemStack(entity.getItem(), entity.isSubmergedInWater())
+		);
 		registerDynamicLightHandler(EntityType.ITEM_FRAME, entity -> {
 			var world = entity.level();
 			return LambDynLights.getLuminanceFromItemStack(entity.getItem(), !world.getFluidState(entity.getBlockPos()).isEmpty());
@@ -56,6 +58,12 @@ public static void registerDefaultHandlers() {
 		registerDynamicLightHandler(EntityType.GLOW_SQUID,
 				entity -> (int) MathHelper.clampedLerp(0.f, 12.f, 1.f - entity.getDarkTicksRemaining() / 10.f)
 		);
+
+		// Fireballs and other similar entities
+		registerDynamicLightHandler(EntityType.FIREBALL, DynamicLightHandler.makeHandler(ball -> 14, ball -> true));
+		registerDynamicLightHandler(EntityType.SMALL_FIREBALL, DynamicLightHandler.makeHandler(ball -> 12, ball -> true));
+		registerDynamicLightHandler(EntityType.DRAGON_FIREBALL, ball -> 14);
+		registerDynamicLightHandler(EntityType.WITHER_SKULL, ball -> 12);
 	}
 
 	/**
@@ -99,8 +107,12 @@ private static <T> void register(DynamicLightHandlerHolder<T> holder, DynamicLig
 	 * @return {@code true} if the entity can light up, otherwise {@code false}
 	 */
 	public static <T extends Entity> boolean canLightUp(T entity) {
-		if (entity == Minecraft.getInstance().player && !LambDynLights.get().config.getSelfLightSource().get())
+		if (entity == Minecraft.getInstance().player) {
+			if (!LambDynLights.get().config.getSelfLightSource().get())
+				return false;
+		} else if (!LambDynLights.get().config.getEntitiesLightSource().get()) {
 			return false;
+		}
 
 		var setting = DynamicLightHandlerHolder.cast(entity.getType()).lambdynlights$getSetting();
 		return !(setting == null || !setting.get());

src/main/java/dev/lambdaurora/lambdynlights/mixin/DebugScreenOverlayMixin.java

@@ -10,6 +10,7 @@
 package dev.lambdaurora.lambdynlights.mixin;
 
 import dev.lambdaurora.lambdynlights.LambDynLights;
+import dev.lambdaurora.lambdynlights.LambDynLightsConstants;
 import net.minecraft.TextFormatting;
 import net.minecraft.client.gui.components.DebugScreenOverlay;
 import org.spongepowered.asm.mixin.Mixin;
@@ -23,7 +24,7 @@
  * Adds a debug string for dynamic light sources tracking and updates.
  *
  * @author LambdAurora
- * @version 1.3.2
+ * @version 3.1.2
  * @since 1.3.2
  */
 @Mixin(DebugScreenOverlay.class)
@@ -46,5 +47,9 @@ private void onGetLeftText(CallbackInfoReturnable<List<String>> cir) {
 
 		builder.append(')');
 		list.add(builder.toString());
+
+		if (LambDynLightsConstants.isDevMode()) {
+			list.add(TextFormatting.RED + LambDynLightsConstants.DEV_MODE_OVERLAY_TEXT);
+		}
 	}
 }

src/main/java/dev/lambdaurora/lambdynlights/mixin/DevModeMixin.java

@@ -11,29 +11,37 @@
 
 import com.llamalad7.mixinextras.injector.wrapoperation.Operation;
 import com.llamalad7.mixinextras.injector.wrapoperation.WrapOperation;
+import dev.lambdaurora.lambdynlights.LambDynLightsConstants;
 import net.minecraft.client.Minecraft;
 import net.minecraft.client.gui.GuiGraphics;
 import net.minecraft.client.renderer.GameRenderer;
+import org.spongepowered.asm.mixin.Final;
 import org.spongepowered.asm.mixin.Mixin;
 import org.spongepowered.asm.mixin.Shadow;
 import org.spongepowered.asm.mixin.injection.At;
 
 @Mixin(GameRenderer.class)
 public class DevModeMixin {
 	@Shadow
-	private Minecraft minecraft;
+	@Final
+	Minecraft minecraft;
 
 	@WrapOperation(
 			method = "Lnet/minecraft/client/renderer/GameRenderer;render(Lnet/minecraft/client/DeltaTracker;Z)V",
 			at = @At(value = "INVOKE", target = "Lnet/minecraft/client/gui/GuiGraphics;flush()V")
 	)
 	private void handler(GuiGraphics graphics, Operation<Void> original) {
-		final String text = "[LambDynamicLights Dev Version (Unsupported)]";
 		int bottom = this.minecraft.getWindow().getGuiScaledHeight();
 		int y = bottom - this.minecraft.font.lineHeight;
 
-		graphics.fill(0, y - 4, this.minecraft.font.width(text) + 4, bottom, 0xaa000000);
-		graphics.drawShadowedText(this.minecraft.font, text, 2, y - 2, 0xff0000);
+		if (this.minecraft.isGameLoadFinished() && !this.minecraft.getDebugOverlay().showDebugScreen()) {
+			graphics.fill(
+					0, y - 4,
+					this.minecraft.font.width(LambDynLightsConstants.DEV_MODE_OVERLAY_TEXT) + 4, bottom,
+					0xaa000000
+			);
+			graphics.drawShadowedText(this.minecraft.font, LambDynLightsConstants.DEV_MODE_OVERLAY_TEXT, 2, y - 2, 0xff0000);
+		}
 		original.call(graphics);
 	}
 }

src/main/java/dev/lambdaurora/lambdynlights/mixin/lightsource/AbstractHurtingProjectileEntityMixin.java

@@ -46,7 +46,7 @@
  * Represents an item light sources manager.
  *
  * @author LambdAurora
- * @version 3.1.1
+ * @version 3.1.2
  * @since 1.3.0
  */
 public final class ItemLightSources implements ItemLightSourceManager, IdentifiableResourceReloadListener {
@@ -167,12 +167,21 @@ public Event<Identifier, OnRegister> onRegisterEvent() {
 	public int getLuminance(ItemStack stack, boolean submergedInWater) {
 		boolean shouldCareAboutWater = submergedInWater && LambDynLights.get().config.getWaterSensitiveCheck().get();
 
-		int luminance = Block.byItem(stack.getItem()).defaultState().getLightEmission();
+		int luminance = 0;
+		boolean matchedAny = false;
 
 		for (var data : lightSources) {
-			if (shouldCareAboutWater && data.waterSensitive()) continue;
+			if (data.predicate().test(stack)) {
+				matchedAny = true;
 
-			luminance = Math.max(luminance, data.getLuminance(stack));
+				if (shouldCareAboutWater && data.waterSensitive()) continue;
+
+				luminance = Math.max(luminance, data.getLuminance(stack));
+			}
+		}
+
+		if (!matchedAny) {
+			luminance = Block.byItem(stack.getItem()).defaultState().getLightEmission();
 		}
 
 		return luminance;

src/main/java/dev/lambdaurora/lambdynlights/resource/item/ItemLightSources.java

@@ -31,7 +31,7 @@
   "depends": {
     "fabricloader": ">=0.16.5",
     "fabric-api": ">=0.100.4+1.21",
-    "minecraft": "~1.21",
+    "minecraft": "~1.21 <1.21.2-",
     "spruceui": ">=5.1.0",
     "java": ">=21"
   },

src/main/resources/fabric.mod.json

@@ -3,7 +3,6 @@
   "package": "dev.lambdaurora.lambdynlights.mixin.lightsource",
   "compatibilityLevel": "JAVA_21",
   "client": [
-    "AbstractHurtingProjectileEntityMixin",
     "AbstractMinecartEntityMixin",
     "BlockAttachedEntityMixin",
     "EntityMixin",